Koha-clms/opac
Jonathan Druart fb24426f25 Bug 16041: Turn off StaffAuthorisedValueImages by default
This feature is enabled by default, but the users are not aware of it
and it costs a lot of time processing to get the images.

There are 2 prefs to drive this feature: StaffAuthorisedValueImages and
AuthorisedValueImages. AuthorisedValueImages is not added by sysprefs.sql and
does not appear in updatedatabase.pl, we could easily imagine that
nobody uses it.
With XSLT enabled, the feature is only visible on a record detail page
at the OPAC, if AuthorisedValueImages is set.
Otherwise you need to turn the XSLT off. In this case you will see the
images on the result list (OPAC+Staff interfaces) and OPAC detail page,
but not the Staff detail page.

The idea of this patch is to introduce a quick switch if the feature is
not used by the library.

Test plan:
1/ Turn the pref on and set authorised_values.imageurl to NULL
Execute the DB entry
=> The pref have been turned off
2/ Turn the pref on and set an image for an authorised value
Execute the DB entry
You will get a warning
3/ Turn the pref off and set an image for an authorised value
Execute the DB entry
You will get a warning
4/ Turn the pref off and set authorised_values.imageurl to NULL
Execute the DB entry
You won't get a warning

Note that the opac detail page now checks the pref before retrieving the
images.

Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Fixed update message 'that means'.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 78605bceb3)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
2016-05-16 09:30:32 +02:00
..
errors Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
rss adding file just for creating the rss directory 2007-08-02 08:50:43 +00:00
sco Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page 2016-05-09 10:39:17 +02:00
svc Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
ilsdi.pl Bug 6679 - Fixing code so it passes basic Perl:::Critic tests 2016-01-27 15:26:02 +01:00
maintenance.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
oai.pl Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) 2016-03-23 09:56:12 +01:00
opac-ISBDdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-MARCdetail.pl Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl 2015-12-31 14:03:23 +01:00
opac-account.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-addbybiblionumber.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-04 22:22:29 +01:00
opac-alert-subscribe.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-authorities-home.pl Bug 14076: Do not use CGI->param in list context - opac-authorities-home.pl 2016-04-08 07:42:12 +02:00
opac-authoritiesdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-basket.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-blocked.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-browser.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-changelanguage.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-detail.pl Bug 16041: Turn off StaffAuthorisedValueImages by default 2016-05-16 09:30:32 +02:00
opac-discharge.pl Bug 15823: Redirect opac-discharge.pl to 404 page 2016-05-16 09:23:13 +02:00
opac-downloadcart.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-downloadshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-04 22:22:29 +01:00
opac-export.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-ics.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-idref.pl Bug 8992: Interfacing with the Idref webservice 2015-04-28 15:46:26 -03:00
opac-image.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-imageviewer.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-main.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-01-29 15:59:43 +01:00
opac-memberentry.pl Bug 14956: (followup) Fix birthday date validation in Opac 2015-11-06 15:01:37 -03:00
opac-messaging.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-modrequest-suspend.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-modrequest.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-mymessages.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-news-rss.pl Bug 7843: (QA followup) Make news selection persistant 2015-04-30 16:33:21 -03:00
opac-overdrive-search.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-passwd.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-patron-image.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-privacy.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-ratings-ajax.pl Bug 14553: Silencing warn triggered when clearing item rating on OPAC 2015-11-11 11:08:50 -03:00
opac-ratings.pl Bug 16179: Do not crash if "rate me" is clicked and not rate selected 2016-04-21 10:14:07 +02:00
opac-readingrecord.pl Bug 14100: Fix 3 occurrences more 2015-10-27 12:34:07 -03:00
opac-registration-verify.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-07-24 13:44:39 -03:00
opac-renew.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-reserve.pl Bug 15375 [QA Followup] - Fix non-functional restriction message and date 2016-01-29 16:06:33 +01:00
opac-restrictedpage.pl Bug 13485: Use the Koha template plugin to access syspref values 2015-08-11 15:15:36 -03:00
opac-retrieve-file.pl Bug 14321: Integrate Upload.pm into Koha 2015-09-25 12:02:52 -03:00
opac-review.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-search-history.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-search.pl Bug 15818 - OPAC search with utf-8 characters and without results generates encoding error 2016-02-26 11:05:30 +01:00
opac-sendbasket.pl Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-08 10:38:08 -03:00
opac-sendshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-04 22:22:29 +01:00
opac-serial-issues.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-shareshelf.pl Bug 16317 - Attempt to share private list results in error 2016-04-25 14:15:51 +02:00
opac-shelves.pl Bug 16296 - Fix records displaying in virtualshelves 2016-04-25 14:17:42 +02:00
opac-showmarc.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-showreviews.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-suggestions.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-tags.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-tags_subject.pl Bug 14412: SQL injection possible 2015-06-22 11:00:10 -03:00
opac-topissues.pl Bug 14100: Fix some missing occurrences 2015-10-27 12:34:07 -03:00
opac-user.pl Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 2016-02-26 14:01:50 +01:00
tracklinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
unapi Bug 15190: Bad utf8 decode to unapi and fixing status code 200 2016-01-29 16:05:11 +01:00