Fridolin Somers eae8863fcb Bug 30883: Authorities merge is limited to 100 biblio with Elasticsearch ... In C4::AuthoritiesMarc::merge, we search all biblio records using an authority with Koha::Authorities->linked_biblionumbers(). This method uses simple_search_compat() with no results limit, even saying in comment : 44d6528b56/Koha/Authorities.pm (L80) With Zebra searchengin it is correct. But not with Elasticsearch, there is an hardcoded limit at 100 in case no limit is given : 44d6528b56/Koha/SearchEngine/Elasticsearch/Search.pm (L346) This means authorities links are wrong after a merge or an edit in case the authority is used in more than 100 biblio records. :( I propose to fix by using by default the real server max given by Koha::SearchEngine::Elasticsearch::Search::max_result_window(). This will allow a huge limit nearly impossible to reach. See Bug 30882 to how increase this limit. Test plan : 1) Use Elasticsearch search engine 2) Use an authority id=111 linked to 200 biblio records 3) Perform a search 'an:111', you get 200 results 4) Create a new authority id=222 linked to 2 biblio records 5) Perform a search 'an:222', you get 2 results 6) Perform a merge of the two authorties, keeping id=222 7) Perform a search 'an:111' without patch you get 100 results with patch you get no results 8) Perform a search 'an:222' without patch you get 102 results with patch you get 202 results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit 48d4b016ab) Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>		2022-06-24 16:03:54 +00:00
..
Elasticsearch	Bug 30883: Authorities merge is limited to 100 biblio with Elasticsearch	2022-06-24 16:03:54 +00:00
Zebra	Bug 28484: (QA follow-up) POD fix	2021-09-29 11:34:18 +02:00
Elasticsearch.pm	Bug 29844: Fix ->search occurrences	2022-02-09 15:36:23 -10:00
Indexer.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
QueryBuilder.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Search.pm	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00