gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Ian Walls 86f9e19bab Bug 7073: GetCOinSBiblio should take $record object, not biblionumber 
This patch changes the GetCOinsBiblio subroutine to take a MARC record object
(as returned from GetMarcBiblio) instead of a biblionumber.  The first thing the subroutine
did was GetMarcBiblio, and the $biblionumber passed was never used again.

This subroutine was only used 3 places: opac/opac-search.pl, opac/opac-detail.pl,
and C4/VirtualShelves/Page.pm.  In the first and last cases, it was used in a loop.
In the last two cases, a call to GetMarcBiblio had already been done.  This is expensive, and
we were doing it twice per record.

For opac/opac-search.pl, the call to GetMarcBiblio was moved to just outside GetCOinSBiblio;
this will not change the performance at all.  But for opac/opac-detail.pl and C4/VirtualShelves/Page.pm,
a redudant call to GetMarcBiblio is now avoided.

To Test:
1. Enable COinSinOPACResults in system preferences.  Perform a search in the OPAC.
   Verify that the COinS spans are showing up
2. View the detail record of one of the returned items.  Confirm that the COinS span exists on the detail page.
3. View a list in the OPAC.  Confirm that COinS spans are still showing up

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit f56e6c0a58)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
 		2011-12-02 18:27:41 -05:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:42:19 +13:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-03-29 21:54:12 +13:00
Creators bug_6318: Always give predefined fields drop downs on label layout edit 2011-09-16 11:23:59 +12:00
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Fix for Bug 6458 - incorrect parsing result in translation processing 2011-09-15 08:38:58 +12:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ILSDI Bug 5639 (MT #3605) Fix escaping in ILSDI 2011-08-05 09:07:15 +12:00
Installer Bug 7078: Remove HTML::Template::Pro from Koha perl dependencies list 2011-10-22 09:01:26 +13:00
Labels bug 5653: use itemcallnumber in bib label layouts 2011-06-13 11:15:34 +12:00
Members bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
Output Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 6755 : Fixing a bug with guided reports 2011-09-27 07:04:02 +13:00
SIP Bug 3704: SIP Checkin of not checked out item returns error without reason 2011-09-22 19:39:29 +12:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
VirtualShelves Bug 7073: GetCOinSBiblio should take $record object, not biblionumber 2011-12-02 18:27:41 -05:00
tests Bug 2505 - Add commented use warnings where missing in the C4/ directory 2010-04-21 20:25:32 +12:00
Accounts.pm bug_5533: Slightly improved marking items as lost 2011-10-18 09:01:39 +13:00
Acquisition.pm Bug 7254 Show pending orders from baskets with closedate > 180 days 2011-12-02 15:47:21 -05:00
Auth.pm Bug 6483 - Paging in opac-detail when coming from a search 2011-10-21 04:57:09 +13:00
Auth_cas_servers.yaml.orig Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_cas.pm Bug 5630 CAS improvements 2011-10-13 10:49:49 +13:00
Auth_with_ldap.pm Merge remote-tracking branch 'kc/new/bug_5995' into kcmaster 2011-10-15 12:59:34 +13:00
AuthoritiesMarc.pm 6094 Fixing ModAuthority problems 2011-10-20 11:28:53 +13:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm Bug 7073: GetCOinSBiblio should take $record object, not biblionumber 2011-12-02 18:27:41 -05:00
Bookseller.pm Bug 3388: Restore account number on vendor page 2011-12-02 15:47:23 -05:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-02 08:51:33 +13:00
Branch.pm Bug 7034: de-nesting C4/Branch.pm 2011-10-19 03:23:31 +13:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-06 08:22:06 +13:00
Budgets.pm bug_4831: Use unitprice (actual cost) when totalling spent amounts for "All available funds", as in "Already received" 2011-09-22 19:35:40 +12:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm Bug 6989 Patron categories not properly displayed if not pure ASCII 2011-11-16 07:40:59 -05:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm Bug 7191 Remove GetBorrowerIssues from @EXPORT 2011-12-02 15:47:26 -05:00
ClassSortRoutine.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
ClassSource.pm Bug 7035 de-nesting C4::ClassSource & ClassSortRoutine 2011-10-19 03:25:59 +13:00
Context.pm Bug 7188: C4::Context::db_scheme2dbi does case-insensitive grep 2011-11-16 07:44:06 -05:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Csv.pm Bug 2505 - Add commented use warnings where missing in *.pm 2010-04-21 20:28:51 +12:00
Dates.pm Fix for Bug 4473 - Recent comments view for the OPAC 2010-12-13 09:43:01 +13:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
ImportBatch.pm Bug 5859: Allow user to set encoding for import 2011-04-19 13:05:48 +12:00
ImportExportFramework.pm Bug 6723 : import-framework-crlf 2011-08-26 12:46:52 +12:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm Bug 6537 - squashed version of the previous 5 commits, signed-off 2011-09-07 09:19:07 +12:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ItemType.pm Bug 6371 Item Types description not properly displayed if not pure ASCII 2011-10-08 20:10:29 +13:00
Items.pm 7146 (Update timestamps when deleting a biblio) 2011-11-16 07:41:41 -05:00
Koha.pm Merge remote branch 'kc/new/pending_qa/enh/bug_3644' into kcmaster 2011-04-09 19:16:45 +12:00
Labels.pm Bringing label, patroncard, and creator modules into conformity with the rest of C4 style. 2010-02-08 20:54:34 -05:00
Languages.pm Bug 6755 Web browser default lang != syspref selected langs 2011-09-26 23:26:09 +13:00
Letters.pm Bug 5263 - Add support for including fields from the ISSUES table in advanced due notices 2011-08-02 12:44:42 +12:00
Log.pm Bug 6460: alternative fix, updating template and script instead of C4::Log 2011-09-24 10:01:09 +12:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm bug_6253: Unified member Search() 2011-10-19 16:23:02 +13:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm Fix FSF address in directory C4/ 2010-03-16 20:17:56 -04:00
Output.pm Bug 6755 follow up, fixing broken POD 2011-09-23 11:33:00 +12:00
Overdues.pm Bug 6927-- Typo in C4::Overdues.pm 2011-09-28 09:24:17 +13:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Print.pm Bug 7037 de-nesting C4/Print.pm 2011-10-19 03:48:21 +13:00
Record.pm Bug 5453 : Move declarations out of conditionals 2011-07-15 15:50:24 +12:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm Bug 7057: CheckReserves uses GetMemberDetails unnecessarily 2011-10-20 14:03:20 +13:00
Review.pm Fix for Bug 4473 - Recent comments view for the OPAC 2010-12-13 09:43:01 +13:00
Ris.pm bug 5780 followup: RIS export now includes all URLs 2011-10-14 10:37:31 +13:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm Bug 7134: patron records getting corrupted birthdates 2011-11-19 17:02:47 -05:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-13 08:17:27 +13:00
Search.pm Bug 5528: Analytic records support 2011-10-13 10:03:39 +13:00
Serials.pm Bug 6315: Fix depreciated constructions in C4::Serials 2011-05-15 20:42:08 +12:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 5947 Suggestions : add date to the search query 2011-04-05 11:06:28 +12:00
TTParser.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
Tags.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Templates.pm Bug 6629 : Sanitizing input from language cookie 2011-11-28 20:08:46 -05:00
TmplToken.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
TmplTokenType.pm Bug 6458 Template Toolkit files test case 2011-08-18 21:11:50 +12:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm
…
VirtualShelves.pm Bug 6555 : only 10 lists show in the staff client 2011-09-07 09:00:38 +12:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-07 14:18:09 +13:00
XSLT.pm Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00