gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
50,436 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Nick Clemens a65964c35b Bug 34678: Allow new entries to overwrite hold_fill_targets 
When using background jobs, there is a possibility of a race condition where two jobs will be updating the holds queue for the same biblio. We should try to minimize those cases (see bug 34596)

In the meantime though, we should prevent jobs possibly dying, and allow the most recent update to succeed.

There is a possibility two updates wil assign different items to the same reserve, and that a reserve could end up in the queue twice, however, whichever one is filled first will delete both entries. as filling the hold deletes by reserve id (see bug 24359)

This patch adds a transaction to delete and then inset the new row

To test:
1 - prove -v t/db_dependent/Reserves.t
2 - It fails
3 - Apply patch
4 - t/db_dependent/Reserves.t
5 - It succeeds!

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(cherry picked from commit bbeab36789)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
 		2023-11-07 21:37:08 -10:00
C4 Bug 34678: Allow new entries to overwrite hold_fill_targets 2023-11-07 21:37:08 -10:00
Koha Bug 33606: (QA follow-up) Cosmetic changes 2023-11-02 11:17:31 -10:00
acqui Bug 34908: Sort item types alphabetically by description when adding a new empty record as an order to a basket 2023-10-25 22:40:04 -10:00
admin Bug 34369: Require CSRF token for updating system preferences 2023-09-26 21:29:27 -10:00
api Bug 33606: Mark the endpoint as experimental 2023-11-02 11:17:31 -10:00
authorities Bug 33406: (QA follow-up) Adjust tests and tidy 2023-09-17 22:49:50 -10:00
basket Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
bin
…
catalogue Bug 33047: Return 404 instead of 500 when biblio does not exist 2023-07-18 10:28:24 +01:00
cataloguing Bug 34171: Use barcodedecode when attaching items to another record 2023-10-25 12:19:17 -10:00
circ Bug 34910: Do not allow checkout for anonymous patron 2023-11-07 21:09:50 -10:00
clubs Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
course_reserves Bug 20256: Use new methods 2023-02-02 11:59:26 -03:00
debian Bug 34204: Fix koha-shell under debian 12 2023-10-24 21:31:49 -10:00
docs Bug 34800: Adding openhub links for Koha contributors 2023-10-24 20:24:07 -10:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 29420: HTTP status code incorrect when calling error pages directly under Plack/PSGI 2022-04-20 09:03:39 -10:00
etc Bug 30843: Add mfa_range configuration option for TOTP 2023-10-05 08:36:20 -10:00
ill Bug 28909: Allow illview to use backend template 2022-08-09 13:21:39 -03:00
installer Increment version for 23.05.05 release 2023-11-07 20:34:30 -10:00
koha-tmpl Bug 33662: Add link to acq advanced search to acq navigation 2023-11-07 21:19:18 -10:00
labels Bug 31633: (follow-up) Group template params 2022-10-03 14:09:59 -03:00
lib/CGI/Session/Serialize
…
members Bug 34910: (follow-up) alert in patron details 2023-11-07 21:09:50 -10:00
misc Bug 34954: Fixed typo to 'dateexpiry' 2023-11-07 21:12:40 -10:00
offline_circ Bug 33961: Remove built-in offline circ tool 2023-07-17 08:18:59 +01:00
opac Bug 33074: Take ReservesControlBranch into account in opac-reserve.pl 2023-10-09 09:56:08 -10:00
patron_lists
…
patroncards Bug 24001: Fix patron card template edition 2022-04-28 10:49:20 -10:00
plugins Bug 30367: (follow-up) Same adjustment for gitlab 2023-05-05 10:18:57 -03:00
pos Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
recalls Bug 34013: Recalls awaiting pickup doesn't show count on each tab 2023-07-17 14:51:00 +01:00
reports Bug 34859: Remove unnecessary params from reports-home.pl 2023-10-05 14:52:14 -10:00
reserve Bug 34634: Show expirationdate of expired holds on reserve/request.pl 2023-09-07 20:13:21 -10:00
reviews
…
rotating_collections
…
serials Bug 34146: Counterpart for serials-edit 2023-07-17 15:57:40 +01:00
services
…
skel
…
suggestion Bug 26994: List names in alphabetical order in Suggestion filter 2023-10-25 20:14:28 -10:00
svc Bug 34014: (follow-up) No need to parse old record before updating 2023-10-25 11:58:38 -10:00
t Bug 34678: Unit test 2023-11-07 21:37:08 -10:00
tags Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
tools Bug 26978: Add item type option to batch extend due date tool 2023-10-12 13:58:06 -10:00
virtualshelves Bug 34731: Don't call SendQueuedMessages if message_id is bad 2023-09-14 07:54:48 -10:00
xt Bug 34911: Test files from HEAD instead of 'master' 2023-10-05 09:38:43 -10:00
.editorconfig
…
.eslintrc.json
…
.gitignore Bug 33710: Ignore how-to related files 2023-05-12 17:50:01 -03:00
.htaccess
…
.mailmap Update .mailmap 2023-07-17 08:12:22 +01:00
.perlcriticrc
…
.perltidyrc Bug 30002: Adjust perltidy 2023-07-12 07:55:00 +01:00
.proverc.dist
…
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL
…
Koha.pm Increment version for 23.05.05 release 2023-11-07 20:34:30 -10:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 26700: Remove occurrences in Makefile.PL 2023-07-17 11:01:46 +01:00
README
…
README.md
…
README.robots
…
about.pl Bug 33934: Add more detail to 'No encryption_key in koha-conf.xml' 2023-06-09 12:05:00 -03:00
app.psgi
…
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl
…
cpanfile Bug 33964: (QA follow-up) Remove library from cpanfile 2023-08-07 20:05:46 -10:00
cypress.json Bug 33408: Extend defaultCommandTimeout for cypress 2023-04-13 11:48:00 -03:00
fix-perl-path.PL
…
gulpfile.js Revert "Bug 35024: Do not wrap translations" 2023-11-03 10:27:54 -10:00
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 35019: Add a CSRF token when deleting news 2023-10-25 20:22:12 -10:00
package.json Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00
rewrite-config.PL
…
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 32806: Move main-erm.ts to modules/erm.ts 2023-02-27 11:12:01 -03:00
yarn.lock Bug 33066: Introduce a KohaTable Vue component 2023-04-10 07:38:28 -03:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo