gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/C4
History
Ian Walls a15becb9d1 Bug 6613: CSV basket export columns misaligned 
Removes 'line' heading, since it does not correspond to any existing field name, and it pushes the fields
over by one ('ordernumber' is used to denote the ordernumber).

This patch also optimizes the GetBasketAsCSV subroutine a bit; it removes an unnecessary call to GetBiblioData,
since the order information retrieved from GetOrders already contains every field in koha.biblio and koha.biblioitems

This patch also removes the explicit sort done by publishercode, since the information returned by GetOrders is
already ORDER BY'ed, first by publishercode, then by title (there was a FIXME note in GetBasketAsCSV to do this, but
it's already done, so... :) )

To Test:
1.  Create a basket with at least three orders:  one from one publishercode, and two from another
2.  Be sure to leave out any "\n" in your Order Notes, lest you fall prey to bug 6614!
3.  Export the basket
4.  You should see the orders sorted first by publishercode, then by title
5.  Columns should line up correct all the way through

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
(cherry picked from commit c414c11d64)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
 		2011-07-22 16:30:42 -04:00
..
AuthoritiesMarc Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Barcodes Bug 5385 - Fixing an error that crept in with the POD cleanup 2010-11-12 10:42:19 +13:00
Cache Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ClassSortRoutine Bug 4265: Fix padding of short callnumbers and Bib-1 attribute for sorting 2011-03-29 21:54:12 +13:00
Creators Bug 2246 - (Partial) Label printing doesn't work with Unicode characters 2011-06-13 20:46:15 -04:00
External Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
Form Bug 5918 : Use the default messaging preferences if the user does not select any 2011-06-03 15:06:49 -04:00
Heading Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
ILSDI Bug 5450 Avoid a name clash in ILSDI modules 2010-12-01 10:05:51 +13:00
Installer Lower dependency on Storable to 2.20 in PerlDependencies.pm 2011-04-15 10:45:02 +12:00
Labels bug 5653: use itemcallnumber in bib label layouts 2011-06-13 20:59:37 -04:00
Members Bug 5379 - import_borrowers.pl fails with db insert/update errors 2011-07-10 14:31:23 -04:00
Output
…
Patroncards fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00
Reports Bug 6024 : add "Run report" link on the new report creation success page 2011-04-08 13:29:58 +12:00
SIP Bug 5422: Separate state field for patron's addresses 2011-04-09 11:52:07 +12:00
Search Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
VirtualShelves Bug 6215 : Fixing a bug with virtuallists 2011-04-21 11:39:58 +12:00
tests
…
Accounts.pm Bug 6452 : Use placeholders in sql but makepayment seems dead code ? 2011-06-03 15:15:24 -04:00
Acquisition.pm Bug 6613: CSV basket export columns misaligned 2011-07-22 16:30:42 -04:00
Auth.pm Bug 5995 : MT2892: Fix security issue in CAS intranet login 2011-05-15 15:03:22 -04:00
Auth_with_cas.pm
…
Auth_with_ldap.pm Bug 4994 - Net::LDAP returns lowercase names 2011-07-14 21:11:13 -04:00
AuthoritiesMarc.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
BackgroundJob.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Barcodes.pm Bug 5681: Fixes leading zeroes in Add Mulpiple Copies 2011-02-03 10:08:50 +13:00
Biblio.pm bug_6433: exception handling 2011-06-13 20:56:45 -04:00
Bookseller.pm Bug5063: C4::Bookseller Changes 2011-03-12 08:42:26 +13:00
Boolean.pm Bug 5448: Refactor Boolean.pm 2010-12-02 08:51:33 +13:00
Branch.pm Bug 5431 : Follow up patch fixing ModBranch 2011-04-12 08:55:20 +12:00
Breeding.pm Fix for Bug 4290 - search for author in repository 2011-03-06 08:22:06 +13:00
Budgets.pm Bug 5963 : Add the ability to filter budgets using the active column 2011-04-05 14:38:41 +12:00
Cache.pm Bug 5363 - Removing unused module (C4::Cache::FastMemcached) 2010-11-04 20:05:36 +13:00
Calendar.pm Fix for Bug 4991, Overhaul of Calendar interface 2010-11-02 15:02:54 +13:00
Category.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Charset.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Circulation.pm Bug 6450 - No check in/check out messages in message_queue 2011-07-10 14:30:38 -04:00
ClassSortRoutine.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ClassSource.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Context.pm Bug 5728: adding note and manager_id fields to accountlines 2011-04-09 21:25:18 +12:00
Contract.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Creators.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Csv.pm
…
Dates.pm Fix for Bug 4473 - Recent comments view for the OPAC 2010-12-13 09:43:01 +13:00
Debug.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Heading.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
ImportBatch.pm Bug 5859: Allow user to set encoding for import 2011-04-19 13:05:48 +12:00
ImportExportFramework.pm Bug 5478 - Automate MARC framework import/export 2011-04-01 21:17:33 +13:00
Input.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Installer.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
ItemCirculationAlertPreference.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ItemType.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Items.pm Bug 6050 Make calls to GetItemsInfo consistent 2011-06-19 16:03:48 -04:00
Koha.pm Merge remote branch 'kc/new/pending_qa/enh/bug_3644' into kcmaster 2011-04-09 19:16:45 +12:00
Labels.pm
…
Languages.pm bug 4188: move PDF templates for printed purchase orders 2010-07-02 08:49:44 -04:00
Letters.pm Bug #6130 - Letters: Fixing Subject encoding 2011-04-09 10:35:15 +12:00
Log.pm Bug 6470 - Unable to filter out log entries for kohaadmin (user 0) 2011-07-10 14:31:54 -04:00
Maintainance.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Matcher.pm Bug 5415 Let calls of SimpleSearch utilize considtent interface 2011-04-08 13:52:57 +12:00
Members.pm Bug 3674: reimplementation 2011-07-10 14:36:05 -04:00
Message.pm POD Cleanups 2010-06-09 08:38:59 -04:00
NewsChannels.pm
…
Output.pm Bug 6085 : Fixing the utf8 weirdness 2011-04-11 16:01:59 +12:00
Overdues.pm Bug #6064 Improvement of default value usage in overdue 2011-04-07 21:33:40 +12:00
Patroncards.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
Print.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Record.pm bug 5579 : Fixes several exports to embed items 2011-04-19 22:35:15 +12:00
Reports.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Reserves.pm Bug 6525: hold filled emails not going out 2011-06-27 07:31:40 -04:00
Review.pm Fix for Bug 4473 - Recent comments view for the OPAC 2010-12-13 09:43:01 +13:00
Ris.pm remove a bunch of unconditional debug warns 2010-07-02 10:57:08 -04:00
RotatingCollections.pm Fix some compile time errors reported in test suite 2010-12-02 08:53:53 +13:00
SMS.pm More POD cleanups 2010-06-09 08:38:58 -04:00
SQLHelper.pm Bug 6017 : MT3157 : editing an attribute lead to Error500 2011-04-08 14:14:32 +12:00
Scheduler.pm POD Cleanups 2010-06-09 08:38:59 -04:00
Scrubber.pm Bug 5611: Simple typo fix in the comments 2011-01-13 08:17:27 +13:00
Search.pm BUG4319 waiting items cannot be reserved 2011-06-13 20:58:52 -04:00
Serials.pm Bug 6315: Fix depreciated constructions in C4::Serials 2011-05-15 15:02:34 -04:00
Service.pm POD Cleanups 2010-06-09 08:38:59 -04:00
ShelfBrowser.pm Bug 5551 - allow shelf browser filters to be changed 2011-01-21 11:08:42 +13:00
Stats.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Suggestions.pm Bug 5947 Suggestions : add date to the search query 2011-04-05 11:06:28 +12:00
Tags.pm More POD cleanups 2010-06-09 08:38:58 -04:00
Templates.pm Bug 6459 : Needless call to C4::Context->dbh in C4::Templates::themelanguage() 2011-06-13 20:56:02 -04:00
UploadedFile.pm replace references to defunct info email address 2010-06-25 05:18:44 -04:00
Utils.pm
…
VirtualShelves.pm Fix for Bug 6402, Lists sorted by year appear to be empty 2011-06-13 20:57:11 -04:00
XISBN.pm Fix for Bug 5570 - item types not showing on other editions 2011-01-07 14:18:09 +13:00
XSLT.pm Merge remote branch 'kc/new/enh/bug_4421' into kcmaster 2011-04-02 07:15:47 +13:00
Z3950.pm fixing various links to point to *.koha-community.org 2010-10-21 22:08:24 -04:00