Jonathan Druart 0d364dacf6 Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new ... Recently we face the same issue on different modules after we moved them to the Koha namespace using Koha::Object of using DBIx::Class directly. 1/ Koha::Patron::Modification on bug 16960 comment 14 and 15 2/ Koha::Patron::Category from bug 17069 3/ C4::Members::AddMember (which does not use Koha::Object) on bug 16917 If a DB column is defined as NOT NULL and has a default value, the DBIx::Class $rs->update_or_insert method won't use the default value if the column name has been passed to the constructor. We do that almost everywhere as we retrieve the data from the HTML forms without checking/cleaning them. There are several ways to fix that: 1/ Continue to fix them case by case (what we did for the recent issues) 2/ Try to fix them globally (existing ones and the next ones) This patch propose a global solution to avoid future issues of this kind. The idea is not to pass the undefined values which cannot be nullable to the DBIx::Class constructor. Tested all patches together. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>		2016-10-21 17:33:18 +00:00
..
Acquisition	Bug 14778: Remove t/Acquisition/Invoices.t	2015-10-23 12:01:19 -03:00
Biblio	Bug 5979: follow to fix spelling	2016-04-22 03:14:23 +00:00
Budgets	…
Circulation	Bug 14632: Add Copyright for the Koha Dev Team	2016-04-29 18:06:40 +00:00
External	Bug 16636 [QA Followup] - Move tests to t/External	2016-06-10 18:02:14 +00:00
Koha	Bug 17302: [Follow-up] Make Normalize.pm undef-resistent	2016-09-25 14:04:54 +00:00
Members	Bug 14778: Use mock_dbh where it should be used	2015-10-23 12:01:18 -03:00
Number	Bug 16768: Add tests for Swiss number format	2016-06-24 14:00:03 +00:00
SIP	Bug 15006: Centralize timeout logic and allow zero client timeout	2016-07-15 14:11:05 +00:00
Search	…
Serials	Bug 16289: Refactore code and add tests	2016-06-10 18:09:48 +00:00
db_dependent	Bug 17080: Handle default values for NOT NULL columns from Koha::Object->new	2016-10-21 17:33:18 +00:00
edi_testfiles	Bug 7736: Support Ordering via Edifact EDI messages	2016-04-01 20:03:17 +00:00
lib	Bug 16890: Make TestBuilder generate date for date columns (and not datetime)	2016-07-15 14:59:46 +00:00
00-checkdatabase-version.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
00-deprecated.t	…
00-load.t	Bug 17372: Standardize Elasticsearch paths	2016-10-11 01:07:03 +00:00
00-merge-conflict-markers.t	Bug 9978: Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:38 -03:00
00-testcritic.t	Bug 15258: Prevent unused declared variables	2015-12-30 17:24:30 -07:00
00-valid-xml.t	Bug 16608 - Add xsd extension to t/00-valid-xml.t	2016-06-10 17:40:55 +00:00
AuthUtils.t	…
Auth_with_shibboleth.t	Bug 15611: Fix another implimented vs implemented	2016-01-27 05:17:21 +00:00
AuthoritiesMarc_MARC21.t	…
AuthoritiesMarc_UNIMARC.t	…
Barcodes_EAN13.t	…
Barcodes_annual.t	…
Barcodes_hbyymmincr.t	…
Barcodes_incremental.t	…
Biblio.t	Bug 16169: Change prototype for C4::Biblio::TransformMarcToKoha	2016-04-07 00:04:21 +00:00
Biblio2.t	Bug 16556 - KohaToMarcMapped columns sharing same field with biblio(item)number are removed.	2016-09-15 13:42:35 +00:00
Bookseller.t	…
Boolean.t	Bug 13814: (QA followup) test for generated warnings	2015-03-15 09:03:33 -03:00
Breeding.t	…
Budgets.t	…
Cache.t	Bug 16769: Uniformise calls to Koha::Cache->set_in_cache	2016-10-10 17:03:54 +00:00
Calendar.t	Bug 17189: Replace occurrences of 'use Koha::Cache'	2016-09-08 10:24:47 +00:00
Charset.t	Bug 14112: Silence warnings in t/Charset.t	2015-05-27 14:32:41 -03:00
Circulation_barcodedecode.t	Bug 15151: Avoid DB access to load C4::Members	2015-11-08 13:10:13 -03:00
ClassSortRoutine.t	…
ClassSortRoutine_Dewey.t	…
ClassSortRoutine_Generic.t	…
ClassSortRoutine_LCC.t	…
ClassSource.t	…
Context.t	Bug 14751: [QA Follow-up] Unit tests for interface method	2016-03-02 04:21:26 +00:00
Contract.t	…
Creators.t	Bug 16622: some tests triggered by prove t fail for unset KOHA_CONF	2016-08-05 06:09:58 +00:00
DateUtils.t	Bug 15445 DateUtils.t fails on Jenkins due to server sluggishness	2016-03-08 21:55:16 +00:00
Debug.t	Bug 14114: Silence warns and cleanup t/Debug.t	2015-05-22 09:33:34 -03:00
EdiInvoice.t	Bug 7736: Support Ordering via Edifact EDI messages	2016-04-01 20:03:17 +00:00
Edifact.t	Bug 7736: Support Ordering via Edifact EDI messages	2016-04-01 20:03:17 +00:00
Ediorder.t	Bug 7736: Support Ordering via Edifact EDI messages	2016-04-01 20:03:17 +00:00
Ediordrsp.t	Bug 7736: Support Ordering via Edifact EDI messages	2016-04-01 20:03:17 +00:00
Form_MessagingPreferences.t	…
Heading.t	…
Images.t	Bug 15150: Make t/ tests skip if Test::DBIx::Class absent	2015-11-06 12:25:27 -03:00
ImportBatch.t	Bug 10407: Add two subtests to t/ImportBatch.t	2016-09-02 16:00:13 +00:00
Installer_PerlDependencies.t	…
Installer_PerlModules.t	…
Installer_pm.t	…
ItemCirculationAlertPreference.t	…
Koha.t	Bug 15800: Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory	2016-03-02 03:54:16 +00:00
Koha_Email.t	…
Koha_MetadataRecord.t	Bug 8064: Fix unit tests for createMergeHash	2015-11-09 15:08:57 -03:00
Koha_Template_Plugin_Cache.t	…
Koha_Template_Plugin_Koha.t	Bug 13758: (QA followup) revert case change that broke the tests	2015-05-07 14:12:14 -03:00
Koha_Util_FrameworkPlugin.t	Bug 13437: Preliminary changes for marc21 plugins field 008	2015-06-10 12:51:26 -03:00
Koha_Util_MARC.t	Bug 8064: Fix unit tests for createMergeHash	2015-11-09 15:08:57 -03:00
Labels.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_ccn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_ddcn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Labels_split_lccn.t	Bug 9978: (followup) Replace license header with the correct license (GPLv3+)	2015-04-20 09:59:43 -03:00
Languages.t	Bug 16675: fix breakage of t/Languages.t	2016-06-10 17:03:10 +00:00
Letters.t	Bug 15150: Make t/ tests skip if Test::DBIx::Class absent	2015-11-06 12:25:27 -03:00
Log.t	…
Logger.t	Bug 14167: (QA followup) use warn instead of just STDERR	2015-07-21 10:50:17 -03:00
Matcher.t	Bug 17318: Unit tests	2016-10-21 16:16:33 +00:00
Members_AttributeTypes.t	Bug 12267: Remove borrower_attributes.password	2016-04-22 23:08:32 +00:00
Members_Attributes.t	Bug 12267: Remove borrower_attributes.password	2016-04-22 23:08:32 +00:00
Members_Messaging.t	…
Message.t	…
NorwegianPatronDB.t	…
OpenLibrarySearch.t	Bug 16649: Make OpenLibrarySearch test pass even if launches offline	2016-06-10 17:05:03 +00:00
Output.t	…
Output_JSONStream.t	…
Overdues.t	…
Patron.t	Bug 17226 - Fix unit tests	2016-10-11 05:17:37 +00:00
Patroncards.t	…
Patroncards_Batch.t	…
Patroncards_Layout.t	…
Patroncards_Lib.t	…
Patroncards_Patroncard.t	…
Patroncards_Profile.t	…
Patroncards_Template.t	…
Prices.t	Bug 16582 t/Price.t test should pass if Test::DBIx::Class is not available	2016-06-03 07:29:54 +00:00
Print.t	…
QueryParser.t	…
RecordProcessor.t	Bug 15871: Improve PerlCritic level for t/RecordProcessor.t	2016-03-03 22:02:50 +00:00
Ris.t	Bug 16668: Fix t/Ris.t tests	2016-06-10 16:59:20 +00:00
RotatingCollections.t	…
SMS.t	…
Scheduler.t	…
Scrubber.t	Bug 14116: Silence noisy output for t/Scrubber.	2015-06-01 14:10:56 -03:00
Search.t	…
Search_PazPar2.t	Bug 14117: Silence warnings t/SearchPazPar2.t	2015-06-01 14:10:14 -03:00
SimpleMARC.t	Bug 14098: Implement the copy_and_replace action for MTT	2015-09-07 11:17:13 -03:00
SocialData.t	Bug 15150: Make t/ tests skip if Test::DBIx::Class absent	2015-11-06 12:25:27 -03:00
Stats.t	…
SuggestionEngine.t	…
SuggestionEngine_AuthorityFile.t	…
TmplToken.t	…
Token.t	Bug 17110: Add unit test for MaxAge parameter in Token.t	2016-09-09 13:40:41 +00:00
XSLT.t	…
dummy.t	…
perlcriticrc	Bug 15258: Prevent unused declared variables	2015-12-30 17:24:30 -07:00
smolder_smoke_signal	…