Koha-clms/circ
Benjamin Rokseth a2b9db00cf
Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio
This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both slips
6) also note that there is no itemnumber or barcode in the requests from returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Maksim Sen <maksim.sen@inlibro.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
2018-06-05 12:47:18 +01:00
..
add_message.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
article-request-slip.pl Bug 17762: Send lang to GetPreparedLetter 2017-05-09 20:56:41 +00:00
article-requests.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
bookcount.pl Bug 19943: Gentle error handling for bookcount.pl 2018-03-23 12:32:05 -03:00
branchoverdues.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
branchtransfers.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
circulation-home.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
circulation.pl Bug 20067: Fix other checks for linked authorised value categories 2018-03-26 17:01:10 -03:00
del_message.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
hold-transfer-slip.pl Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio 2018-06-05 12:47:18 +01:00
offline-mf.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
offline.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
on-site_checkouts.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
overdue.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
pendingreserves.pl Bug 19287: (follow-up) Use the notice defined for the library of the patron 2018-05-24 10:11:48 -03:00
renew.pl Bug 16530: Add a new method to the Branches TT Plugin to avoid c/p 2017-03-03 18:34:36 +00:00
request-article.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
reserveratios.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
returns.pl Bug 20822: (bug 18789 follow-up) Fix HOLD_SLIP 2018-06-05 10:46:42 +01:00
selectbranchprinter.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
transfer-slip.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
transferstoreceive.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
view_holdsqueue.pl Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for view_holdsqueue] 2018-02-12 15:41:39 -03:00
waitingreserves.pl Bug 18789: Send Koha::Patron object to the templates 2018-02-16 13:03:58 -03:00
ypattrodue-attr-search-authvalue.pl Bug 19997: use Modern::Perl in Circulation perl scripts 2018-02-05 09:45:48 -03:00
ysearch.pl Bug 20707: Replace circ/search.pl circulate permission requirement with catalogue 2018-05-11 11:36:23 -03:00