gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/lib/KohaTest
History
Joe Atzberger 51e8fc2cb6 bug 3435: AddReturn overhaul. 
Required for SIP checkin implementation, but also for internal correctness.
AddReturn had too many things going on, with no guarantee of data being
available for the later calls.  At some point we started tacking on all the
branch transfer logic without testing edge cases.  In particular, $borrower
is not checked to be sure it is defined, considering the item may not have been
checked out so no borrower would be associated.  That means that CircControl
of "PatronLibrary" would be inaccurate, Circ Alerts will be totally confused
(untargeted), and the Fix... subs would fail.

Note that *many* errors are still present in _FixAccountForLostAndReturned, including
those where comments are added, such that it might behave strangely even with $borrower.

Renamed the internal subs with leading underscore, per convention.  Changed
the arguments to be scalars when only scalars are needed, not entire objects.
Added depth to WrongBranch message that includes Rightbranch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
 		2009-07-30 11:06:50 -04:00
..
Acquisition Bug 1953 [1/3]: test suite improvements 2008-07-27 06:10:47 -05:00
Biblio Bug 2505: adding warnings to C4/Biblio.pm 2009-01-05 16:16:38 -06:00
Branch bug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches 2008-05-12 15:07:17 -05:00
Calendar Bug 1953: adding tests and 2 corrections for C4::Calendar 2008-05-13 17:41:20 -05:00
Circulation bug 2758: don't confirm checkout if fine balance is 0 2008-12-02 16:44:20 -06:00
Context bug 1953 [1/2]: fixing SQL injection problem in C4::Context->preference 2008-07-24 11:25:58 -05:00
Dates bug 2503: tests for C4::Circulation 2008-08-20 17:05:24 -05:00
Heading bug 2315: no crash if subfield code is a metacharacter 2008-07-08 09:36:11 -05:00
ImportBatch test suite: C4::ImportBatch 2008-12-22 11:43:07 -06:00
Installer bug: 2176 improvements to database upgrade path 2008-06-20 17:47:36 -05:00
Items bug 2466: regression test 2008-08-28 09:22:57 -05:00
Koha Bug 1953 [1/6]: adding test module for C4::Koha::displayServers 2008-07-30 03:45:18 -05:00
Letters Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
Members Test suite: C4::Members::GetMemberDetails 2008-12-29 13:01:06 -06:00
Overdues Bug 2274 [3/5]: consolidating overdue notice cronjobs into one 2008-07-10 09:10:46 -05:00
SMS bug 2275: making SMS::Send module optional 2008-07-04 09:22:27 -05:00
Scripts bug 2503: tests for C4::Circulation 2008-08-20 17:05:24 -05:00
Search add calls to clear_syspref_cache() 2008-12-11 09:49:13 -06:00
Accounts.pm Commented out fixaccounts (not used anywhere). Also improved getnextacctno. 2008-05-29 07:04:37 -05:00
Acquisition.pm adding database-dependent test libs. 2008-04-21 11:26:28 -05:00
AuthoritiesMarc.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Biblio.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Branch.pm bug 1953: fixing potential SQL injection problems in C4::Branch::GetBranches 2008-05-12 15:07:17 -05:00
Breeding.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Calendar.pm Fines fixes: apparent problems with fines prevent processing. 2008-08-29 20:31:41 -05:00
Category.pm Tests for New Modules 2009-02-04 13:58:22 -06:00
Circulation.pm bug 3435: AddReturn overhaul. 2009-07-30 11:06:50 -04:00
Context.pm bug 1953 [1/2]: fixing SQL injection problem in C4::Context->preference 2008-07-24 11:25:58 -05:00
Dates.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Heading.pm bug 2315: no crash if subfield code is a metacharacter 2008-07-08 09:36:11 -05:00
ImportBatch.pm test suite: C4::ImportBatch 2008-12-22 11:43:07 -06:00
Installer.pm test suite: allow skipping of expensive tests 2008-05-19 13:25:57 -05:00
ItemCirculationAlertPreference.pm Tests for New Modules 2009-02-04 13:58:22 -06:00
ItemType.pm Tests for New Modules 2009-02-04 13:58:22 -06:00
Items.pm bug 2295 [3/4]: moving C4::Items tests into t/lib/KohaTest 2008-07-07 16:32:30 -05:00
Koha.pm remove incomplete bib bulk editing code 2009-04-06 10:53:50 -05:00
Labels.pm bug 2295 [4/4]: moving C4::Labels tests into t/lib/KohaTest 2008-07-07 16:32:31 -05:00
Letters.pm Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
Log.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Members.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Message.pm Tests for New Modules 2009-02-04 13:58:22 -06:00
NewsChannels.pm bug 3303: removed references to news_channels* 2009-06-07 20:09:18 -05:00
Overdues.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Print.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Reserves.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
SMS.pm Bug 2176 (3/5): adding methods to manage message_queue, new advance_notices.pl, new C4::SMS module 2008-06-20 13:04:52 -05:00
Scripts.pm bug 2087: test cases for misc/cronjobs/longoverdue.pl 2008-05-11 06:43:35 -05:00
Search.pm bug 3236: remove disused scripts and a function 2009-05-20 08:37:58 -05:00
Serials.pm removing disused C4::Serials functions 2009-06-09 09:31:12 -05:00
Suggestions.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00
Z3950.pm bug 2088: test suite refactoring to deal with t/override_context_prefs.pm 2008-05-11 06:48:40 -05:00