Koha-clms/svc
Kyle M Hall 6997276e51 Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven!
Due to a disconnect between how booleans are handled in Perl vs JSON,
all checkins done from the checkouts table will have fines forgiven!
This is because the parameters sent to svc/checkin are coded in JSON
and the JSON false is treated in Perl as the string 'false' which
evaluates to true!

Test Plan:
1) Find a patron with an overdue item that has a fine
2) Return the item via the checkouts table on circulation.pl or moremember.pl
3) Note the fine is forgiven
4) Apply this patch
5) Repeat steps 1-2
6) Note the fine is no longer forgiven

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Verified bug, fix corrects the problem.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Also tested waiving fines form the check-in page still works.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-11-25 15:25:14 -03:00
..
config Bug 9043: The comma (,) should be kept to separate multi-valuated prefs 2014-11-17 14:49:59 -03:00
members Bug 13232: Search patrons by a first letter should not redirect to a patron detail page 2014-11-14 09:33:00 -03:00
authentication Fix FSF address in directory svc/ 2010-03-16 20:17:51 -04:00
bib Bug 12590 - Support deletion of biblio in svc API 2014-10-27 11:13:49 -03:00
bib_profile Fix FSF address in directory svc/ 2010-03-16 20:17:51 -04:00
checkin Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! 2014-11-25 15:25:14 -03:00
checkouts Bug 13195 - Regression: Circulation checkouts table no longer shows item type description 2014-11-16 21:35:09 -03:00
cover_images Bug 7813: (follow-up) improvements for deleting local cover images 2013-09-21 18:11:13 +00:00
holds Bug 13099 - "Item hasn't been transferred yet" shows pickup branch rather than holding branch 2014-11-20 18:10:19 -03:00
import_bib Bug 9908 - Fixing OCLC Connexion Client 2013-03-29 21:29:10 -04:00
letters Bug 11742: A letter code should be unique. 2014-06-23 15:19:55 -03:00
new_bib Bug 7729 : svc/new_bib: support ?items=1 to add POSTed items to the new biblio too 2012-07-17 18:12:09 +02:00
renew Bug 11703: (qa followup) consistency in svc 2014-07-03 12:38:13 -03:00
report Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00