Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven Signed-off-by: Liz Rea <liz@catalyst.net.nz> Verified bug, fix corrects the problem. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Also tested waiving fines form the check-in page still works. Passes tests and QA script. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> |
||
|---|---|---|
| .. | ||
| config | ||
| members | ||
| authentication | ||
| bib | ||
| bib_profile | ||
| checkin | ||
| checkouts | ||
| cover_images | ||
| holds | ||
| import_bib | ||
| letters | ||
| new_bib | ||
| renew | ||
| report | ||