Koha-clms/acqui
Jonathan Druart deffb12491 Bug 10921: Prevent an order from a closed basket to be edited
We don't allow editing of orders that are part of a closed basket, but
we don't enforce the rule in the controller file.

This patch use output_and_exit to stop the script and display an error
to the end user.

Test plan:
Create a basket, add an order
On the basket view you see the "Modify" link, open it in a separate tab
=> You can edit the basket
Keep this tab open, get back to the other one and close the basket
Reload the tab with the order edition form
=> You cannot longer edit the basket

QA: Do we need a check in addorder.pl as well?

Signed-off-by: Henry Bolshaw <bolshawh@parliament.uk>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 0310e973a4)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2020-10-16 14:56:45 +00:00
..
acqui-home.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
add_user_search.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
addorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
addorderiso2709.pl Bug 26134: (bug 23463 follow-up) Fix add to basket from staged file 2020-08-31 20:05:57 +00:00
ajax-getauthvaluedropbox.pl Bug 22391: Remove group by clause in ajax-getauthvaluedropbox.pl 2019-02-21 16:48:28 +00:00
basket.pl Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-09-03 15:40:42 +00:00
basketgroup.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
basketheader.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
booksellers.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
cancelorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
check_budget_total.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
check_uniqueness.pl Bug 23463: Replace SearchItemsByField by SearchItems 2020-03-23 09:26:09 +00:00
duplicate_orders.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
edi_ean.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
edifactmsgs.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
edimsg.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
finishreceive.pl Bug 23596: Edit suggestion's reason when receiving 2020-04-14 16:30:16 +01:00
histsearch.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
invoice-files.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
invoice.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
invoices.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
lateorders-export.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
lateorders.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
modordernotes.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
neworderempty.pl Bug 10921: Prevent an order from a closed basket to be edited 2020-10-16 14:56:45 +00:00
newordersubscription.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
newordersuggestion.pl Bug 4833: (QA follow-up) Add budgetname to SearchSuggestion 2019-05-15 16:46:47 +00:00
ordered.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
orderreceive.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
parcel.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
parcels.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
showorder.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
spent.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
supplier.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
transferorder.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-08-25 11:53:44 -03:00
uncertainprice.pl Bug 24663: Remove authnotrequired if set to 0 2020-08-31 20:03:22 +00:00
updatesupplier.pl Bug 19993: use Modern::Perl in Acquisition perl scripts 2018-02-05 09:45:47 -03:00
z3950_search.pl Bug 21921: Add date publication year to biblio Z39.50 search form in acquisition 2020-02-17 13:44:34 +00:00