Koha-clms/C4
Nick Clemens a1f10a1900
Bug 39180: Catch exception when updating patron lastseen date
This patch adds a catch during circulatoin actions and passes a message back to the caller

For checkouts and renewals we don't have a method for passing messages so we simply catch the exception
and warn - this seems reasonable, as we have now added a warning on the patron display that they are missing
a guarantor

To test:
 1 - Create a Child type  patron with no guarantor
 2 - Create a patron in a non-child category that can_be_guarantee with no guarantor
 3 - Check out an item to each patron above
 4 - Enable system preference 'ChildNeedsGuarantor' and TrackLastPatronActivityTriggers - select all
 5 - In mysql
    UPDATE borrowers SET datelastseen = '2025-01-01';
 6 - Restart all to clear cache (so update last seen will update)
 7 - Attempt to checkout a book to either patron - 500 error
 8 - Attempt to returnt he books the patrons have checked out - 500 error
 9 - Attempt to renew their items - 500 error
10 - Apply patches, restart all
11 - Repeat checkout, renewal, checkin
12 - On checkout and renewal there should be a warning on the patron page, but actions succeed with no additional problems
13 - On return you get a warning letting you know the action succeeded but there is still a problem to resolve

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2025-09-17 17:01:21 +02:00
..
AuthoritiesMarc
…
Barcodes Bug 19113: Barcode value builder not working with numeric branchcode 2025-07-31 10:27:42 +02:00
ClassSortRoutine
…
ClassSplitRoutine Bug 40388: Remove warning from t/Labels.t 2025-08-01 14:29:57 +02:00
Creators Bug 37720: Prevent XSS in label creator 2024-10-18 12:07:51 +02:00
External
…
Form Bug 34776: Add unit tests for sub restore_form_values 2025-07-28 10:22:07 +02:00
Heading Bug 39415: (follow-up) Add 651g to bib heading fields as well 2025-05-26 20:17:03 +02:00
ILSDI Bug 31224: Update instances of metadata->record 2024-11-07 16:29:23 +01:00
Installer
…
Labels Bug 34157: Exporting labels as a barcode range can cause 500 error 2025-07-31 16:15:12 +02:00
Linker Bug 35125: Respect LinkerConsiderThesaurus in update_cache 2024-07-01 18:55:42 +02:00
Members Bug 29194: Create logical ordering of patron messaging preferences 2024-10-11 11:13:56 +02:00
OAI
…
Output
…
Patroncards Bug 39295: Prevent infinite loop on line wrapping 2025-06-19 11:06:57 +02:00
Reports Bug 37784: Do not show forbidden columns in reports dictionary 2025-03-24 17:59:09 +01:00
SIP Bug 29410: Resolve warn on numeric ne for two dates 2025-08-06 15:07:37 +00:00
Search
…
Serials
…
Utils/DataTables Bug 38482: Remove save state for the holdings tables 2024-11-20 14:02:01 +01:00
Accounts.pm
…
Acquisition.pm Bug 38343: Do not show closed invoices by default when receiving 2024-11-22 10:22:39 +01:00
Auth.pm Bug 38826: Make check_api_auth $sessionID consistent 2025-03-24 18:12:56 +01:00
Auth_cas_servers.yaml.sample
…
Auth_with_cas.pm Bug 34893: (QA follow-up) Tidy code for qa script 2024-02-02 17:31:47 +01:00
Auth_with_ldap.pm Bug 36822: LDAP - Add discard_changes 2024-11-07 16:29:15 +01:00
Auth_with_shibboleth.pm Bug 36822: Shibboleth - Add discard_changes 2024-11-07 16:29:14 +01:00
AuthoritiesMarc.pm Bug 40119: (QA follow-up) Small additional comment 2025-07-25 14:28:18 +02:00
Barcodes.pm Bug 37070: (QA follow-up) Fix qa script issues 2024-10-18 14:26:05 +02:00
Biblio.pm Bug 40403: Remove warning from Circulation_holdsqueue.t 2025-08-01 11:45:38 +02:00
Breeding.pm
…
Budgets.pm
…
Calendar.pm
…
Charset.pm
…
Circulation.pm Bug 39180: Catch exception when updating patron lastseen date 2025-09-17 17:01:21 +02:00
ClassSortRoutine.pm
…
ClassSource.pm Bug 23387: Add caching to C4::ClassSource 2024-08-26 17:39:31 +02:00
ClassSplitRoutine.pm
…
Context.pm Bug 36081: Use multivalue_preference 2025-02-24 20:43:20 +01:00
Contract.pm
…
CourseReserves.pm
…
Creators.pm
…
HTML5Media.pm
…
Heading.pm Bug 38483: C4::Heading::preferred_authorities is not used 2025-03-24 18:12:14 +01:00
HoldsQueue.pm Bug 28833: Speed up holds queue builder via parallel processing 2024-10-25 11:09:53 +02:00
ImportBatch.pm Bug 38279: Remove unused C4::ImportBatch::EmbedItemsInImportBiblio 2024-11-08 16:42:50 +01:00
ImportExportFramework.pm Bug 33339: Prevent Formula Injection (CSV Injection) in CSV files 2024-11-14 10:46:31 +01:00
InstallAuth.pm Bug 36367: Remove _new_userenv 2024-06-14 11:17:17 +01:00
Installer.pm Bug 38299: (follow-up) (discussion) Move failure into same level 2024-11-18 17:44:40 +01:00
ItemCirculationAlertPreference.pm
…
Items.pm Bug 14907: Sort item search by cn_sort when sorting by callnumber 2025-04-22 23:01:31 +02:00
Koha.pm Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() 2025-07-28 11:03:55 +02:00
Labels.pm
…
Languages.pm Bug 38646: (follow-up) Ensure consistent ordering of languages 2025-04-22 23:01:30 +02:00
Letters.pm Bug 36008: Use notice_email_address instead of email for SendAlerts issue type 2025-08-06 09:56:59 +00:00
Linker.pm
…
Log.pm Bug 37944: Log object delete as JSON diff, implement for items 2024-10-30 11:57:25 +01:00
MarcModificationTemplates.pm
…
Matcher.pm
…
Members.pm Bug 37845: Remove C4::Members::DeleteExpiredOpacRegistrations 2024-10-21 15:10:31 +02:00
Message.pm
…
Output.pm Bug 34478: Remove check_csrf from pl files 2024-03-01 10:56:01 +01:00
Overdues.pm Bug 39405: (follow-up) Add the parameter borrowernumber to the overwrite_calc_fine plugin hook 2025-04-25 11:27:58 +02:00
Patroncards.pm
…
Record.pm Bug 14670: (QA follow-up) Tidy new code 2024-11-14 10:46:38 +01:00
Reports.pm
…
Reserves.pm Bug 40034: Only check notforloan on itemtype if it exists 2025-07-09 14:58:38 +00:00
Ris.pm Bug 33431: Fix remaining cases 2024-03-18 11:03:39 +01:00
RotatingCollections.pm Bug 28294: Remove updateWrongTransfer 2024-11-07 18:49:36 +01:00
SMS.pm Bug 36051: (QA follow-up): Use yaml_preference 2024-04-12 11:26:12 +02:00
Scheduler.pm
…
Scrubber.pm Bug 40079: (follow-up) Improve test coverage and fix undef handling 2025-07-25 16:49:49 +02:00
Search.pm Bug 37004: Add branchcode as HTML class to each grouped result in search results 2024-09-02 12:13:42 +02:00
Serials.pm Bug 38829: Sanitize GetLateOrMissingIssues inputs 2025-02-18 19:17:17 +01:00
Service.pm
…
ShelfBrowser.pm
…
SocialData.pm
…
Stats.pm Bug 33608: (QA follow-up) Remove ->insert method 2023-10-25 11:07:59 -03:00
Suggestions.pm Bug 38235: Suggestion confirmation letter sent when it should not 2024-11-12 17:50:18 +01:00
TTParser.pm Bug 36171: Fix template toolkit tags split by HTML parser 2024-10-24 13:38:12 +02:00
Tags.pm Bug 36785: Typo unreconized and bilbio in tags code 2024-05-17 10:36:35 +02:00
Templates.pm Bug 38467: Make uri and url filters rfc3986 when using C4::Template 2025-02-18 19:17:18 +01:00
TmplToken.pm
…
TmplTokenType.pm
…
UsageStats.pm Bug 38104: Always update when hea cronjob is run 2025-04-22 23:02:27 +02:00
XISBN.pm
…
XSLT.pm Bug 38100: (QA follow-up) Tidy changes in C4/XSLT.pm 2024-11-08 11:23:50 +01:00