This patch moves the definition of translatable strings out of additem.js.inc and into additem.js using the new JS i81n function. additem.js.inc is removed, being obsolete. To test: When creating an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when placing an order." - Apply the patch and go to Acquisitions -> Vendor -> Add to basket -> From a new (empty) record. - In the "Item" section, confirm that the buttons at the bottom of the form are correct: "Add item," "Clear," and "Add multiple items." - Click "Add multiple items." The placeholder in the revealed form field should read "Number of items to add." The corresponding button should be labeled "Add." - You should see a note, "NOTE: Fields listed in the 'UniqueItemsFields' system preference will not be copied." - Fill out the item entry form and add a number to the "multiple items" field. Click "Add." - A table of items should be displayed with "Edit" and "Delete" buttons for each new item. - Click one of the "Edit" buttons. The item form should be populated with the item's data, with an "Update item" button at the bottom. When receiving an order: - Go to Administration -> System preferences and set "AcqCreateItem" to "when receiving an order." - Go to Acquisitions -> Vendor -> Receive shipments. - Select or create an invoice. - Click "Receive" on an order which has a quantity greater than 1. - Add two items, duplicating in each at least one value which is marked as unique by the "UniqueItemFields" system preference (e.g. fill in the same barcode number for each item). - Click "Save." You should get an alert about duplicated values, and there should be an alert message on the page, "barcode 'XXX' is duplicated." - Edit one of the two items and change the barcode to one which already exists in your database. - Click "Save." An alert message should be shown on the page, "barcode 'XXX' already exists in the database." - Note: I was unable to find out how to trigger this error, "You can't receive any more items." It may be obsolete. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/additem.js for translation, e.g.: msgid "Add multiple items" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| C4 | ||
| Koha | ||
| acqui | ||
| admin | ||
| api | ||
| authorities | ||
| basket | ||
| catalogue | ||
| cataloguing | ||
| circ | ||
| clubs | ||
| course_reserves | ||
| debian | ||
| docs | ||
| errors | ||
| etc | ||
| ill | ||
| installer | ||
| koha-tmpl | ||
| labels | ||
| members | ||
| misc | ||
| offline_circ | ||
| opac | ||
| patron_lists | ||
| patroncards | ||
| plugins | ||
| pos | ||
| reports | ||
| reserve | ||
| reviews | ||
| rotating_collections | ||
| serials | ||
| services | ||
| skel | ||
| suggestion | ||
| svc | ||
| t | ||
| tags | ||
| tmp/modified_authorities | ||
| tools | ||
| virtualshelves | ||
| xt | ||
| .editorconfig | ||
| .eslintrc.json | ||
| .gitignore | ||
| .htaccess | ||
| .mailmap | ||
| .perlcriticrc | ||
| .scss-lint.yml | ||
| INSTALL | ||
| Koha.pm | ||
| LICENSE | ||
| MANIFEST.SKIP | ||
| Makefile.PL | ||
| README | ||
| README.md | ||
| README.robots | ||
| about.pl | ||
| changelanguage.pl | ||
| cpanfile | ||
| fix-perl-path.PL | ||
| gulpfile.js | ||
| help.pl | ||
| koha_perl_deps.pl | ||
| kohaversion.pl | ||
| mainpage.pl | ||
| package.json | ||
| rewrite-config.PL | ||
| yarn.lock | ||
README.md
Koha is a free software integrated library system (ILS).
Koha is distributed under the GNU GPL version 3 or later.
Note: This is a synced mirror of the official Koha repo.
Note: Koha does not accept pull requests from git hosting sites.
Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.
For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch
The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook
