Koha-clms/acqui
Kyle M Hall 094515fb74 Bug 19812: Fix confusing holds count values in "Already received" table
In acqui/parcel.pl both the "Pending orders" and "Already received" tables show how many holds there are for the given record. However, the count of holds in the "Pending orders" table confuses librarians because it only lists holds for the particular items in the orderline. Due to that, the holds column may show 0 holds even if there are a dozen record level holds for that bib! This is not what librarians seem to expect, instead it seems that the same total holds in the "Pending orders" table would be preferred.

Test Plan:
1) Find an invoice with an item in the "Already received" table
2) Add one or more record level holds to the record
3) Note the holds column does not count those holds
4) Apply this patch
5) Note the holds column now shows total holds and holds for just those ordered items

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Nancy Keener <nkeener@washoecounty.us>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Bug 19812: (QA follow-up) Swap sides for total and item holds

Bug 19812: (QA follow-up) If 0 holds show '0' not '0 / 0'

Bug 19812: (QA follow-up) Remove unnecessary line

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-05-14 14:47:28 +00:00
..
pdfformat Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
acqui-home.pl Bug 17829: Move GetMember to Koha::Patron 2017-07-10 13:14:19 -03:00
add_user_search.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
addorder.pl Bug 15685: (QA follow-up) Fix qa script errors 2017-10-11 13:08:42 -03:00
addorderiso2709.pl Bug 19813: Make MarcItemFieldsToOrder handle non-existing tags 2018-01-15 14:24:29 +00:00
ajax-getauthvaluedropbox.pl Bug 17847: Replace C4::Koha::GetAuthvalueDropbox with Koha::AuthorisedValues 2017-03-31 10:12:37 +00:00
basket.pl Bug 19200: (QA follow-up) Simplify call to GetBasketAsCSV 2018-01-15 14:12:50 +00:00
basketgroup.pl Bug 19332 - Basket grouping PDF and CSV exports empty 2017-09-19 11:47:33 -03:00
basketheader.pl Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket 2017-10-11 13:06:06 -03:00
booksellers.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-08-25 11:53:44 -03:00
cancelorder.pl Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules 2017-10-09 14:00:58 -03:00
check_budget_total.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_duplicate_barcode_ajax.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
check_uniqueness.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
edi_ean.pl Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
edifactmsgs.pl Bug 17081 Incorrect comparison operator used in edifactmsgs.pl 2016-08-10 14:03:37 +00:00
edimsg.pl Bug 7736: Support Ordering via Edifact EDI messages 2016-04-01 20:03:17 +00:00
finishreceive.pl Bug 15685: (QA follow-up) Fix typo 2017-10-11 13:08:46 -03:00
histsearch.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
invoice-files.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
invoice.pl Bug 19839: Removed Warning (invoice.pl - uncertainprices) 2018-01-23 02:27:32 +00:00
invoices.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-08-25 11:53:44 -03:00
lateorders-export.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
lateorders.pl Bug 14535: Update the supplier filter too 2017-03-31 12:38:44 +00:00
modordernotes.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
neworderbiblio.pl Bug 17182: (QA follow-up) Fix call to GetMarcBiblio 2017-12-20 11:39:05 +00:00
neworderempty.pl Bug 15685: Allow creation of items (AcqCreateItem) to be customizable per-basket 2017-10-11 13:06:06 -03:00
newordersubscription.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
newordersuggestion.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
ordered.pl Bug 17771: Add link to bibliographic record on spent/ordered lists in acquisitions 2017-01-19 11:44:29 +00:00
orderreceive.pl Bug 20303: Do not explode when receiving an order if authorisedby not set 2018-03-23 10:43:31 +00:00
parcel.pl Bug 19812: Fix confusing holds count values in "Already received" table 2018-05-14 14:47:28 +00:00
parcels.pl Bug 18432: code comments assume male gender 2017-04-21 10:56:43 -04:00
spent.pl Bug 17771: aqorders.biblionumber was already part of the query 2017-01-19 12:00:16 +00:00
supplier.pl Bug 13726: Make Koha::Acq::Bookseller using Koha::Object 2016-12-30 11:54:32 +00:00
transferorder.pl Bug 19130: (followup) Controller scripts should preserve behaviour 2017-08-25 11:53:44 -03:00
uncertainprice.pl Bug 19695: Fix another instance of ->find in list context (uncertainprice.pl) 2017-11-27 14:24:04 -03:00
updatesupplier.pl Bug 18716: Remove CGI::param warns from updatesupplier.pl 2017-06-09 11:57:00 -03:00
z3950_search.pl Bug 19916: Add keyword and standard ID fields to acq external search 2018-05-14 13:35:41 +00:00