gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
21,590 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
David Cook 99e25ff30d Bug 12522 - Fatal database error when viewing Holds for Bib with no Items 
This patch fixes some potential SQL syntax errors, which can cause
fatal software errors in Koha when the environmental variable DEBUG
is on.

_TEST PLAN_

Before applying:

0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config
1) Create a new bib record
2) Click on the "Holds" tab before creating any items
3) Note the message "Cannot place hold: this record has no
items attached."

4) Add "SetEnv DEBUG 1" to your Apache config
5) Restart Apache
6) Refresh your page
7) Note the following Software Error: "DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that
corresponds to your MariaDB server version for the right syntax to
use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835.

8) Apply the patch

9) Refresh your page
10) Note the message from Step 3

Thorough tester:

11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache,
and refresh your page. You should see the message from Step 3.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Error reproduced, patch fixes it.
Tested following test plan, no koha-qa errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
 		2014-07-14 08:47:56 -03:00
C4 Bug 12522 - Fatal database error when viewing Holds for Bib with no Items 2014-07-14 08:47:56 -03:00
Koha Bug 12558: (follow-up) remove old versions of schema classes for two tables 2014-07-11 16:26:48 -03:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Bug 11715: require authentication for various staff scripts 2014-06-25 12:27:08 -03:00
admin Bug 12508: adding an error message if a contract cannot be removed 2014-07-10 10:44:06 -03:00
authorities Bug 10862: Add search history to the intranet interface 2014-05-05 03:06:33 +00:00
basket Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
catalogue Bug 12237: Remove the "horrible hack" in C4::Templates 2014-07-03 10:34:11 -03:00
cataloguing Bug 11638: Remove HTML from addbiblio.pl 2014-07-03 15:01:10 -03:00
circ Bug 12495 - Include streetnumber in hold alert address 2014-07-07 10:56:06 -03:00
course_reserves Bug 11866: (follow-up) repair security issue introduced by main patch 2014-03-10 14:57:17 +00:00
debian Revert "Bug 8567: Set output directory for fines.pl in cron config created by the packages" 2014-07-04 15:08:23 -03:00
docs Bug 7143: Updating new developers 2014-06-30 10:01:52 -03:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 9612: (follow-up) restore elementSetName in Context.pm 2014-05-19 16:46:57 +00:00
install_misc Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
installer Bug 11030 - Add 359, 947 and 969 fields in french unimarc_complete framework - followup 2014-07-07 13:10:27 -03:00
koha-tmpl Bug 12307: Catalog details page displaying incorrect status for items with itemtype level notforloan status 2014-07-11 16:26:11 -03:00
labels Bug 8375: Use TrueType fonts in PDF::Reuse 2014-05-05 21:53:18 +00:00
members Bug 12332: Fix for tab "Purchase suggestions" not lighting up 2014-07-08 10:43:46 -03:00
misc Bug 12396 - MTT FIX: Due notices (DUEDGST) are multiplicated and all of them are sent to everybody who is about to receive ODUEDGST. 2014-06-15 11:14:45 -03:00
offline_circ Bug 10240: (follow-up) don't display patrons as lost or gone-no-address incorrectly 2013-10-11 01:57:05 +00:00
opac Bug 12062: Follow up to fix more untraslatable cases 2014-07-07 10:32:08 -03:00
patron_lists Bug 10565: (follow-up) add new user permission for patron list management 2013-10-14 22:43:03 +00:00
patroncards Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
plugins Bug 7804 - Add Koha Plugin System - QA Followup 2 2013-03-20 14:50:19 -04:00
reports Bug 12151: Remove uses of smartmatch operator in report scripts 2014-07-07 10:16:45 -03:00
reserve Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl 2014-06-18 15:40:47 -03:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 9605: rotating collections permissions are wrong 2013-03-30 22:11:05 -04:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 11715: require authentication for various staff scripts 2014-06-25 12:27:08 -03:00
services Bug 11715: require authentication for various staff scripts 2014-06-25 12:27:08 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 10611: Use mysql_auto_reconnect instead of ping 2014-03-10 23:15:35 +00:00
suggestion Bug 4068: (follow-up) use URI::Escape 2014-05-08 16:36:10 +00:00
svc Bug 11703: (qa followup) consistency in svc 2014-07-03 12:38:13 -03:00
t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-11 16:16:11 -03:00
tags Bug 10730: Use DataTables on the tag review page 2013-09-25 16:47:59 +00:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl 2014-07-07 10:16:54 -03:00
virtualshelves Bug 12065: use encode_qp consistently when sending basket/shelf 2014-05-09 15:14:40 +00:00
xt Bug 12041 - POD fixing followup 2014-06-19 13:05:15 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap Bug 12479: (QA followup) minor fixes, and tcohen added 2014-06-30 10:04:10 -03:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.opensuse Bug 11757: remove dependency on POE 2014-02-15 01:38:15 +00:00
INSTALL.ubuntu Bug 7764: (follow-up) editorial tweaks 2013-10-04 16:27:55 +00:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 11596: report warnings on the about patch if indexing options in koha-conf.xml are missing 2014-04-20 17:07:04 +00:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 11661: sanitize file names supplied to edithelp.pl 2014-02-05 01:36:10 +00:00
fix-perl-path.PL installer: improvements to fix-path-perl.PL on Win32 2007-12-20 19:20:12 -06:00
help.pl Bug 11238: contruct links to the appropriate manual version dynamically 2013-11-23 19:30:16 +00:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl bug 10548: fix count of missing required dependencies by koha_perl_deps.pl 2013-07-11 14:03:32 +00:00
kohaversion.pl Bug 11703: DBRev 3.17.00.009 2014-07-03 12:38:13 -03:00
mainpage.pl Bug 7567 - Use, display, filter News by library 2014-04-07 18:14:19 +00:00
rewrite-config.PL Bug 10729: Add phrases configuration for ICU 2014-05-05 04:10:57 +00:00

README 

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 3 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/