Go to file
Owen Leonard 98a269669c
Bug 34082: Cut some redundancy in OPAC JavaScript string translations
This patch consolidates some JS code so that we're not defining a string
ine one place and using it once elsewhere. With JS-friendly translations
tools we don't need this workaround.

To test, apply the patch and go to Administration -> Circulation and
fine rules.

- Configure an item type rule with the "OPAC item level holds" setting
  set to "Force."
- Log in to the OPAC and locate a record with that item type and
  multiple items. An example in the sample data:
  /cgi-bin/koha/opac-detail.pl?biblionumber=12
- Place a hold on the item.
  - The holds screen should show a table of items.
  - Open your browser's developer tools.
  - In the Console tab, paste in this code and hit ENTER:

    $(".checkitem").prop("checked", false);

  - All radio buttons in the table of items should be cleared.
- Click the "Confirm hold" button. You should get an alert:
  "Expecting a specific item selection."

- Log in to the OPAC and click the "Search history" tab from the user
  summary page.
- Check one or more checkboxes next to search history items and click
  the "Remove selected searches."
  - You should get an alert: "Are you sure you want to delete selected
    search history entries?"

- Log in to the OPAC, create a new list if necessary, and add some
  titles to the list.
- Test that confirmation messages show correctly:
  - Deleting a single title by clicking the "Remove
    from this list" link.
  - Deleting multiple titles by checking boxes and
    clicking "Remove from list."
  - Deleting a list.

- In Administration -> System preferences, enable TagsEnabled if
  necessary.
- Log in to the OPAC and tag one or more items.
- From the Tag cloud page, check one or more boxes for your tags, and
  click the "Delete selected tags" button at the bottom of the page.
- The confirmation message should display correctly.

- To test the change to opac-account.tt you have to install a payment
  plugin, e.g.
  https://gitlab.com/thekesolutions/plugins/koha-plugin-pay-via-paypal,
  and attempt to submit a payment which is below the minimum payment
  threshold set in the plugin's configuration.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
2024-04-29 09:35:39 +02:00
C4 Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
Koha Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
acqui Bug 35363: Update transfer order pop-up window with consistent footer markup 2024-04-22 08:57:39 +02:00
admin Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
api Bug 36565: EDI files API docs fixes (bug 30070 follow-up) 2024-04-29 09:35:36 +02:00
authorities Bug 36552: (QA follow-up) Add a theoretical check on $record 2024-04-12 14:02:44 +02:00
basket Bug 34478: Add 'op' to sendbasketform 2024-03-01 10:58:53 +01:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
bookings Bug 35574: Bookings tab from biblio details should only require manage_bookings permission 2023-12-18 15:21:04 +01:00
catalogue Bug 35558: Do not retrieve the local image if none exists 2024-04-26 18:06:07 +02:00
cataloguing Bug 31791: Limit editing locked records 2024-04-26 20:15:37 +02:00
circ Bug 33478: Apply formatting to AR_SLIP 2024-04-26 20:15:46 +02:00
clubs Bug 34478: Manual fix - add op clubs/templates-add-modify 2024-03-01 10:57:55 +01:00
course_reserves Bug 34478: Manual fix - Course reserves 2024-03-01 10:56:56 +01:00
debian Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
docs Bug 35504: Split list of ERM Topic experts 2024-01-11 15:44:51 +01:00
erm Bug 32922: Remove space in shebang 2023-02-20 09:44:06 -03:00
errors Bug 36148: Improve error handling and restore programming errors 2024-03-01 11:01:06 +01:00
etc Bug 30897: (QA follow-up) Enable graceful restart by default 2024-04-11 16:53:43 +02:00
ill Bug 36416: Fix cud-check_out 2024-04-26 08:52:49 +02:00
installer Bug 33478: DBRev 23.12.00.032 2024-04-26 20:15:48 +02:00
koha-tmpl Bug 34082: Cut some redundancy in OPAC JavaScript string translations 2024-04-29 09:35:39 +02:00
labels Bug 36511: Some scripts missing a dependency following Bug 24879 2024-04-10 09:09:50 +02:00
lib/CGI/Session/Serialize Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
members Bug 33478: Apply formatting to ACCOUNTS_SUMMARY 2024-04-26 20:15:45 +02:00
misc Bug 35996: Make it clear that --category-code can not be used alone 2024-04-29 09:35:37 +02:00
offline_circ Bug 34478: Changes for offline_circ 2024-03-01 10:58:34 +01:00
opac Bug 35558: Do not retrieve the local image if none exists - OPAC 2024-04-26 18:06:08 +02:00
patron_lists Bug 34478: Changes for patron_lists/add-modify 2024-03-01 10:57:41 +01:00
patroncards Bug 34478: (follow-up) patroncards: FIXMEs for op and missing script 2024-03-01 11:00:00 +01:00
plugins Bug 30897: Add option to disable automated restart 2024-04-11 16:53:42 +02:00
pos Bug 33478: Apply formatting to RECEIPT 2024-04-26 20:15:44 +02:00
preservation Bug 34030: Add a "print slips" action links to print in batch 2023-10-23 11:33:55 -03:00
recalls Bug 33478: Apply formatting to RECALL_REQUESTER_DET 2024-04-26 20:15:45 +02:00
reports Bug 35746: add multiselect to report dropdowns 2024-04-26 18:06:19 +02:00
reserve Bug 35979: Check pref before inserting holds_queue background jobs 2024-04-26 08:52:54 +02:00
reviews Bug 34478: op =~ ^cud- in pl/pm 2024-03-01 10:56:11 +01:00
rotating_collections Bug 34478: Manual fix - add op - rotating_collections/addItems 2024-03-01 10:57:33 +01:00
serials Bug 31335: Remove unnecessary holds fetch from routing-preview 2024-04-26 18:06:20 +02:00
services Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
skel
…
suggestion Bug 34963: Restore the ability to blank fields when editing a suggestion 2024-04-19 18:06:36 +02:00
svc Bug 36418: Catch more cases where header response should be application/json 2024-04-02 17:59:04 +02:00
t Bug 34032: (QA follow-up) Tidy code 2024-04-29 09:35:38 +02:00
tags Bug 34478: Add 'op' to tags/review 2024-03-01 10:58:25 +01:00
tools Bug 33478: Consider TranslateNotices when saving notice styles 2024-04-26 20:15:47 +02:00
virtualshelves Bug 34478: Correct op name for list edit confirmation 2024-03-01 11:00:09 +01:00
xt Bug 36565: Unit tests 2024-04-29 09:35:34 +02:00
.editorconfig Bug 27375: Set YAML file settings in .editorconfig 2021-11-03 15:40:52 +01:00
.eslintrc.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
.gitignore Bug 35174: Add misc/translator/po to .gitignore 2023-11-16 08:56:36 +01:00
.htaccess
…
.mailmap 23.11.00: Update mailmap 2023-11-30 14:58:47 -03:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.perltidyrc Bug 30002: Adjust perltidy 2023-06-08 08:32:42 -03:00
.prettierrc.js Bug 36400: (follow-up) remove option editorconfig from .prettierrc.js 2024-04-22 08:57:40 +02:00
.proverc.dist Bug 19821: Install sample data, ES mappings and Version syspref 2021-10-25 11:27:40 +02:00
.stylelintrc.json Bug 31528: (follow-up) A few additional rules 2022-10-03 08:23:15 -03:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Bug 33478: DBRev 23.12.00.032 2024-04-26 20:15:48 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 36400: (RM follow-up) Add .prettierrc to Makefile 2024-04-24 10:13:13 +01:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 32693: About script: Process only the tab being queried 2024-04-22 12:39:24 +02:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
build-resources.PL Bug 32609: Use the current yarn.lock to generate node_modules 2023-02-10 11:07:57 -03:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 35826: optimize on transport cost when building holds queue 2024-04-26 18:06:16 +02:00
cypress.config.ts Bug 36012: Extend cypress's requestTimeout value 2024-03-22 15:07:36 +01:00
fix-perl-path.PL Bug 28606: Remove $DEBUG and $ENV{DEBUG} 2021-06-24 11:53:44 +02:00
gulpfile.js Bug 35428: Remove temporary files for gulp po tasks 2023-12-12 15:04:54 +01:00
help.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 34478: Remove generate_csrf from pl 2024-03-01 10:55:56 +01:00
package.json Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00
rewrite-config.PL Bug 28519: Put CGI::Session::Serialize::yamlxs in lib directory 2021-06-17 10:07:36 +02:00
tsconfig.json Bug 32030: Move cypress to t - fix build_js/watch_js 2022-11-08 09:44:52 -03:00
webpack.config.js Bug 35919: Add record sources admin page 2024-04-26 17:06:04 +02:00
yarn.lock Bug 36400: Centralize {js,ts,vue} formatting config in .prettierrc.js 2024-04-22 08:57:39 +02:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo