Koha-clms/admin
Emmi Takkinen 91fc31c32b
Bug 30694: Set decreaseloanholds undef when deleting circulation rule
When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds" filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
2022-12-23 14:01:43 -03:00
..
searchengine/elasticsearch Bug 15048: Index all possible searched subfields for index-term-genre 2022-10-24 14:39:38 -03:00
additional-fields.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
admin-home.pl Bug 31401: Update administration sidebar to match entries on administration start page 2022-09-07 13:55:32 -07:00
adveditorshortcuts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqbudgetperiods.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
aqbudgets.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
aqcontract.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
aqplan.pl Bug 28327: Unify CSV delimiter special behavior for tabulation 2022-08-19 15:53:12 -03:00
audio_alerts.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
auth_subfields_structure.pl Bug 30489: Convert MARC and authority subfield edit tabs to Bootstrap 2022-05-02 11:22:57 -10:00
auth_tag_structure.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
authorised_values.pl Bug 31976: Incorrect default category selected by authorized values page 2022-10-27 09:46:58 -03:00
authtypes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
background_jobs.pl Bug 30982: Use the REST API for background job list view 2022-09-23 08:57:47 -03:00
biblio_framework.pl Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls 2022-10-25 11:16:57 -03:00
branch_transfer_limits.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
branches.pl Bug 31785: (follow-up) Fix modify operation too 2022-10-14 15:47:57 -03:00
cash_registers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
categories.pl Bug 30718: Use flatpickr's altInput 2022-08-19 08:26:31 -03:00
check_budget_parent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_parent_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
checkmarc.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
cities.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
classsources.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
clone-rules.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
columns_settings.pl Bug 29723: (QA follow-up) Correct scroll to table 2022-08-16 10:12:27 -03:00
columns_settings.yml Bug 32030: Add table settings to the yml file 2022-11-08 09:44:35 -03:00
credit_types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
curbside_pickup.pl Bug 30650: Allow to restrict curbside pickup for waiting holds only 2022-07-29 15:00:31 -03:00
currency.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
debit_types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
desks.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
didyoumean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edi_accounts.pl Bug 30130: Use new standard field in account definition 2022-04-13 15:55:39 +02:00
edi_ean_accounts.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
identity_providers.pl Bug 32139: Set "update on login" correctly when creating new IdP 2022-11-09 13:32:46 -03:00
import_export_authtype.pl Bug 13952: (follow-up) JS translatability, clean warns, other 2022-04-04 16:23:46 +02:00
import_export_framework.pl Bug 13952: (follow-up) Fixing export on default biblio framework 2022-04-04 16:23:45 +02:00
item_circulation_alerts.pl Bug 32122: Correct permissions check on item circulation alerts 2022-11-07 11:17:40 -03:00
items_search_field.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
items_search_fields.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
itemtypes.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
koha2marclinks.pl Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls 2022-10-25 11:16:57 -03:00
library_groups.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
localization.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
marc-overlay-rules.pl Bug 14957: Fix perlcritic error on admin/marc-overlay-rules.pl 2021-10-27 09:16:42 +02:00
marc_subfields_structure.pl Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls 2022-10-25 11:16:57 -03:00
marctagstructure.pl Bug 31196: Remove 'default_value_for_mod_marc-' clear_from_cache calls 2022-10-25 11:16:57 -03:00
matching-rules.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
oai_set_mappings.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
oai_sets.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
overdrive.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
patron-attr-types.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
preferences.pl Bug 29695: Make "modalselect" syspref's values translatable 2022-04-12 11:40:16 +02:00
restrictions.pl Bug 31597: Add missing semicolon to restriction.pl 2022-09-22 08:11:16 -03:00
search_filters.pl Bug 17170: Minor fixes 2022-10-21 11:15:21 -03:00
share_content.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
smart-rules.pl Bug 30694: Set decreaseloanholds undef when deleting circulation rule 2022-12-23 14:01:43 -03:00
sms_providers.pl Bug 29859: Use iterator instead of as_list 2022-02-09 15:36:23 -10:00
smtp_servers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
sru_modmapping.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
systempreferences.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transfer_limits.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transport-cost-matrix.pl Bug 29844: Fix ->search occurrences 2022-02-09 15:36:23 -10:00
usage_statistics.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
z3950servers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00