Koha-clms/acqui
Joonas Kylmälä ae84b13e48 Bug 14999: Make sure order prices are not mixed-up
We were shifting the price and replacement price for imported orders
only after the line:

> $duplinbatch = $import_batch_id and next if $duplifound;

This lead to the "replacementprice" and "price" query parameters not
being shifted/removed from the list if a duplicate record came across
and caused the prices be applied to the next record being imported.

To reproduce:
 1) Download two records from koha to marcxml file, then cat those:
   cat bib1.marcxml bib2.marcxml > bibs.marcxml
 2) Delete bib2 from koha
 3) Stage bibs.marcxml for import
 4) Create a new order basket, then "Add to basket" using "From a
    staged file" option
 5) Select both bib1 and bib2 and set price & replacement price for
    bib1 to be 99.00 and for bib2 to be 88.00
 6) Click save and notice bib2 was imported with the wrong prices, 99.00!
 7) Apply patch and notice the prices are now correctly set to 88.00.

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2021-11-02 14:57:06 +01:00
..
acqui-home.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
add_user_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
addorder.pl Bug 29111: Remove unused indicator modification code for items 2021-10-15 11:34:26 +02:00
addorderiso2709.pl Bug 14999: Make sure order prices are not mixed-up 2021-11-02 14:57:06 +01:00
ajax-getauthvaluedropbox.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basket.pl Bug 28640: Expose EDI Status on basket details page 2021-07-26 12:46:32 +02:00
basketgroup.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
basketheader.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
booksellers.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
cancelorder.pl Bug 24190: (follow-up) Rename AcqLog 2021-09-21 20:22:57 +02:00
check_budget_total.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
check_uniqueness.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
duplicate_orders.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edi_ean.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edifactmsgs.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
edimsg.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
finishreceive.pl Bug 29111: Remove unused indicator modification code for items 2021-10-15 11:34:26 +02:00
histsearch.pl Bug 27287: Make note fields from orders history searchable 2021-10-21 12:24:04 +02:00
invoice-files.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
invoice.pl Bug 24190: (QA follow-up) record unchanged bookfund and fix typo 2021-09-21 20:22:57 +02:00
invoices.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
lateorders-export.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
lateorders.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
modordernotes.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
neworderempty.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersubscription.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
newordersuggestion.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
ordered.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
orderreceive.pl Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page 2021-08-27 10:37:18 +02:00
parcel.pl Bug 17600: Fix tests 2021-07-16 09:47:01 +02:00
parcels.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
showorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
spent.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
supplier.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
transferorder.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
uncertainprice.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
updatesupplier.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00
z3950_search.pl Bug 17600: Standardize our EXPORT_OK 2021-07-16 08:58:47 +02:00