Koha-clms/acqui
Joonas Kylmälä 58a69fb129 Bug 14999: Make sure order prices are not mixed-up
We were shifting the price and replacement price for imported orders
only after the line:

> $duplinbatch = $import_batch_id and next if $duplifound;

This lead to the "replacementprice" and "price" query parameters not
being shifted/removed from the list if a duplicate record came across
and caused the prices be applied to the next record being imported.

To reproduce:
 1) Download two records from koha to marcxml file, then cat those:
   cat bib1.marcxml bib2.marcxml > bibs.marcxml
 2) Delete bib2 from koha
 3) Stage bibs.marcxml for import
 4) Create a new order basket, then "Add to basket" using "From a
    staged file" option
 5) Select both bib1 and bib2 and set price & replacement price for
    bib1 to be 99.00 and for bib2 to be 88.00
 6) Click save and notice bib2 was imported with the wrong prices, 99.00!
 7) Apply patch and notice the prices are now correctly set to 88.00.

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
2021-11-05 08:33:58 -04:00
..
acqui-home.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
add_user_search.pl Bug 23271: Replace search_limited with search_with_library_limits 2021-04-21 15:25:07 +02:00
addorder.pl Bug 23971: Rename pref with AcquisitionLog 2021-04-23 11:58:49 +02:00
addorderiso2709.pl Bug 14999: Make sure order prices are not mixed-up 2021-11-05 08:33:58 -04:00
ajax-getauthvaluedropbox.pl Bug 23830: Adapt callers 2021-02-08 17:09:34 +01:00
basket.pl Bug 23971: (follow-up) Remove data duplication 2021-04-23 11:58:49 +02:00
basketgroup.pl Bug 23971: (follow-up) Remove stale param 2021-04-23 11:58:49 +02:00
basketheader.pl Bug 23971: (follow-up) Remove data duplication 2021-04-23 11:58:49 +02:00
booksellers.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
cancelorder.pl Bug 26577: Make basket.pl and cancelorder.pl use ->cancel 2020-10-15 14:50:07 +02:00
check_budget_total.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
check_uniqueness.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
duplicate_orders.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
edi_ean.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
edifactmsgs.pl Bug 23682: Fix use Koha::Plugins::Handler statements 2020-09-03 15:00:48 +02:00
edimsg.pl Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
finishreceive.pl Bug 29175: finishreceive: Replace , by ; 2021-10-08 11:05:53 -04:00
histsearch.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
invoice-files.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
invoice.pl Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) 2021-04-08 15:37:43 +02:00
invoices.pl Bug 22773: Bulk Close invoices and Filter invoice view (open/closed) 2021-04-08 15:37:43 +02:00
lateorders-export.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
lateorders.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
modordernotes.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
neworderempty.pl Bug 27828: (bug 24469 follow-up) Add missing import 2021-03-03 11:57:51 +01:00
newordersubscription.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
newordersuggestion.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ordered.pl Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted 2021-02-23 13:07:49 +01:00
orderreceive.pl Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page 2021-09-03 09:55:04 -04:00
parcel.pl Bug 20212: Use the DT column filtering provided by the wrapper 2021-01-28 16:44:40 +01:00
parcels.pl Bug 27485: Rename system preference gist to TaxRates 2021-01-22 14:09:46 +01:00
showorder.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
spent.pl Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted 2021-02-23 13:07:49 +01:00
supplier.pl Bug 27485: Rename system preference gist to TaxRates 2021-01-22 14:09:46 +01:00
transferorder.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
uncertainprice.pl Bug 27082: uncertainprice.pl does not handle pagination 2020-11-25 14:38:14 +01:00
updatesupplier.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
z3950_search.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00