Koha-clms/t/db_dependent
Marcel de Rooy 0c138700b2 Bug 14893: Separate temporary storage per instance in Upload.pm
To make life easier when multiple instances are uploading temporary
files to Koha, this patch adds the database name to the upload subfolder
in your /tmp folder.

Note: Although multiple instances could share the same subfolder for
temporary storage (hashvalue is based on a timestamp too), it will be
better to separate them for efficient housekeeping (removing older or
partial files with a cronjob etc.)
Since multiple instances come with separate permissions, keeping them in
separate folders will be much simpler.

Permanent storage is not affected by this patch. The location of permanent
storage is ruled by the upload_path in each config file. Sharing that
space is not recommended too.

Although it may not be strictly necessary yet to remove files from the old
temp storage folder (before the 3.22 release), the accompanying db rev
performs that housekeeping task.

Test plan:
[1] Do not yet apply this patch. Upload a temporary file (use the
    tools/upload.pl script without selecting a category).
[2] Check /tmp/koha_upload.
[3] Apply this patch. Run the db rev with web installer.
[4] Upload another temporary file.
[5] Check /tmp for folder [your_database]_upload.
[6] Check that /tmp/koha_upload is gone and the associated records too.
[7] Run the adjusted t/db../Upload.t

Followed test plan. Could not do steps before applying patch [1]-[2]
(I suppose a local permission problem).
After applying patch and updating db file appears in /tmp/[database]
as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
2016-01-29 01:17:55 +00:00
..
Acquisition Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Biblio Bug 15572: Add tests for TransformHtmlToMarc 2016-01-25 07:09:50 -07:00
Circulation Bug 14945: Add 2 more tests for StoreLastBorrower 2015-12-31 19:32:20 +00:00
Creators Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Exporter Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Holds Bug 14878: (QA followup) Remove useless diag 2015-11-06 15:51:52 -03:00
Items Bug 14870: (followup) Remove stray C4::Dates 2015-11-19 13:05:06 -03:00
Koha Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
LDAP
…
Labels Bug 14468: (QA followup) remove useless diags 2015-10-27 10:38:15 -03:00
Letters Bug 13215: Fix GetLetterTemplates should return default templates if branchcode is not defined 2014-11-27 11:42:26 -03:00
Members Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
OAI Bug 14939: Remove the Capture::Tiny dependency 2015-12-31 15:15:35 +00:00
Record Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
Reports Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Reserves Bug 13592: Add an option to charge for any hold placed 2015-12-31 15:59:05 +00:00
Search Bug 10933: (followup of the followup) fix the previous patch to work with master 2015-10-27 13:06:01 -03:00
Serials Bug 15168: (followup) remove useless diags 2015-11-17 15:47:46 -03:00
Template/Plugin Bug 7380: Add tests for TT plugins 2015-05-19 10:10:31 -03:00
Utils Bug 15252 - Add tests 2015-12-30 13:05:54 +00:00
XSLT_Handler Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00
api/v1 Bug 13799: Rename t/.../v1/borrowers.t to t/.../v1/patrons.t 2015-11-04 13:47:33 -03:00
data
…
www Bug 10363: (QA followups) Fix tests 2015-10-21 17:23:38 -03:00
00-strict.t
…
Accounts.t Bug 14402: (QA followup) Add notes to usage text about --fees 2015-11-09 15:00:02 -03:00
Acquisition.t Bug 13967: (QA followup) Make DBIx control transactions on tests 2015-06-04 15:12:45 -03:00
AdditionalField.t Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
Amazon.t
…
AudioAlerts.t Bug 11431: (QA followup) remove diags 2015-11-06 15:08:37 -03:00
Auth.t Bug 14439: Add test - template path should finish by .tt 2015-06-24 10:53:25 -03:00
Auth_with_cas.t Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t 2015-07-20 10:32:21 -03:00
Auth_with_ldap.t Bug 12831: (RM followup) regression test 2014-11-27 14:45:11 -03:00
AuthorisedValues.t Bug 10363: Use Koha::AuthorisedValue[s] in the admin page 2015-10-19 12:46:27 -03:00
AuthoritiesMarc.t Bug 10985: [UNIMARC] Fix authority summary 2015-04-22 11:54:36 -03:00
BackgroundJob.t Bug 13606: Add tests and fix existing ones 2015-04-23 13:18:49 -03:00
Barcodes.t Bug 13673: (QA followup) Add license 2015-05-15 16:00:28 -03:00
Barcodes_ValueBuilder.t Bug 15081: (QA followup) Fix issue with Barcodes_ValueBuilder.t 2015-11-04 12:32:57 -03:00
Biblio.t Bug 7683: Cataloguing statistics wizard improvements 2016-01-27 06:37:27 +00:00
BiblioObject.t Bug 15586 - References to Koha::Branches remain in unit tests 2016-01-19 12:32:39 +00:00
Bookseller.t Bug 14334: t/db_dependent/Bookseller.t AutoCommit fix 2015-06-07 18:51:21 -03:00
Borrower.t Bug 14778: Make 3 tests pass 2015-10-23 12:01:17 -03:00
Borrower_Debarments.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrower_Discharge.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrower_Files.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Borrowers.t Bug 13967: Add a couple of tests for SysPref and Object 2015-06-04 10:39:16 -03:00
Branch.t Bug 15628: Remove get_branchinfos_of vestiges 2016-01-27 05:31:01 +00:00
Breeding.t Bug 12898: (regression test) test terms inside double quotes 2014-09-14 02:02:51 -03:00
Budgets.t Bug 15004: Ensure that the reset_all_budgets behavior is kept 2016-01-27 06:05:02 +00:00
Category.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Charset.t Bug 8218 : Add a maintenance script to sanitize biblio records 2014-11-11 15:38:36 -03:00
Circulation.t Bug 14101: Unit tests 2015-11-20 10:13:48 -03:00
Circulation_Branch.t Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty 2015-10-13 11:13:24 -03:00
Circulation_Issuingrule.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
Circulation_OfflineOperation.t
…
Circulation_dateexpiry.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
Circulation_issue.t Bug 14640: Add tests 2015-09-16 11:00:17 -03:00
Circulation_issuingrules.t Bug 14778: Use mock_dbh where it should be used 2015-10-23 12:01:18 -03:00
Circulation_transfers.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
ClassSource.t
…
ColumnsSettings.t Bug 10212: Columns configuration for tables - Unit tests 2014-08-26 09:28:18 -03:00
Context.t Bug 14778: Use mock_dbh where it should be used 2015-10-23 12:01:18 -03:00
Contract.t Bug 14693: Contract.t should generate dates based on current date 2015-08-21 10:43:38 -03:00
CourseReserves.t Bug 15530 - Add Unit Test 2016-01-27 00:58:14 +00:00
Csv.t
…
External_BakerTaylor.t
…
Fines.t Bug 13590: Add ability to charge fines at start of charge period 2015-10-22 14:51:24 -03:00
FrameworkPlugin.t Bug 10480: New module and unit test for framework plugins 2015-04-16 14:48:35 -03:00
Heading_MARC21.t
…
Hold.t Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
Holds.t Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
HoldsQueue.t Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used 2016-01-27 20:46:58 +00:00
Holidays.t Bug 15081: (followup) Make test files using TestBuilder handle their transactions 2015-11-04 12:32:57 -03:00
ILSDI_Services.t Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
ImportBatch.t Bug 6520: Add unit test for C4::ImportBatch::GetRecordFromImportBiblio 2015-04-16 13:40:59 -03:00
Installer.t
…
Items.t Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
Items_DelItem.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc 2016-01-13 19:27:22 +00:00
Koha_Authority.t Bug 15578: Insert authority records before processing tests 2016-01-23 18:28:49 +00:00
Koha_Database.t Bug 13645: Cache the DBIx connection 2015-02-20 14:37:08 -03:00
Koha_Misc_Files.t
…
Koha_borrower_modifications.t Bug 12623: SQLHelper replacement - Borrower::Modifications 2014-08-11 11:42:58 -03:00
Koha_template_plugin_Branches.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Koha_template_plugin_KohaDates.t Bug 14977: Remove C4::Dates from files t/db_dependent/*.t 2015-10-29 11:58:44 -03:00
Languages.t Bug 14030 - Added tests for duplicates. 2015-04-24 09:55:54 -03:00
Letters.t Bug 15432: t/db_dependent/Letters.t depends on external data/configuration 2015-12-30 16:34:24 +00:00
Linker_FirstMatch.t
…
Log.t Bug 14977: Remove C4::Dates from files t/db_dependent/*.t 2015-10-29 11:58:44 -03:00
MarcModificationTemplates.t Bug 11413: Fix field_numbers 2014-11-14 12:05:47 -03:00
Members.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Members_Attributes.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Members_columns.t
…
MungeMarcPrice.t
…
NewsChannels.t Bug 14977: Followup to fix issue with NewsChannels.t 2015-10-29 11:58:52 -03:00
Overdues.t Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types 2015-12-31 12:47:16 +00:00
Passwordrecovery.t Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t 2016-01-27 06:40:54 +00:00
PatronLists.t
…
Plugins.t Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
QueryParser.t
…
Ratings.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Record.t Bug 13642 - Add Unit test for C4::Record::marc2dcxml 2016-01-27 06:23:08 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Reports.t
…
ReportsGuided.t Bug 14778: Use mock_dbh where it should be used 2015-10-23 12:01:18 -03:00
Reports_Guided.t Bug 15152: t/db_dependent/Reports_Guided.t should not depend on existing data 2015-11-16 15:55:22 -03:00
Reserves.t Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration 2015-12-11 16:08:50 +00:00
Review.t Bug 15199: t/db_dependent/Review.t should not depend on existing data 2015-11-17 23:45:25 -03:00
RotatingCollections.t Bug 8836: (RM followup) unit tests should use the new API 2014-11-07 11:09:14 -03:00
SIP_ILS.t Bug 7904: (QA followup) fix tests 2015-02-05 15:50:32 -03:00
Search.t Bug 9819: Make the tests pass 2015-12-30 15:50:15 +00:00
Serials.t Bug 15168: Remove C4:Serials::ItemizeSerials 2015-11-17 15:34:00 -03:00
Serials_2.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Service.t
…
ShelfBrowser.t Bug 14878: Tests - Create the branchcodes when needed 2015-11-06 15:51:51 -03:00
Sitemapper.t Bug 14778: Example - Replace DBI::Mock with Test::DBIx::Class - Sitemapper.t 2015-10-23 12:01:18 -03:00
Stats.t
…
SuggestionEngine_ExplodedTerms.t Bug 12653: remaining prog reference in t/db_dependent/SuggestionEngine_ExplodedTerms.t 2014-10-29 23:37:54 -03:00
Suggestions.t Bug 13014: (QA followup) have new warnings tested 2015-06-24 14:54:36 -03:00
Tags.t Bug 12916 - Missing Test to demonstrate warnings. 2014-10-30 00:31:26 -03:00
Templates.t Bug 5338: (QA followup) update the tests for the new reports 2015-05-19 13:54:09 -03:00
TestBuilder.t Bug 15601: Fix TestBuilder tests 2016-01-23 19:01:41 +00:00
Upload.t Bug 14893: Separate temporary storage per instance in Upload.pm 2016-01-29 01:17:55 +00:00
Virtualshelves.t Bug 14544: [QA Follow-up] Added some test descriptions 2015-11-05 10:00:31 -03:00
XISBN.t Bug 12782: (followup) skip tests that fail because of provider's error 2014-08-20 12:29:27 -03:00
XSLT_Handler.t Bug 13262: (QA followup) fix duplicate variable definition 2015-02-05 15:25:50 -03:00
check_sysprefs.t Bug 14383: Fix some typos in comments and documentation 2015-06-22 17:34:46 -03:00
default_search_class.pl
…
rollingloans.t Bug 13315 - Add feedback for last item checked out to circulation.pl 2015-04-13 14:52:26 -03:00
sysprefs.t Bug 13967: Add a couple of tests for SysPref and Object 2015-06-04 10:39:16 -03:00
zebra_config.pl Bug 15082: t/db_dependent/Search.t shouldn't mock the DB connection 2015-10-29 14:10:23 -03:00