Koha-clms/Koha
Marcel de Rooy 0c138700b2 Bug 14893: Separate temporary storage per instance in Upload.pm
To make life easier when multiple instances are uploading temporary
files to Koha, this patch adds the database name to the upload subfolder
in your /tmp folder.

Note: Although multiple instances could share the same subfolder for
temporary storage (hashvalue is based on a timestamp too), it will be
better to separate them for efficient housekeeping (removing older or
partial files with a cronjob etc.)
Since multiple instances come with separate permissions, keeping them in
separate folders will be much simpler.

Permanent storage is not affected by this patch. The location of permanent
storage is ruled by the upload_path in each config file. Sharing that
space is not recommended too.

Although it may not be strictly necessary yet to remove files from the old
temp storage folder (before the 3.22 release), the accompanying db rev
performs that housekeeping task.

Test plan:
[1] Do not yet apply this patch. Upload a temporary file (use the
    tools/upload.pl script without selecting a category).
[2] Check /tmp/koha_upload.
[3] Apply this patch. Run the db rev with web installer.
[4] Upload another temporary file.
[5] Check /tmp for folder [your_database]_upload.
[6] Check that /tmp/koha_upload is gone and the associated records too.
[7] Run the adjusted t/db../Upload.t

Followed test plan. Could not do steps before applying patch [1]-[2]
(I suppose a local permission problem).
After applying patch and updating db file appears in /tmp/[database]
as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
2016-01-29 01:17:55 +00:00
..
Acquisition Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber 2015-02-10 11:24:08 -03:00
Authority Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s] 2015-12-31 18:50:41 +00:00
Borrower Bug 14368: Add discharges history. 2015-09-28 11:56:33 -03:00
Cache Bug 12041 - improve Koha::Cache 2014-06-19 13:05:04 -03:00
Config Bug 13967 - System preferences need a package 2015-06-04 10:39:11 -03:00
Exporter Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Filter/MARC Bug 15380: Move Koha::Authority to Koha::MetadataRecord::Authority 2015-12-31 18:50:41 +00:00
Indexer Bug 11081: (followup) Add license information 2016-01-27 06:30:44 +00:00
Item/Search Bug 11425: Add unit tests 2014-11-04 19:10:28 -03:00
List Bug 15065: (follow-up) update license header 2013-10-14 21:50:10 +00:00
MetadataRecord Bug 15381: Remove GetAuthType and GetAuthTypeCode 2015-12-31 18:59:02 +00:00
Misc Bug 13813: Remove deprecated module C4::Dates from system 2015-09-18 12:40:55 -03:00
Number Bug 13836: Does not separate symbol and value if symbol is not displayed. 2015-03-19 14:10:21 -03:00
OAI/Server Bug 14939: Modularize OAI Server existing classes 2015-12-31 15:15:05 +00:00
Patron Bug 14836: Move Koha::PatronCategor* to Koha::Patron::Categor* 2015-11-05 10:57:41 -03:00
Plugins Bug 14467: Security updates break some Koha plugins 2015-07-07 14:50:43 -03:00
QueryParser/Driver Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
REST Bug 13799: Reword 'borrower' to 'patron' 2015-11-04 13:47:33 -03:00
RecordProcessor Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Schema/Result Bug 8753: [QA Follow-up] Primary key and collation 2016-01-27 06:40:56 +00:00
Sitemapper Bug 11190: (QA followup) for tests on jenkins 2015-08-31 10:32:34 -03:00
Subscription Bug 12375 [7] - Update to use Koha::Object classes 2015-12-31 12:29:05 +00:00
SuggestionEngine Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Template/Plugin Bug 15135: Remove Warning Subroutine HasOverdues redefined 2016-01-27 02:12:38 +00:00
Util Bug 8064: Merge several biblios 2015-11-09 15:08:57 -03:00
AdditionalField.pm Bug 10855: Remove additional field values when subscription is removed 2015-10-02 15:10:31 -03:00
AudioAlert.pm Bug 11431: (QA followup) Fix POD 2015-11-04 12:32:58 -03:00
AudioAlerts.pm Bug 11431: (QA followup) Unit Tests 2015-11-04 12:33:03 -03:00
AuthUtils.pm Bug 11944: Authentication 2015-01-13 13:07:14 -03:00
AuthorisedValue.pm Bug 10363: QA Follow-up - fixing POD and spelling 2015-10-19 12:46:27 -03:00
AuthorisedValues.pm Bug 10363: FIX regression - prevent duplicate 2015-10-19 12:46:28 -03:00
Authorities.pm Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s] 2015-12-31 18:50:41 +00:00
Authority.pm Bug 15380: Introduce Koha::Authorit[y|ies] and Koha::Authority::Type[s] 2015-12-31 18:50:41 +00:00
Biblio.pm Bug 13918 [QA Followup] - Improve $biblio->subtitles() 2015-12-31 12:37:50 +00:00
BiblioFramework.pm Bug 14889: QA Follow-up 2015-12-31 19:04:45 +00:00
BiblioFrameworks.pm Bug 14889: Add Koha::BiblioFramework[s] classes 2015-12-31 19:04:44 +00:00
Biblioitem.pm Bug 14722: Add Koha::Biblioitem[s] 2015-10-27 16:59:52 -03:00
Biblioitems.pm Bug 14722: Add Koha::Biblioitem[s] 2015-10-27 16:59:52 -03:00
Biblios.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Borrower.pm Bug 9303 [QA Followup] - Restore ability for patron to control setting 2015-12-31 13:09:45 +00:00
Borrowers.pm Bug 13019 - Add base classes on which to build Koha objects 2015-02-12 15:21:01 -03:00
Cache.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Calendar.pm Bug 14522: (QA followup) Remove POD and fix tests 2015-10-02 12:08:04 -03:00
Cities.pm Bug 14888: Add Koha::Cit[y|ies] classes 2015-10-05 12:00:38 -03:00
City.pm Bug 14888: Add Koha::Cit[y|ies] classes 2015-10-05 12:00:38 -03:00
Database.pm Bug 14778: Set PrintError as it was before 2015-10-23 12:01:17 -03:00
DateUtils.pm Bug 12072: Add system preference for New dateformat dd.mm.yyyy (dmydot) 2015-11-19 13:12:00 -03:00
Email.pm Bug 9530: Adding a new Koha::Email module 2014-10-27 10:38:14 -03:00
Exceptions.pm Bug 14544: QA fixes - some minor bug fixes 2015-11-05 10:00:31 -03:00
FrameworkPlugin.pm Bug 9006: Remove AUTOLOAD in C4::Context 2015-07-20 10:11:41 -03:00
Hold.pm Bug 14310 [QA Followup] - Adapt existing code to use new methods 2016-01-27 06:20:19 +00:00
Holds.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
I18N.pm Bug 11848: (follow-up) update license statment 2014-05-05 04:51:42 +00:00
IssuingRule.pm Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it 2015-12-31 19:19:45 +00:00
IssuingRules.pm Bug 15129: Add Koha::Object for issuing rules and let smart-rules.pl use it 2015-12-31 19:19:45 +00:00
Item.pm Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
ItemType.pm Bug 14828: Add Koha::ItemType[s] classes 2016-01-27 20:46:57 +00:00
ItemTypes.pm Bug 14828: Add Koha::ItemType[s] classes 2016-01-27 20:46:57 +00:00
Items.pm Bug 13851: Replace waiting holds logic in circulation.pl with Koha Objects 2015-07-29 15:47:13 -03:00
Libraries.pm Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
Library.pm Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
LibraryCategories.pm Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
LibraryCategory.pm Bug 15294: Koha::Libraries - Move existing Koha::Branch[es] 2016-01-14 15:22:26 +00:00
Linktracker.pm Bug 8917 : [ Sign followup ] Track clicks to links external to Koha 2013-03-07 11:14:25 -05:00
Localization.pm Bug 14100: Generic solution for language overlay - Item types 2015-10-27 12:34:06 -03:00
Localizations.pm Bug 14100: Generic solution for language overlay - Item types 2015-10-27 12:34:06 -03:00
Logger.pm Bug 14167: (QA followup) use warn instead of just STDERR 2015-07-21 10:50:17 -03:00
MetaSearcher.pm Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
MetadataRecord.pm Bug 15578: Make sure all params will be taken into account when instantiating 2016-01-23 18:28:49 +00:00
NorwegianPatronDB.pm Bug 14403: Remove warn in Koha::NorwegianPatronDB 2015-06-19 11:34:16 -03:00
Object.pm Bug 13799: RESTful API with Mojolicious and Swagger2 2015-11-04 13:47:32 -03:00
Objects.pm Bug 15473: Make Koha::Objects->find accepts 0 and '' as a key 2016-01-12 15:58:44 +00:00
Plugins.pm Bug 12412: Add ability for plugins to convert arbitrary files to MARC from record staging tool 2015-05-04 15:33:51 -03:00
RecordProcessor.pm Bug 14646: Koha::RecordProcessor should accept more than one filter 2015-08-20 13:44:15 -03:00
Schema.pm Bug 11891: (follow-up) remove custom storage class 2014-06-19 11:55:03 -03:00
Serial.pm Bug 12375 [7] - Update to use Koha::Object classes 2015-12-31 12:29:05 +00:00
Serials.pm Bug 12375 [7] - Update to use Koha::Object classes 2015-12-31 12:29:05 +00:00
SimpleMARC.pm Bug 14098: Implement the copy_and_replace action for MTT 2015-09-07 11:17:13 -03:00
Sitemapper.pm Bug 11190: (QA followup) for tests on jenkins 2015-08-31 10:32:34 -03:00
Subscription.pm Bug 12375 [7] - Update to use Koha::Object classes 2015-12-31 12:29:05 +00:00
Subscriptions.pm Bug 12375 [7] - Update to use Koha::Object classes 2015-12-31 12:29:05 +00:00
SuggestionEngine.pm Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
Upload.pm Bug 14893: Separate temporary storage per instance in Upload.pm 2016-01-29 01:17:55 +00:00
Virtualshelf.pm Bug 14544: Handle database error when creating a shelf with DB admin account 2015-11-05 10:00:22 -03:00
Virtualshelfcontent.pm Bug 14544: Koha::Virtualshelfcontent[s] 2015-11-05 09:58:01 -03:00
Virtualshelfcontents.pm Bug 14544: Koha::Virtualshelfcontent[s] 2015-11-05 09:58:01 -03:00
Virtualshelfshare.pm Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares 2015-11-05 09:58:01 -03:00
Virtualshelfshares.pm Bug 14544: Move share routines to Koha::Virtualshelfshare and Koha::Virtualshelfshares 2015-11-05 09:58:01 -03:00
Virtualshelves.pm Bug 14544: Get rid of GetSomeShelfNames 2015-11-05 09:58:02 -03:00
XSLT_Handler.pm Bug 13262 - Add parameters to XSLT Handler transform method 2015-02-05 15:24:29 -03:00