Koha-clms/tools
Nick Clemens 8c2e32976a Bug 28832: Don't batch modify fields that we don't update
In bug 27837 we made sure to always pass through the permanent_location if it was passed in unlike
other fields which are not passed if they have no value.
During batch mod, however, fields that aren't editied have no value, so forcing permanent_location
to pass through forces blanking it.

This patch alters the script to only pass thgouhr for edit the fields that have been updated or
cleared.

To test:
 1 - In frameworks add a new subfield to 952, "C" - make it editable in items tab and visible in intranet/editor
 2 - In mappings map that subfield to items.permanent_location
 3 - Set an item to have differing shelving location and permanent_location
 4 - This saves correctly for an individual item
 5 - Edit the item using Tools->batch item modification, updating the note field
 6 - Note the permanet_location is removed
 7 - Check the DB, the field is set to NULL
 8 - Apply patch
 9 - Repeat
10 - Permanent location is not cleared
11 - Verify that clearing fields works as before, including permanent_location

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Deb Stephenson <dstephen@dubuque.lib.ia.us>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
(cherry picked from commit ba9713ba3a)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
2022-02-20 23:15:07 +01:00
..
csv-profiles
…
quotes Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
access_files.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
ajax-inventory.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
automatic_item_modification_by_age.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
background-job-progress.pl Bug 20017: use Modern::Perl in Tools perl scripts 2018-02-05 09:46:45 -03:00
batchMod.pl Bug 28832: Don't batch modify fields that we don't update 2022-02-20 23:15:07 +01:00
batch_delete_records.pl Bug 28835: Fix ability to pass list contents to batch record modification 2021-08-13 10:12:45 -10:00
batch_extend_due_dates.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
batch_record_modification.pl Bug 28835: Fix ability to pass list contents to batch record modification 2021-08-13 10:12:45 -10:00
batch_records_ajax.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cleanborrowers.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
copy-holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
csv-profiles.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
exceptionHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
export.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
holidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
import_borrowers.pl Bug 26059: Create guarantor/guarantee links on patron import 2021-02-19 15:46:22 +01:00
inventory.pl Bug 28015: Fix inventory for timeformat=12h 2021-04-22 15:55:35 +02:00
koha-news.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
letter.pl Bug 22818: Add support for ILL notices 2020-11-11 08:35:10 +01:00
manage-marc-import.pl Bug 23019: Add profiles to stage-import-batch and magnage-import-batch pages 2020-11-11 15:55:49 +01:00
marc_modification_templates.pl Bug 26784: Silence warns about comparing undefined values for MARC modification templates 2020-10-26 00:14:41 +01:00
modborrowers.pl Bug 27413: Restore debarred and debarredcomment to batch patron mod tools 2021-01-20 09:26:51 +01:00
newHolidays.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
overduerules.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
picture-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
problem-reports.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes-upload.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
quotes.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
scheduler.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
showdiffmarc.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
stage-marc-import.pl Bug 21818: Replace AutoCommit flag with DBIx transaction in stage-marc-import.pl 2021-04-30 10:37:18 +02:00
stockrotation.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
tools-home.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-cover-image.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
upload-file.pl Bug 17501: Rename Upload to Uploader 2017-01-20 14:20:06 +00:00
upload.pl Bug 25476: Add ability to browse file uploads by category 2021-04-29 11:07:21 +02:00
viewlog.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00