Koha-clms/t
Chris Cormack 5e4e10c4ca Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories
Edit: Fixing merge conflicts in
 - t/db_dependent/Items.t
 - t/db_dependent/Search.t
 - C4/Search.pm

Changes the API for calling GetHiddenItems and all the places in the code that call it. This is to allow borrower categories to be passed in.
Adds an OpacHiddenItemsExceptions syspref to allow certain borrower categories to be able to see items, even if they are marked hidden by OpacHiddenItems

To test:

1) Make two borrowers, one in a category that should see everything (ie Adult), and another in a category that should only see certain things (ie Adult - exceptions)
2) Add the borrower that can see everything (the Adult) to OpacHiddenItemsExceptions
3) To the OpacHiddenItems syspref, add an item type (ensure that you have some records that fall under this type in your library).
4) Log in as the borrower that should only see certain things (Adult - exception)
5) Do a search, filtered to show records which are the item type that you specified in the OpacHiddenItems syspref. No records should show for this borrower as this item type is hidden to them.
6) Log in as the borrower that should see everything (Adult)
7) Do the same search. There should be results from this search, as this borrower category has been specified as an exception to the hidden items

Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk>

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
2018-11-02 10:33:09 +00:00
..
Acquisition Bug 18756 - add Unit Test 2017-07-06 14:29:02 -03:00
Biblio Bug 20540: Fix TransformHtmlToXml if last tag is empty 2018-04-11 16:45:19 -03:00
Budgets Bug 18942: (QA followup) Add new tests descriptions 2017-07-17 15:52:01 -03:00
Circulation Bug 17557: Koha::Patrons - Move GetAge to ->set_age (and remove SetAge) 2016-12-16 11:57:38 +00:00
External Bug 20737: Use https for baker and taylor cover images 2018-05-11 11:36:23 -03:00
Koha Bug 21233: Unit tests 2018-09-14 17:54:13 +00:00
Members Bug 18851: Tests must be skipped in cardnumber.t if Test::DBIx::Class is not installed 2017-08-08 09:21:06 -03:00
Number Bug 20625: Add tests 2018-04-24 11:29:46 -03:00
SIP Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search Bug 16660: (followup) Unit tests 2017-10-27 14:09:02 -03:00
Serials
…
Test Bug 19176: Fix how t::lib::Dates::compare handle timezone 2017-10-30 14:55:18 -03:00
db_dependent Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories 2018-11-02 10:33:09 +00:00
edi_testfiles
…
etc Bug 18286: [Follow-up] Add t/etc/schema.pl 2017-06-05 17:52:35 -03:00
lib Bug 21717: Fix generation of real's values 2018-11-01 19:05:46 +00:00
00-checkdatabase-version.t
…
00-deprecated.t
…
00-load.t Bug 21068: Remove NorwegianPatronDB related code 2018-08-30 13:40:29 +00:00
00-merge-conflict-markers.t Bug 19335: Fix 00-merge-conflict-markers.t when dockerised 2017-09-19 09:00:49 -03:00
00-testcritic.t
…
00-valid-xml.t
…
AuthUtils.t Bug 18298: Add server-side checks and refactor stuffs 2017-10-16 09:44:32 -03:00
Auth_with_shibboleth.t Bug 12027: (QA follow-up) Update tests 2018-10-01 13:56:31 +00:00
AuthoritiesMarc_MARC21.t
…
AuthoritiesMarc_UNIMARC.t
…
Barcodes_EAN13.t
…
Barcodes_annual.t
…
Barcodes_hbyymmincr.t
…
Barcodes_incremental.t
…
Biblio.t Bug 18712: (QA follow-up) Add count of tests 2017-11-26 13:00:03 -03:00
Biblio2.t
…
Bookseller.t
…
Boolean.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Budgets.t
…
Cache.t
…
Calendar.t Bug 19204: Add tests for new days_mode parameter 2018-04-25 10:52:21 -03:00
Charset.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Circulation_barcodedecode.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ClassSortRoutine.t
…
ClassSortRoutine_Dewey.t
…
ClassSortRoutine_Generic.t
…
ClassSortRoutine_LCC.t
…
ClassSource.t
…
Context.t
…
Contract.t
…
Creators.t
…
DateUtils.t Bug 18330: Add RFC3339 to Koha::DateUtils 2017-12-14 16:58:22 -03:00
Debug.t
…
EdiInvoice.t
…
Edifact.t
…
Ediorder.t Bug 20972: Add a testcase for bug 20972 2018-06-22 20:12:16 +00:00
Ediordrsp.t
…
Form_MessagingPreferences.t
…
Heading.t
…
HtmlTags.t Bug 18665: Add test for HtmlTags.pm 2017-06-21 11:22:19 -03:00
Images.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ImportBatch.t
…
Installer_PerlDependencies.t
…
Installer_PerlModules.t Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
Installer_pm.t Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
ItemCirculationAlertPreference.t
…
Koha.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Email.t
…
Koha_ExternalContent_OverDrive.t Bug 18851: (QA followup) Test doesn't need sessions on DB 2017-08-08 09:21:06 -03:00
Koha_ExternalContent_RecordedBooks.t Bug 21536: t/Koha_ExternalContent_RecordedBooks.t skips more tests than scheduled 2018-10-12 15:02:33 -03:00
Koha_MetadataRecord.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Template_Plugin_Cache.t
…
Koha_Template_Plugin_Koha.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Util_FrameworkPlugin.t
…
Koha_Util_MARC.t
…
Labels.t
…
Labels_split_ccn.t
…
Labels_split_ddcn.t
…
Labels_split_lccn.t
…
Languages.t
…
Letters.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Log.t
…
Logger.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Makefile.t Bug 20267: .gitignore do not need to be mapped in Makefile 2018-03-26 19:35:07 -03:00
Matcher.t Bug 18712: Fix t/Matcher.t if DB is empty 2017-11-26 13:00:03 -03:00
Members_AttributeTypes.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Members_Attributes.t
…
Members_Messaging.t
…
OpenLibrarySearch.t
…
Output.t Bug 20422: Add unit test to Output.t for parametrized_url 2018-03-26 17:31:13 -03:00
Output_JSONStream.t
…
Patron.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patroncards.t
…
Patroncards_Batch.t
…
Patroncards_Layout.t
…
Patroncards_Lib.t
…
Patroncards_Patroncard.t
…
Patroncards_Profile.t
…
Patroncards_Template.t
…
Prices.t Bug 20466: Fix fixture syntax in t/Prices.t 2018-03-23 13:24:14 -03:00
Print.t
…
QueryParser.t
…
RecordProcessor.t
…
Ris.t
…
SMS.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Scheduler.t
…
Scrubber.t
…
Search.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search_PazPar2.t
…
SimpleMARC.t
…
SocialData.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Stats.t
…
SuggestionEngine.t
…
SuggestionEngine_AuthorityFile.t Bug 9857: Fix failing tests 2017-09-01 16:22:02 -03:00
TmplToken.t
…
Token.t Bug 18124: [Follow-up] Handle default parameters in a sub 2017-03-30 09:07:08 +00:00
XSLT.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
dummy.t
…
perlcriticrc
…
template_filters.t Bug 21576: Preserve chomp chars for USE raw 2018-10-26 17:09:53 +00:00
timezones.t Bug 18674: TZ error handling 2018-04-11 16:45:08 -03:00