The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> |
||
|---|---|---|
| .. | ||
| IssuingRules | ||
| Branch.t | ||
| CalcDateDue.t | ||
| CalcFine.t | ||
| CheckIfIssuedToPatron.t | ||
| CheckValidBarcode.t | ||
| GetHardDueDate.t | ||
| GetPendingOnSiteCheckouts.t | ||
| GetTopIssues.t | ||
| IsItemIssued.t | ||
| MarkIssueReturned.t | ||
| NoIssuesChargeGuarantees.t | ||
| OfflineOperation.t | ||
| ReturnClaims.t | ||
| Returns.t | ||
| StoreLastBorrower.t | ||
| SwitchOnSiteCheckouts.t | ||
| TooMany.t | ||
| dateexpiry.t | ||
| issue.t | ||
| transferbook.t | ||
| transfers.t | ||