Koha-clms/t/db_dependent
Kyle M Hall 4aaf0b3077 Bug 27837: Check the MARC directly, not the transformed item
If permanent location is mapped, it will exist in the MARC.
However, when we are transforming our item hash to MARC,
we are losing our permanent location mapping, at least in unit tests.

By checking the original MARC for the permenent location, we remove the
risk of losing it the "empty" permenent location through the
transformation process. We only need to know that it existed in the
original item marc to know we need to update it in the database.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit db382ebaff)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2021-05-20 14:50:15 +02:00
..
Acquisition Bug 27203: Adjust unit tests 2021-05-12 17:09:55 +02:00
Auth Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Authority Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Biblio Bug 26516: Don't accept incorrect values for copyrightdate/publicationyear 2020-11-16 14:25:21 +01:00
Circulation Bug 7806: Fix remaining occurrences of 0000-00-00 2021-03-04 10:24:48 +01:00
CourseReserves Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Creators Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Exporter Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Holds Bug 27058: Add test for IsAvailableForItemLevelRequest and notforloan 2021-03-12 09:05:18 +01:00
Illrequest Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Items Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha Bug 27724: Add unit test 2021-05-20 14:48:51 +02:00
LDAP Bug 21395: (QA follow-up) Remove some introduced issues 2020-06-29 12:37:02 +02:00
Labels Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Letters Bug 26745: (QA follow-up) Add Unit Tests 2020-11-04 17:32:35 +01:00
Members Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
OAI Bug 25460: Add unit test for change to C4::OAI::Sets->UpdateOAISetsBiblio() 2020-10-15 12:56:31 +02:00
Patron Bug 26594: add Unit Test 2020-11-10 15:00:14 +01:00
Record Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
Reports Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Reserves Bug 26634: Remove GetHoldRule subroutine in C4::Reserves 2020-12-28 14:35:18 +01:00
SIP Bug 28320: Add DB connection check to the SIP SC status message 2021-05-18 12:20:18 +02:00
Search Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Serials Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Template/Plugin Bug 26984: Make tests pass if AnonymousPatron is set 2020-11-20 08:16:02 +01:00
Utils Bug 27715: Use $dbh->quote_identifier to quote untrusted input 2021-02-23 14:35:08 +01:00
api/v1 Bug 18729: Add more tests 2021-04-22 16:40:27 +02:00
cronjobs Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
data Bug 27968: Fix framework import if isurl has an incorrect value 2021-04-29 16:30:57 +02:00
misc/translator Bug 25067: Adjust paths in tests 2020-11-06 16:59:40 +01:00
selenium Bug 27029: Add a selenium regression test 2021-01-29 16:01:32 +01:00
www Bug 26031: Remove the failing tests and the diag 2020-11-20 08:16:02 +01:00
00-strict.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
01-test_dbic.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Accounts.t Bug 26984: Make tests pass if AnonymousPatron is set 2020-11-20 08:16:02 +01:00
Acquisition.t Bug 26584: Remove unused C4::Acquisition::CloseBasket function 2020-11-05 15:24:20 +01:00
Amazon.t
…
ArticleRequests.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
AuthUtils.t Bug 26384: (QA follow-up) Fix two exceptions 2020-09-11 09:56:56 +02:00
Auth_with_cas.t Bug 20854: Add more CAS tests 2021-04-29 13:57:51 +02:00
Auth_with_ldap.t Bug 25172: Fix Auth_with_ldap.t 2020-04-22 15:43:16 +01:00
AuthorisedValues.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
AuthoritiesMarc.t Bug 25313: (QA follow-up) DelAuthority tests 2020-11-18 12:03:03 +01:00
BackgroundJob.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Barcodes.t Bug 26250: Fix tests when SearchEngine=Elastic 2020-08-31 16:10:26 +02:00
Barcodes_ValueBuilder.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Biblio.t Bug 27577: Unit test 2021-05-11 16:02:52 +02:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t Bug 23195: (follow-up) One text invoice should be open 2021-04-29 16:06:22 +02:00
Cache.t Bug 16067: Remove FastMmap 2020-12-07 09:44:07 +01:00
Calendar.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Charset.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Circulation.t Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines' 2021-04-30 10:54:08 +02:00
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Context.t Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
Contract.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
DecreaseLoanHighHolds.t Bug 14866: Make high holds work with different item types 2020-11-06 15:55:17 +01:00
Filter_MARC_ViewPolicy.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Fines.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
FrameworkPlugin.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Heading.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Heading_MARC21.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Hold.t Bug 12556: Add new "in processing" state to holds 2020-10-14 14:50:07 +02:00
Holds.t Bug 28078: (follow-up) Add param check to 'itemAlreadyOnHold' test 2021-04-29 10:58:52 +02:00
HoldsQueue.t Bug 24359: (QA follow-up) Fix tests 2021-03-12 09:45:30 +01:00
Holidays.t Bug 25723: Remove tests for removed method 2020-07-20 17:45:31 +02:00
ILSDI_Services.t Bug 17229: Fix perlcritic on ILSDI_Services.t 2021-01-25 14:53:42 +01:00
Illcomments.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Illrequestattributes.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Illrequests.t Bug 22818: Fix TestBuilder.t 2020-11-11 18:03:17 +01:00
ImportBatch.t Bug 24469: Move the new queries to a dedicated ImportBatch subroutine 2021-02-22 11:11:53 +01:00
ImportExportFramework.t Bug 27569: Add tests for ODS export 2021-02-19 16:38:27 +01:00
Installer.t Bug 26325: Add primary_key_exists check to C4::Installer 2020-10-01 10:32:15 +02:00
Items.t Bug 27837: Check the MARC directly, not the transformed item 2021-05-20 14:50:15 +02:00
Koha.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_Authority.t
…
Koha_Database.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_Elasticsearch.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Koha_ExternalContent_OverDrive.t Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Koha_ExternalContent_RecordedBooks.t Bug 17602: RecordedBooks Integration to Koha 2018-10-01 13:56:38 +00:00
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t Bug 18213: Add language facets to Elasticsearch 2019-03-28 15:57:32 +00:00
Letters.t Bug 28017: (follow-up) Fix Letters.t 2021-04-13 17:04:45 +02:00
LibraryGroups.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Linker_Default.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Linker_FirstMatch.t Bug 24269: Adjust C4::Heading to generate headings from auth tags 2020-02-19 13:33:32 +00:00
Log.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
MarcModificationTemplates.t Bug 26894: Handle subfield 0 and delete empty fields 2021-01-18 15:30:59 +01:00
Members.t Bug 26517: Add unit test 2021-04-07 10:30:23 +02:00
MungeMarcPrice.t Bug 14334: Remove AutoCommit from tests 2018-12-14 13:42:37 +00:00
NewsChannels.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Overdues.t Bug 28144: Add a regression test 2021-04-30 10:44:14 +02:00
Passwordrecovery.t Bug 22343: (follow-up) Remove traces of Mail::Sendmail 2020-10-05 11:15:51 +02:00
PatronLists.t Bug 21817: Centralize the mock of userenv from tests 2019-01-02 20:18:29 +00:00
Patroncards.t Bug 22878: Add tests 2019-05-15 12:10:52 +00:00
Patrons.t Bug 27554: Clarify and add tests for update_category_to 2021-02-05 16:37:15 +01:00
Record.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Reports.t
…
Reserves.t Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting 2021-04-13 17:07:04 +02:00
RotatingCollections.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Search.t Bug 27928: FindDuplicate should use simple_search_compat 2021-04-13 16:52:54 +02:00
Serials.t Bug 27842: Add tests 2021-05-12 15:58:29 +02:00
Serials_2.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Service.t
…
ShelfBrowser.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
StockRotationItems.t Bug 23432: (QA follow-up) Add a unit test 2020-10-26 00:04:18 +01:00
StockRotationRotas.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
StockRotationStages.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
SuggestionEngine_ExplodedTerms.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Suggestions.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
TablesSettings.t Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
Tags.t Bug 21846: Simplify ugly double for loops 2019-03-15 12:27:44 +00:00
Templates.t Bug 20727: Move temporary_directory() to C4::Context 2018-06-22 16:10:09 +00:00
TestBuilder.t Bug 28234: Regression tests 2021-04-30 11:02:25 +02:00
Upload.t Bug 28123: Fix expected value in unit test 2021-04-22 16:17:09 +02:00
UsageStats.t Bug 23420: (QA follow-up) Remove more AllowPurchaseSuggestionBranchChoice code 2020-10-09 12:22:01 +02:00
Virtualshelves.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
XISBN.t Bug 28288: Prevent XSISBN.t to fail if service is returning 500 2021-05-11 16:01:09 +02:00
XSLT.t Bug 23406: Unit test 2021-05-12 17:19:05 +02:00
check_kohastructure.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
check_sysprefs.t Bug 23895: Fix check_sysprefs.t 2020-10-14 15:52:29 +02:00
db_structure.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
rollingloans.t Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
sysprefs.t Bug 22880: (follow-up) Loose ends: Better DB update, global inclusion, etc. 2020-02-24 13:24:25 +00:00
zebra_config.pl Bug 24735: Remove QueryParser-related code 2020-03-02 11:13:03 +00:00