gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/admin
History
Jonathan Druart 9bf48192b7 Bug 15773: Fix and standardise checkboxes code in framework 
When creating a new subfield for an authority framework, the checkboxes
don't behave as they should.
If you click on the 'repeatable', 'mandatory' or 'is url' checkbox's
label, the checkbox from the second tab will be checked/unchecked.
This is caused by a non-unique id of the input element.

I have found this bug when working on the removal of CGI::checkbox in
both admin/auth_subfields_structure.pl and
admin/marc_subfields_structure.pl scripts.

This patch remove the use of CGI::checkbox as well as the generation of
html code from these 2 pl scripts (which should be avoided).
The code these scripts are now pretty similar.

Test plan:
Add/modify/remove subfield for a MARC framework and an Authority
framework.
Use as many field as possible and confirm that the values are correctly
inserted/displayed.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
(cherry picked from commit 39597b86ae)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
(cherry picked from commit 60e601bf5f)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
 		2016-04-27 16:24:23 +02:00
..
add_user_search.pl Bug 15109: Make name the default sort order for all patron searches 2015-11-29 22:09:58 +01:00
admin-home.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
aqbudgetperiods.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
aqbudgets.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 18:13:01 +01:00
aqcontract.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
aqplan.pl Bug 15344: Remove unucessary call to GetMemberDetails 2015-12-31 18:08:27 +01:00
auth_subfields_structure.pl Bug 15773: Fix and standardise checkboxes code in framework 2016-04-27 16:24:23 +02:00
auth_tag_structure.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
authorised_values.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
authtypes.pl Bug 10947: Fix editing the default authority type 2015-05-19 09:25:59 -03:00
biblio_framework.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
branch_transfer_limits.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
branches.pl Bug 8802: On editing a library group category type is not set 2015-07-13 09:51:44 +12:00
categorie.pl Bug 10011: Save branch limitations on creating a new patron category 2015-05-19 09:21:23 -03:00
check_budget_parent.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
check_parent_total.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
checkmarc.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
cities.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
classsources.pl Bug 16013: Make classification sources deletable 2016-03-23 13:49:31 +01:00
clone-rules.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
columns_settings.pl Bug 13875: Columns configuration - Allow underscore in table name 2015-04-08 14:51:59 -03:00
columns_settings.yml Bug 14841: Fine column is not manage by columns settings 2016-04-05 09:31:18 +02:00
currency.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
didyoumean.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
env_tz_test.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
fieldmapping.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
import_export_framework.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
item_circulation_alerts.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
items_search_field.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
items_search_fields.pl Bug 11425: Add item search form in staff interface 2014-11-04 19:08:12 -03:00
itemtypes.pl Bug 12965: Prevent to erase an existing item type 2015-09-22 13:42:53 +12:00
koha2marclinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
marc_subfields_structure.pl Bug 15773: Fix and standardise checkboxes code in framework 2016-04-27 16:24:23 +02:00
marctagstructure.pl Bug 1487: Store the "display only used tags/subf" value in a cookie 2015-04-30 15:23:01 -03:00
matching-rules.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_set_mappings.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
oai_sets.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
patron-attr-types.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
preferences.pl Bug 14145: Noisy warns in admin/preferences.pl 2015-05-22 09:37:24 -03:00
printers.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
smart-rules.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
sru_modmapping.pl Bug 6536: Add a form for SRU Field mapping 2014-09-01 10:08:50 -03:00
stopwords.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
systempreferences.pl Bug 14521: SQL injection in local use system preferences 2015-07-21 16:02:14 +12:00
transport-cost-matrix.pl Bug 14153: Noisy warns in admin/transport-cost-matrix.pl 2015-12-31 18:01:29 +01:00
z3950servers.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00