I added 'use warnings' to C4::Biblio and made a handful of changes to reduce the number of warnings emitted. One notable spot is the change in the regex in C4::Biblio::GetNoZebraIndexes. I have replaced the parens with a character class. The parens change the way 'split' works, making it return elements for each delimiter. We did not want those elements returned, and they only resulted in "'' => undef" being added to the final hash. They also resulted in two "undefined" warnings for each pass through the loop. I've included a simple test for this function. There may be a few warnings still emitted in spots, but either I haven't seen them yet, or I have chosen to not fix them yet because they require too much change. Signed-off-by: Galen Charlton <galen.charlton@liblime.com> |
||
|---|---|---|
| .. | ||
| data/db_schemas | ||
| db_dependent | ||
| lib | ||
| Amazon.t | ||
| Barcodes_PrinterConfig.t | ||
| Bookfund.t | ||
| Bookseller.t | ||
| Boolean.t | ||
| Branch.t | ||
| Calendar.t | ||
| Charset.t | ||
| Circulation_barcodedecode.t | ||
| Dates.t | ||
| Debug.t | ||
| Input.t | ||
| Koha.t | ||
| Languages.t | ||
| Maintainance.t | ||
| Makefile | ||
| Output.t | ||
| Record.t | ||
| Review.t | ||
| Scrubber.t | ||
| Stats.t | ||
| database_dependent.pl | ||
| dummy.t | ||
| rewrite-config-test.PL | ||
| smolder_smoke_signal | ||