Koha-clms/tools
Mark Tompsett ecf4473fac Bug 14001 - Inventory has bad $_ references
After receiving an error while attempt a simple inventory run,
Two lines were changed from:
    ...$_->...
to
    ...$item->...
since the loop variable is $item. And $_ is not set to the
expected hash reference, when there is a loop variable.

This also helps explain the "Why are there blank dates on my
last seen field?" problem that has been mentioned by users.

TEST PLAN
---------
 1) Apply this patch after a reset to master.
 2) Log in to staff client
 3) Add one item via z39.50, setting barcode to a known value (BARCODE1)
 4) Wait for the reindex
 5) Home -> Tools -> Inventory/Stocktaking
 6) Browse for a file with the barcode in it
 7) Set the library dropdown to the library branch of the added item.
 8) Check 'Compare barcodes list to results:'
 9) Click 'Submit'
    -- This should not die under plack.
       This should not generate blank last seen dates.
       The last seen dates should be as expected.
10) run koha qa test tools
11) Confirm the two change point correspond to the two change points
    in the patch which shall not be pushed to master.

The test result comply with expected outcome outlined in test plan.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
2015-07-26 01:20:11 +12:00
..
csv-profiles MT2116: Addons to the CSV export 2010-02-17 07:51:33 -05:00
quotes Bug 14440: get_template_and_user can not have an empty template_name (quote*_ajax.pl) 2015-07-26 01:20:07 +12:00
ajax-inventory.pl Bug 7684: QA Followup and bugfixes 2013-11-01 00:11:45 +00:00
background-job-progress.pl Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
batchMod.pl Bug 12151: Remove use of smartmatch operator in tools/batchMod.pl 2014-09-23 20:51:25 +00:00
batch_records_ajax.pl Bug 10558 [QA Follow-up] 2014-03-10 15:48:32 +00:00
cleanborrowers.pl Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() 2014-05-09 14:32:30 +00:00
copy-holidays.pl Bug 7477: Copy holidays from one branch to another 2012-03-19 18:10:44 +01:00
csv-profiles.pl Bug 10853 - followup to correct tabs 2013-10-11 02:16:17 +00:00
exceptionHolidays.pl Bug 7351 : feature that allows to delete a range of dates 2012-09-28 12:19:45 +02:00
export.pl Bug 12860: the export tools explodes if a field is not exported 2015-02-26 16:33:51 +13:00
holidays.pl Bug 10277 - Add C4::Context->IsSuperLibrarian() 2013-12-30 15:47:23 +00:00
import_borrowers.pl Bug 11287: make patron import tool take new restrictions system into account 2014-05-05 22:37:12 +00:00
inventory.pl Bug 14001 - Inventory has bad $_ references 2015-07-26 01:20:11 +12:00
koha-news.pl Bug 12705 - News not possible for one sublanguage if two sublanguages are installed 2015-02-25 23:34:55 +13:00
letter.pl Bug 9016: (QA Follow-up) Remove warning from content.length test 2014-05-02 20:29:18 +00:00
manage-marc-import.pl Bug 10558 [QA Follow-up] 2014-03-10 15:48:32 +00:00
marc_modification_templates.pl Bug 8015: QA Followup 2 2013-10-31 22:50:48 +00:00
modborrowers.pl Bug 11929: patron modification error shows borrowernumber 2015-07-25 16:45:56 +12:00
newHolidays.pl Bug 8842 fix Plack scoping for holidays 2012-11-05 08:41:17 -05:00
overduerules.pl Bug 9016: Define different transport types for overdues 2014-05-02 20:29:16 +00:00
picture-upload.pl Bug 10636 - patronimage should have borrowernumber as PK, not cardnumber 2013-10-14 21:08:02 +00:00
quotes-upload.pl Bug 7977: QOTD uploader to enable uploading csv files containing quotes 2012-05-24 14:14:09 +02:00
quotes.pl Bug 7977: Quote-of-the-day (QOTD) Feature for OPAC 2012-05-24 14:14:05 +02:00
scheduler.pl Bug 9108: Followup: send the dateformat value from C4::Auth 2013-01-17 21:59:30 -05:00
stage-marc-import.pl Bug 8015: (follow-up) move from the Koha to the C4 namespace 2013-10-31 22:48:20 +00:00
tools-home.pl Bug 7259 - Show a count of items pending approval on staff client home and tools pages 2011-12-08 12:04:28 +01:00
upload-cover-image.pl Bug 11473 - add 'biblio' and 'item' to cataloguing logging info 2014-01-17 05:42:44 +00:00
upload-file-progress.pl Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
upload-file.pl Bug 7775 - tools/upload-file.pl: scoping for plack 2012-03-26 18:17:45 +02:00
viewlog.pl Bug 10355: paramater 'object' lost on the road 2015-07-26 01:20:04 +12:00