6d8ea60630
Koha::Edifact::Transport reported every transport failure (no transport configured, connect failure, directory-change failure, file-listing failure and per-file download/upload failure) with carp. Under edi_cron.pl these go to STDERR, so on a normal cron run the messages are lost and EDI simply goes quiet with nothing in editrace.log to explain why. Route these failures through Koha::Logger on the 'edi' interface (the same interface edi_cron.pl already uses) so they are recorded in the EDI log. The two ingest()-level data warnings (duplicate filename, unreadable file) are intentionally left as carp: one is asserted by the existing unit test and neither is a transport failure. No change to the transfer logic. Test plan: 1) prove t/db_dependent/Koha/Edifact/Transport.t 2) Point an EDI account at an unreachable transport and run edi_cron.pl; confirm the failure is now written to the edi log rather than only to STDERR. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk> |
||
|---|---|---|
| .. | ||
| File | ||
| File.pm | ||
| Files.pm | ||
| Line.pm | ||
| Message.pm | ||
| Order.pm | ||
| Segment.pm | ||
| Transport.pm | ||