Koha-clms/authorities
Marcel de Rooy f53b6ec248 Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority
If we got an authtypecode from the database and this value is not NULL
since the table column does not allow it, there is no need to call
GuessAuthTypeCode for empty string (read: Default framework) in the
sub get_from_authid.

Furthermore, we remove three Koha::MetadataRecord::Authority->new calls.
They are useless, since we do not pass a record. It just generates:
  No record passed at authorities/merge.pl line 96.
  Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66.
Instead we throw an ObjectNotFound exception.

Test plan:
[1] Run t/db_dependent/Koha_Authority.t
[2] Interface will be tested in the following patches.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit db35492c79)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2017-10-23 15:56:39 +02:00
..
auth_finder.pl Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
authorities-home.pl Bug 9988: Merge should have a parameter hash 2017-04-13 08:53:46 -04:00
authorities-list.pl Bug 12478: make things using SimpleSearch use the new version 2016-04-26 20:20:07 +00:00
authorities.pl Bug 17380: Add some checks around Authorities::Types->find 2017-10-23 15:56:39 +02:00
blinddetail-biblio-search.pl Bug 17118: (follow-up 15381) Fix regression when clearing a linked authority 2016-09-02 14:01:34 +00:00
detail-biblio-search.pl Bug 15381: Remove GetAuthType and GetAuthTypeCode 2015-12-31 18:59:02 +00:00
detail.pl Bug 17380: Add some checks around Authorities::Types->find 2017-10-23 15:56:39 +02:00
export.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
merge.pl Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority 2017-10-23 15:56:39 +02:00
merge_ajax.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
ysearch.pl Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00