Go to file
Nick Clemens 7a8a166bd1 Bug 26298: Don't set too_many_items_to_process if equal to limit
In the code we prepare items for display if less than or equal to the pref, but we don't allow
the edit if greater than or equal to the pref. The second case should be only 'greater than'

To test:
 1- Set MaxItemsToProcessForBatchMod to 1000
 2- Go to Reports
 3- Make a report for itemnumbers that will give you at least 1000 items (ex. SELECT itemnumber FROM items)
 4- Save and run the report
 5- In "Rows per page", choose 1000
 6- Click on "Batch operations with 1000 visible records" > Batch item modification
 7- Notice that the item modification form isn't there and that the message says "Too many items (1000): You are not allowed to edit more than 1000 items in a batch."
 8- Apply patch
 9- Restart all the things
10- Run the report again and display 1000 rows
11- Click on "Batch operations with 1000 visible records" > Batch item modification
12 - Sucess!

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit ae76d7626b)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2021-02-05 16:44:47 +01:00
C4 Bug 27204: Fix end boundary index, never return results for non-existant accountlines 2021-02-05 16:40:55 +01:00
Koha Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac 2021-02-05 16:36:28 +01:00
acqui Bug 24470: Mark a batch as 'imported' if all the bib has been imported 2021-01-11 14:06:32 +01:00
admin Bug 17364: Add ability to exclude some columns from selection for system preferences 2021-02-05 16:43:03 +01:00
api Bug 27117: Only place_holds permission is needed to adjust pickup locations 2020-12-28 14:49:39 +01:00
authorities Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
basket Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
bin Bug 20582: Turn Koha into a Mojolicious application 2020-10-06 12:00:04 +02:00
catalogue Bug 23475: Use localStorage to preserve simple search values 2020-11-30 11:45:42 +01:00
cataloguing Bug 20971: Prevent Storable::thaw to fail on LastCreatedItem 2021-01-20 10:03:12 +01:00
circ Bug 27011: Remove unused $name variable 2021-01-25 16:27:40 +01:00
clubs Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
course_reserves Bug 25898: Fix new occurrences 2020-10-15 13:56:41 +02:00
debian Bug 25245: Add plugins_nightly.pl to the default cron 2021-01-29 14:03:21 +01:00
docs Bug 7143: Update about page for new devs 2021-01-25 16:40:37 +01:00
errors Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
etc Bug 27299: Remove tokenization for phrase register/index with ICU 2021-01-20 08:28:27 +01:00
ill Bug 22818: Add generation and sending of notices 2020-11-11 08:35:10 +01:00
installer Bug 27530: Set correct dateofbirth for 'C' 2021-02-05 16:39:15 +01:00
koha-tmpl Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField 2021-02-05 16:43:52 +01:00
labels Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
members Bug 27420: Use object accessor for $attr_type->class() 2021-01-20 08:24:53 +01:00
misc Bug 11344: (QA follow-up) Fix empty section warning 2021-01-29 15:37:27 +01:00
offline_circ Bug 24083: Add support for unseen_renewals 2020-11-11 16:09:58 +01:00
opac Bug 27450: Remove password from the mandatory fields when editing details 2021-02-05 16:38:21 +01:00
patron_lists Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
patroncards Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
plugins Bug 24633: Add support for gitlab searching of plugins 2020-11-06 15:55:17 +01:00
pos Bug 24786: Update point of sale to use session register 2020-11-06 15:39:59 +01:00
reports Bug 24665: Add support for filtering by cash register 2020-11-06 15:55:17 +01:00
reserve Bug 26963: (QA follow-up) Fix cases where we expected a list 2020-11-13 14:20:11 +01:00
reviews Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
rotating_collections Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
serials Bug 26992: Fix serial issue and related items deletion on serial collection page 2020-11-20 08:16:02 +01:00
services Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
skel
…
suggestion Bug 26738: (bug 24819 follow-up) Fix manager selection 2020-11-04 12:59:32 +01:00
svc Bug 27306: Add subtitle to return-claims-table 2021-01-18 15:42:32 +01:00
t Bug 27204: Add unit tests for fine_items 2021-02-05 16:40:55 +01:00
tags Bug 24663: Remove authnotrequired if set to 0 2020-09-03 10:40:35 +02:00
tmp/modified_authorities
…
tools Bug 26298: Don't set too_many_items_to_process if equal to limit 2021-02-05 16:44:47 +01:00
virtualshelves Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
xt Bug 26971: Remove obsolete test file translatable-templates.t 2020-11-09 11:20:43 +01:00
.editorconfig Bug 24774: Set JSON indentation of 2 spaces in .editorconfig 2020-03-19 09:24:52 +00:00
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap Bug 26621: Adjust .mailmap to reduce the number of invalid authors 2020-10-15 12:56:30 +02:00
.perlcriticrc Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL Bug 26617: Update INSTALL file to include koha-testing-docker and Gitlab links 2020-10-15 12:56:30 +02:00
Koha.pm Increment version for 20.11.02 release 2021-01-22 15:18:42 +01:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 20582: Map app.psgi file and bin directory in Makefile.PL 2020-10-06 18:14:30 +02:00
README
…
README.md Bug 27092: Remove note about "synced repo" from README.md 2020-11-25 16:31:58 +01:00
README.robots
…
about.pl Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info 2021-01-07 16:29:41 +01:00
app.psgi Bug 20582: Fix PSGI file when behind a reverse proxy 2020-10-06 12:00:04 +02:00
changelanguage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
cpanfile Bug 26848: Fix Readonly dependency in cpanfile 2021-01-14 17:18:36 +01:00
fix-perl-path.PL Bug 21395: Make perlcritic happy 2020-06-29 12:37:02 +02:00
gulpfile.js Bug 27072: Don't process staff interface CSS with rtlcss 2020-11-24 21:27:59 +01:00
help.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
koha_perl_deps.pl Bug 24545: Fix license statements 2020-02-24 13:31:26 +00:00
kohaversion.pl Bug 26384: Fix executable flags 2020-09-11 09:56:56 +02:00
mainpage.pl Bug 25898: Prohibit indirect object notation 2020-10-15 12:56:30 +02:00
package.json Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00
rewrite-config.PL Bug 26290: Make Makefile.PL aware of SMTP configs 2020-10-02 15:27:18 +02:00
yarn.lock Bug 25067: Move PO file manipulation code into gulp tasks 2020-11-06 09:46:11 +01:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo