Go to file
Owen Leonard 798cc769fe Bug 13806: Sanitize inputs where creating Reports subgroup
This patch adds validation of report group and subgroup inputs so that
the user can't enter data into only one half of the group code/name
pair.

To test, apply the patch and go to Reports -> Use saved.

  - Create or edit a report which doesn't have a group or subgroup
    assigned.

  - Under "Report group," select the "or create" radio button.

  - Click the "Update SQL" button to submit the form without entering a
    group code or name. The form should require taht you enter data into
    both fields.

  - Enter data into the report group code and name fields. Add data to
    either the code or data field under "Report subgroup." You should
    not be able to submit the form without populating both.

  - Start over editing a report which doesn't have a group or subgroup
    assigned.

    - Select an existing group under "Report group."

    - Under "Report subgroup," select the "or create" option.

      - You should not be able to submit the form without adding data in
        both the code and name fields for the report subgroup.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
2019-12-20 16:45:01 +00:00
C4 Bug 24164: Copy the letter for each email 2019-12-19 22:00:24 +00:00
Koha Bug 24191: Make objects.search pass to_model to dbic_merge_sorting 2019-12-20 15:46:12 +00:00
OpenILS
…
acqui Bug 23721: Use basketgroup's name to name the CSV export file 2019-11-21 11:33:49 +00:00
admin Bug 24170: Fix sysprefs search result order 2019-12-19 22:10:33 +00:00
api/v1 Bug 23859: Make POST add the Location header on cities endpoint 2019-11-01 08:48:18 +00:00
authorities
…
basket Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
catalogue Bug 23970: Make search with "Publication date" field work at any position 2019-12-19 21:45:19 +00:00
cataloguing Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items 2019-11-08 12:56:20 +00:00
circ Bug 24106: In returns.pl, don't search for item if no barcode is provided 2019-12-19 22:06:59 +00:00
clubs
…
course_reserves Bug 21003: Removed warning and changed wording on add_items-step2.tt 2019-03-23 09:51:36 +00:00
debian Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-08 12:53:55 +00:00
docs Corrections to teams for 20.05 cycle 2019-11-29 12:10:34 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace 2019-11-08 12:53:55 +00:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 17831: DBRev 19.11.00.001 2019-12-20 14:58:04 +00:00
koha-tmpl Bug 13806: Sanitize inputs where creating Reports subgroup 2019-12-20 16:45:01 +00:00
labels Bug 21206: Replace C4::Items::GetItem 2019-02-26 13:24:07 +00:00
members Bug 24113: guarantor info lost when a duplicate is found 2019-11-27 07:51:04 +00:00
misc Update release notes for 19.11.00 release 2019-11-28 18:25:06 +00:00
offline_circ Bug 22600: Add 'interface' to accountlines 2019-04-10 19:43:11 +00:00
opac Bug 23785: Fix call get_coins on undef value in opac-search.pl 2019-12-19 22:08:37 +00:00
patron_lists
…
patroncards
…
plugins Bug 21073: (QA follow-up) Avoid unnecessary unless/else construct 2019-06-18 17:30:44 +01:00
reports Bug 24177: (QA follow-up) Fix warning 2019-12-19 21:39:58 +00:00
reserve Bug 24168: (bug 23116 follow-up) AllowHoldPolicyOverride allows a librarian to almost place a hold on an item already on hold 2019-12-10 19:52:20 +00:00
reviews
…
rotating_collections
…
serials Bug 23435: Add multiple copies of an item when receiving in serials 2019-10-17 14:59:40 +01:00
services
…
skel
…
suggestion Bug 23854: Fix failure on dates when editing a suggestion 2019-11-13 17:16:24 +00:00
svc Bug 23427: Simplify sort logic 2019-11-07 13:25:10 +00:00
t Bug 24191: Add to_model param to _build_order_atom and dbic_merge_sorting 2019-12-20 15:45:55 +00:00
tags Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
tmp/modified_authorities
…
tools Bug 23800: (QA follow-up) Remove useless line 2019-12-20 16:18:43 +00:00
virtualshelves Bug 11529: Add templates for biblio title display. Unify display. 2019-08-05 15:03:19 +01:00
xt
…
.editorconfig
…
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore
…
.htaccess
…
.mailmap
…
.scss-lint.yml
…
INSTALL
…
Koha.pm Bug 17831: DBRev 19.11.00.001 2019-12-20 14:58:04 +00:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 23834: (RM follow-up) Add new file to Makefile.PL 2019-11-04 10:10:04 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 23655: Restore debian Jessie support 2019-10-26 12:07:49 +01:00
changelanguage.pl
…
fix-perl-path.PL
…
gulpfile.js
…
help.pl
…
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 21907: Fix article requests count for non-superlibrarians 2019-02-04 14:50:40 +00:00
package.json Bug 23025: security vulnerability detected in fstream < 1.0.12 defined in yarn.lock 2019-11-27 11:30:17 +00:00
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 23025: Update yarn.lock 2019-11-27 11:30:17 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo