Koha-clms/t/db_dependent
Kyle M Hall 78eba2f974 Bug 10272: make CheckReserves respect ReservesControlBranch
CheckReserves was using the CircControl system preference to determine what
patrons an item can fill a hold for. It should be using ReservesControlBranch
instead.

Test Plan:
1) Set ReservesControlBranch to "item's home library".

2) Create an item at Library A, place holds for it for patrons at
   Library B, Library C, and Library A in that order,
   for pickup at the patrons home library.

3) Make sure the holds policy for Library A is set to
   Hold Policy = "From home library" and
   Return Policy = "Item returns home".

   Make sure the holds policies for the other libraries are set to
   Hold Policy = "From any library".

4) Check the item in at Library C, the hold for the patron at Library B
   should pop up, even though it's in violation of the circulation rules.
   Don't click the confirm button!

5) Apply this patch, and reload the page,
   now the hold listed should be for the last hold,
   the hold for the patron at Library A, which is correct.

This patch adds the subroutine C4::Reserves::GetReservesControlBranch as
an equivilent to C4::Circulation::_GetCircControlBranch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed POD so that arguments and explanation match (C<$item>).
Also tested opac-reserves.pl for regressions.
Passes all tests, QA script, and Reserves.t.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
2013-09-08 01:20:01 +00:00
..
Acquisition Bug 10275: Use a transaction for OrderFromSubscription.t 2013-07-16 14:20:38 +00:00
LDAP
…
Labels Bug 7215 : The Module changed, but the tests weren't updated to reflect that 2011-12-13 14:25:46 +01:00
Members Bug 10481: Unit tests for C4::Members::AddEnrolmentFeeIfNeeded 2013-08-16 15:08:41 +00:00
Record 7661 Followup for resolving moved Record test 2012-03-14 14:59:46 +01:00
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-09-05 10:12:06 +02:00
data/zebraexport Revert "Bug 7167: Adds Unit tests for C4::Update::Database" 2012-12-27 14:02:52 -05:00
www Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
00-strict.t Bug 8383: Add test to check that Perl scripts compile 2012-07-10 11:13:40 +02:00
Accounts.t Bug 5327 Made test file for Accounts.pm 2011-01-20 19:57:50 +13:00
Acquisition.t bug 10556: regression test for setting deliverytime when adding vendor 2013-07-16 14:55:09 +00:00
Amazon.t Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent 2011-01-19 13:38:52 +13:00
Auth.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
Auth_ParseSearchHistoryCookie.t move Auth_ParseSearchHistoryCookie.t to db_dependent directory 2013-07-28 19:42:51 +00:00
Auth_with_cas.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
AuthoritiesMarc.t Bug 8890 - move two more db dependent tests 2012-10-24 17:52:42 +02:00
BackgroundJob.t bug 5327 add tests for C4/BackgroundJob.pm 2012-01-17 15:31:56 +01:00
Barcodes.t Bug 6448 [2/3] Barcodes::EAN13 autoBarcode 2012-08-02 18:41:44 +02:00
Biblio.t Bug 7576: Add ISSN to SearchForTitleIn preference 2012-02-27 11:44:20 +01:00
Bookseller.t Bug 10528: add unit tests for C4::Bookseller.pm 2013-08-26 16:28:17 +00:00
Branch.t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
Budgets.t Bug 9937: Add new unit tests for new routines (introduced by bug 5343) 2013-03-30 17:05:15 -04:00
Circulation.t Bug 10719: (follow-up) clear existing loans before running circ tests 2013-08-26 14:49:17 +00:00
Circulation_Issuingrule.t Bug 10767: (follow-up) remove FIXME comments 2013-08-28 14:44:01 +00:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_issuingrules.t Bug 10298: Followup: Adapt existing code 2013-08-09 16:35:43 +00:00
Circulation_transfers.t Bug 10699: add explicit return value for DeleteBranchTransferLimits() 2013-08-28 15:23:51 +00:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
Context.t Bug 9191: updatedatabase.pl should only run updates up to the current version 2012-12-11 08:19:00 -05:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 5327 - move another test around 2012-02-01 18:15:21 +01:00
External_BakerTaylor.t Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm 2011-12-07 16:17:05 +01:00
Heading_MARC21.t Merge remote-tracking branch 'origin/new/bug_7284' 2012-04-04 18:18:26 +02:00
Holds.t bug 2394: regression test for canreservefromotherbranches 2013-08-09 17:44:17 +00:00
HoldsQueue.t Bug 10628: make sure AutomaticItemReturn doesn't prevent holds queue from filling local holds with local items 2013-08-20 15:31:38 +00:00
Holidays.t Holidays Test Plan - DB Dependent 2012-10-01 16:44:02 +02:00
Items.t Bug 5327 : Fixing a typo in the test that was causing a false fail 2012-09-07 14:31:59 +02:00
KitchenSinkPlugin.kpz Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests 2013-03-20 14:50:38 -04:00
Koha.t Bug 10656: add regression test 2013-09-06 16:47:30 +00:00
Koha_Authority.t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
Koha_borrower_modifications.t Bug 7067 - QA Followup - Fix failing tests 2012-12-14 08:09:01 -05:00
Koha_template_plugin_KohaBranchName.t Bug 10494: test cases for the KohaBranchName plugin 2013-06-30 18:44:57 -07:00
Koha_template_plugin_KohaDates.t Bug 929 : Follow up, shifting test 2012-02-07 16:42:22 +01:00
Linker_FirstMatch.t Bug 7724: Skip Linker test if Zebra isn't set up 2012-03-20 11:21:10 +01:00
Log.t Fixing a broken test 2011-09-26 11:55:58 +13:00
Members.t Bug 10080 - Change system pref IndependantBranches to IndependentBranches 2013-05-22 07:58:23 -07:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
Plugins.t Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable 2013-03-22 21:52:41 -04:00
Ratings.t Bug 5668 - Star ratings in the opac 2012-04-10 14:40:49 +02:00
Record.t Bug 7141 : Changing test to match new formatting of xsl style sheet 2011-12-08 10:51:25 +01:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
ReportsGuided.t Bug 9659 follow-up: correct syntax for older Perl 2013-04-26 21:32:49 -04:00
Reports_Guided.t Bug 10761: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-21 16:29:18 +00:00
Reserves.t Bug 10272: make CheckReserves respect ReservesControlBranch 2013-09-08 01:20:01 +00:00
RotatingCollections.t Bug 10653: (follow-up) minor tweaks to RotatingCollections tests 2013-08-16 16:09:13 +00:00
SIP_ILS.t Bug 5327 : Removing a broken test 2012-02-13 15:04:43 +01:00
SQLHelper.t Bug 5327 : Fixing unit test for SQLHelper.pm 2011-12-07 16:17:10 +01:00
Search.t Bug 10741: (follow-up) add regression test 2013-08-23 15:58:01 +00:00
Search_SearchHistory.t Bug 10361: (follow-up) add tests for search history functions 2013-09-04 14:22:50 +00:00
Serials.t Bug 5337 : Upping the count of the unit tests 2012-06-14 15:43:08 +02:00
Serials_2.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
Service.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
SuggestionEngine_ExplodedTerms.t Bug 8846 conflict resolution: correct path 2012-11-01 08:41:30 -04:00
Suggestions.t Bug 5346: Linking suggestions and orders. 2012-02-17 10:27:52 +01:00
Tags.t Bug 7642 - fix the lost display of tag sizes 2012-10-01 17:38:27 +02:00
UploadedFile.t t/UploadedFile, updated comment 2011-12-07 16:37:31 +01:00
VirtualShelves.t Bug 10499: VirtualShelves.t - wrap tests in a database transaction 2013-07-16 14:17:27 +00:00
VirtualShelves_Page.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
XISBN.t Bug 10539: Followup for removing KohaTest unit tests 2013-09-05 15:06:05 +00:00
check_sysprefs.t Bug 8353 follow-up: Perltidy new test 2012-07-13 14:42:52 +02:00
rollingloans.t Bug 5549 : Fixing the test to only run if the test data exists 2012-03-27 09:18:37 +02:00
sysprefs.t Bug 6132: Add unit test for system preferences 2012-01-16 14:52:24 +01:00
zebra_config.pl bug 8649: create a temp directory for Zebra for C4::Search tests 2012-09-13 11:55:48 +02:00