Koha-clms/circ
Jonathan Druart 34565e7f7d Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen
If CircAutoPrintQuickSlip is set to clear screen, the $borrowernumber variable
is reset but $borrower.
In 16.11.x and before that causes the app to crash, because
$borrower->{flags} is set to a hashref by GetMemberDetails, if
$borrowernumber is set.

This case is better handled in master (17.05) but side-effects could
happen: if $borrowernumber is reset, $borrower should be reset too.

The way to drive this behaviour is terrible and lot of things should be
done to clean this area. This patch is a quick and easy fix to make it
backportable easily.

Test plan:
On master, no change expected
On 16.11 and before:
0. Set CircAutoPrintQuickSlip=clear screen
1. Create a new patron
2. Set permission for this patron to 'reservesforothers' (or something
else).
3. Go on the circulation tab
4. Do not fill the barcode input and submit
=> Without this patch you will get an error
Can't use string ("64") as a HASH ref while "strict refs"....
=> With this patch apply you will get a blank screen (expected
behaviour).

I would recommend to test this patch with the other value of
CircAutoPrintQuickSlip as well
2017-04-02 18:45:41 +02:00
..
add_message.pl Bug 3669: Remove parameters passed to action of form 2016-06-24 13:20:14 +00:00
article-request-slip.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
article-requests.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
bookcount.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
branchoverdues.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
branchtransfers.pl Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib 2016-10-11 13:11:55 +00:00
circulation-home.pl Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworkinfo 2016-10-28 12:05:00 +00:00
circulation.pl Bug 18022: Fix possible crash if CircAutoPrintQuickSlip=clear screen 2017-04-02 18:45:41 +02:00
del_message.pl Bug 15632: Koha::Patron::Messages - Remove DeleteMessage 2016-03-03 21:22:13 +00:00
hold-transfer-slip.pl Bug 13482: Prevent race condition on printing a ReserveSlip 2015-04-22 16:32:15 -03:00
offline-mf.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
offline.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
on-site_checkouts.pl Bug 11201: Add a in-house use list pages 2015-03-31 11:30:55 -03:00
overdue.pl Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch 2016-09-08 14:36:04 +00:00
pendingreserves.pl Bug 16991: Add subtitle to holds to pull report 2016-11-02 10:58:10 +00:00
renew.pl Bug 15581: Display the latest auto renew date possible when renewing manually 2016-11-02 10:28:57 +00:00
request-article.pl Bug 14610 - Add and update scripts 2016-10-26 12:15:14 +00:00
reserveratios.pl Bug 15672: (follow-up) Show descriptions instead of codes on the hold ratios report 2016-03-23 21:07:04 +00:00
returns.pl Bug 17940: (follow-up 14695) Fix - Mark holds as waiting when transfer is done 2017-02-14 20:33:19 +01:00
selectbranchprinter.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
transfer-slip.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
transferstoreceive.pl Bug 15758: Koha::Libraries - Remove GetBranches 2016-09-08 14:36:03 +00:00
view_holdsqueue.pl Bug 15758: Koha::Libraries - Remove GetBranchesLoop 2016-09-08 14:36:02 +00:00
waitingreserves.pl Bug 17010 - Canceling a hold awaiting pickup no longer alerts librarian about next hold 2016-09-15 13:34:44 +00:00
ypattrodue-attr-search-authvalue.pl Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
ysearch.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00