Koha-clms/t/db_dependent
Yohann Dufour 1b88702918 Bug 12487: SQLHelper replacement - C4::Contract
With this patch, the subroutines GetContract, GetContracts, AddContract, ModContract and DelContract uses DBIx::Class instead of C4::SQLHelper

Test plan:
1) Apply the patch
2) Execute the unit tests by launching:
prove t/db_dependent/Contract.t
3) The command has to be a success :
t/db_dependent/Contract.t .. ok
All tests successful.
Files=1, Tests=43,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.49 cusr  0.05 csys =  1.59 CPU)
Result: PASS

4) Log on with a superlibrarian permission
5) Go on the page acqui/supplier.pl (Acquisitions > Button "New vendor")
6) Record a vendor with a nonzero "name"
7) Go on the page admin/aqcontract.pl (click on the "Contracts" item in the menu)
8) Click on the button "New" > "Contract" and record a new one
9) Verify the displayed data are correct about the contract
10) "Edit" the contract with different values and verify the data are updated
11) Click on "Delete" in order to delete the contract, verify the displayed data are correct but cancel the operation
12) Click on "New" > "Basket" and verify there is the created contract in field "Contract", then record a basket by selectioning the created contract
13) Verify the contract name displayed is correct
14) Record an active budget and a fund linked to this budget
15) Go on the new basket (Home > Acquisitions > Search the created vendor)
16) Click on "Add to basket" then "From a new (empty) record" and verify the displayed contract name is correct, then cancel
17) Click on "Delete this basket"
18) Click on "Contracts" (in the left menu) in order to go on aqcontract.pl, then "Delete" the created contract
19) The contract is not displayed anymore in the vendor page

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Work as described following test plan.
Tested on top of Bug 12493
Tests pass
No koha-qa errors

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
2014-07-30 10:44:11 -03:00
..
Acquisition Bug 12493: (followup) remove unnecessary output message 2014-07-30 10:43:01 -03:00
Circulation Bug 12470: (followup) License statement missing 2014-07-14 08:57:06 -03:00
Holds Bug 12086: qa-followup: remove warning on launching unit tests 2014-06-23 15:07:21 -03:00
Koha Bug 11279: (follow-up) remove unnecessary check on number of quotes 2013-12-19 15:06:39 +00:00
LDAP
…
Labels Bug 8375: (follow-up) adjust another test case for change in fonts 2014-05-06 21:24:40 +00:00
Members Bug 12457: Allow UT on a non empty database 2014-07-30 09:50:35 -03:00
Record 7661 Followup for resolving moved Record test 2012-03-14 14:59:46 +01:00
Reports Bug 8594 - prevent the report system from breaking some subqueries 2012-09-05 10:12:06 +02:00
Search Bug 10807: Add an authority search history for the OPAC 2014-05-05 02:32:27 +00:00
Serials Bug 12003: Do not calculate next pubdate for irregular subscriptions 2014-04-18 20:57:51 +00:00
Utils Bug 12595: (regression tests) 2014-07-18 12:36:46 -03:00
XSLT_Handler Bug 11826: Add unit tests for Koha::XSLT_Handler 2014-05-26 03:52:45 +00:00
data Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
www Bug 8300: Add mechanized unit test for batch import 2013-05-01 07:57:11 -04:00
00-strict.t Bug 7844: (follow-up) don't test koha.psgi for ability to compile (yet) 2014-04-29 19:34:23 +00:00
Accounts.t Bug 5327 Made test file for Accounts.pm 2011-01-20 19:57:50 +13:00
Acquisition.t Bug 11169: (follow-up) add more unit tests 2014-06-15 11:12:34 -03:00
Amazon.t Bug 5327 - Now we are doing db calls, we need to shift this to t/db_dependent 2011-01-19 13:38:52 +13:00
Auth.t Bug 11349: Change .tmpl -> .tt in scripts using templates 2014-07-17 11:05:49 -03:00
Auth_with_cas.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
AuthoritiesMarc.t Bug 7442: (follow-up) adjust UNIMARC test case to match change in BuildSummary() 2014-05-05 04:18:22 +00:00
BackgroundJob.t Bug 10601: (follow-up) unit tests for new ->set() and ->get() 2013-09-18 17:21:47 +00:00
Barcodes.t Bug 6448 [2/3] Barcodes::EAN13 autoBarcode 2012-08-02 18:41:44 +02:00
Biblio.t Bug 11912: (follow-up) Use the common way to mock syspref 2014-04-19 18:41:43 +00:00
Bookseller.t Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class 2014-07-03 14:24:58 -03:00
Borrower_Debarments.t Bug 12416: add new tests of DelUniqueDebarment 2014-06-22 19:59:04 -03:00
Borrower_Files.t Bug 12417: adding the units tests of the module Koha::Borrower::Files.pm 2014-07-11 16:16:11 -03:00
Branch.t Bug 10508: (follow-up) remove Perl 5.14 construct 2013-08-28 14:24:34 +00:00
Budgets.t Bug 12164: On closing budget period, move unspent amount 2014-07-24 14:17:24 -03:00
Category.t Bug 11543: (followup) add one more test 2014-01-15 19:58:30 +00:00
Circulation.t Bug 12596: (followup) add reference to bug # and license note 2014-07-25 10:06:42 -03:00
Circulation_Branch.t Bug 10683: (follow-up) improvements to the unit tests 2013-10-09 03:51:55 +00:00
Circulation_Issuingrule.t Bug 12406: adding the column maxsuspensiondays in the tests 2014-06-18 15:26:32 -03:00
Circulation_OfflineOperation.t Bug 10710: (follow-up) perltidy new code 2013-08-28 14:52:43 +00:00
Circulation_issue.t Bug 11629: (folllow-up) fix various issues 2014-05-26 03:25:22 +00:00
Circulation_issuingrules.t Bug 11934: (follow-up) tidy up whitespace 2014-03-13 15:18:49 +00:00
Circulation_transfers.t Bug 11470: fix occassional spurious test failure in Circulation_transfers.t 2014-01-06 05:31:21 +00:00
ClassSource.t Bug 10644: (follow-up) remove inadvertant dependence on Perl 5.14 2013-08-09 18:53:20 +00:00
Context.t Bug 11701: (follow-up) move unit tests to t/db_dependent 2014-03-25 14:41:07 +00:00
Contract.t Bug 12487: SQLHelper replacement - C4::Contract 2014-07-30 10:44:11 -03:00
CourseReserves.t Bug 10332: further improvements to course reserves tests 2013-06-18 16:40:43 -07:00
Csv.t Bug 10853: (follow-up) expand unit tests for C4::Csv 2013-10-11 03:25:42 +00:00
External_BakerTaylor.t Bug 5327: Unit tests for C4/Exteral/BakerTaylor.pm 2011-12-07 16:17:05 +01:00
Heading_MARC21.t Merge remote-tracking branch 'origin/new/bug_7284' 2012-04-04 18:18:26 +02:00
Holds.t Bug 9532: add regression test 2014-05-05 17:17:36 +00:00
HoldsQueue.t Bug 11258: fix another case where holds queue made transfer requests that contradict the library holds policy 2014-04-18 15:23:23 +00:00
Holidays.t Bug 11112: (follow-up) repair Koha::Calendar->add_holiday() 2013-12-10 18:19:15 +00:00
ILSDI_Services.t Bug 11891: set up tests to require that Koha::Database uses same DB handle as C4::Context 2014-06-19 11:54:45 -03:00
Installer.t Bug 11541: (follow-up) move Installer.t to t/db_dependent 2014-01-14 21:43:56 +00:00
Items.t Bug 12583: DelItem prototype - prefer hashref 2014-07-25 19:06:12 -03:00
Items_DelItem.t Bug 12583: (followup) rename new test file 2014-07-26 10:17:09 -03:00
KitchenSinkPlugin.kpz Bug 7804 - Add Koha Plugin System - QA Followup 3 - Additional Unit Tests 2013-03-20 14:50:38 -04:00
Koha.t Bug 10078: (follow-up) add regression test 2013-10-30 05:02:45 +00:00
Koha_Authority.t Bug 5202: merge authorities from the authority file and reservoir 2013-10-10 21:32:27 +00:00
Koha_Database.t Bug 11906: regression test for using DBIC to store & fetch UTF8 strings 2014-03-27 14:44:39 +00:00
Koha_Misc_Files.t Bug 3050: QA follow-up 2014-05-25 21:15:03 +00:00
Koha_borrower_modifications.t Bug 7067 - QA Followup - Fix failing tests 2012-12-14 08:09:01 -05:00
Koha_template_plugin_Branches.t Bug 11779: (follow-up) improve GetLoggedInBranchcode() and add test cases 2014-02-19 16:40:06 +00:00
Koha_template_plugin_KohaDates.t Bug 929 : Follow up, shifting test 2012-02-07 16:42:22 +01:00
Languages.t Bug 7841: add a direct regression test 2014-05-19 16:40:23 +00:00
Letters.t Bug 12499: adding units tests for C4::Letters 2014-07-07 10:18:42 -03:00
Linker_FirstMatch.t Bug 7724: Skip Linker test if Zebra isn't set up 2012-03-20 11:21:10 +01:00
Log.t Fixing a broken test 2011-09-26 11:55:58 +13:00
MarcModificationTemplates.t Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines 2013-10-31 22:50:11 +00:00
Members.t Bug 12457: Adding unit tests for Members.pm 2014-07-30 09:50:27 -03:00
Members_Attributes.t Bug 12427: Allow execution of UTs on a DB with issues 2014-06-24 09:43:04 -03:00
Members_columns.t Bug 7785: (follow-up) standardize POD 2013-08-13 16:15:30 +00:00
MungeMarcPrice.t Bug 9593: (follow-up) don't make currency.isocode required 2014-05-04 22:21:17 +00:00
NewsChannels.t Bug 7567: (follow-up) make tests of get_opac_new more readable 2014-04-07 18:14:20 +00:00
Overdues.t Bug 11696: ensure that print overdue notices use the print template 2014-05-02 20:29:21 +00:00
PatronLists.t Bug 10565: (follow-up) don't assume borrowernumber 1 exists in unit test 2013-10-14 21:30:34 +00:00
Plugins.t Bug 9909: Don't install KitchenSink plugin if plugin dir isn't writable 2013-03-22 21:52:41 -04:00
Ratings.t Bug 5668 - Star ratings in the opac 2012-04-10 14:40:49 +02:00
Record.t Bug 11826: Use XSLT handler object in showmarc, Record.pm 2014-05-26 03:52:45 +00:00
RecordProcessor_EmbedSeeFromHeadings.t Bug 7417: Include see from references in bibliographic searches 2012-09-13 14:19:28 +02:00
Reports.t Bug 5327: Shifting a db dependent test to the right place 2012-02-01 18:15:19 +01:00
ReportsGuided.t Bug 9659 follow-up: correct syntax for older Perl 2013-04-26 21:32:49 -04:00
Reports_Guided.t Bug 12214: add regression test for reporting error when running report with SQL error 2014-05-09 14:39:54 +00:00
Reserves.t Bug 10845: (follow-up) update how a test case counts print hold available notices 2014-05-02 20:29:19 +00:00
RotatingCollections.t Bug 10653: (follow-up) minor tweaks to RotatingCollections tests 2013-08-16 16:09:13 +00:00
SIP_ILS.t Bug 5327 : Removing a broken test 2012-02-13 15:04:43 +01:00
SQLHelper.t Bug 5327 : Fixing unit test for SQLHelper.pm 2011-12-07 16:17:10 +01:00
Search.t Bug 12419: (QA followup) regression tests 2014-06-30 15:57:23 -03:00
Search_SearchHistory.t Bug 10807: (follow-up) remove comment about routine that is no longer present 2014-05-05 02:58:29 +00:00
Serials.t Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class 2014-07-03 14:24:58 -03:00
Serials_2.t Bug 12482: removing the use of the module C4::SQLHelper.pm, it is replaced by DBIx::Class 2014-07-03 14:24:58 -03:00
Service.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
ShelfBrowser.t Bug 10856: Improve the previous and next items on the shelf browser 2013-10-04 15:56:35 +00:00
Stats.t Bug 11230 - Refactor C4::Stats::UpdateStats and add UT 2014-07-27 11:29:28 -03:00
SuggestionEngine_ExplodedTerms.t Bug 8846 conflict resolution: correct path 2012-11-01 08:41:30 -04:00
Suggestions.t Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table 2014-07-29 16:24:00 -03:00
Tags.t Bug 7642 - fix the lost display of tag sizes 2012-10-01 17:38:27 +02:00
UploadedFile.t t/UploadedFile, updated comment 2011-12-07 16:37:31 +01:00
VirtualShelves.t Bug 9032: (follow-up) restore documented intepretation of virtualshelfshares.sharedate 2014-04-20 22:52:21 +00:00
VirtualShelves_Page.t Bug 5477 [SIGN-OFF] Fix test cases that require database access 2011-01-29 17:02:31 +13:00
XISBN.t Bug 11439: (follow-up) adjust for change in list returned by OCLC XISBN 2014-01-30 15:48:48 +00:00
XSLT_Handler.t Bug 11826: Add unit tests for Koha::XSLT_Handler 2014-05-26 03:52:45 +00:00
check_sysprefs.t Bug 8353 follow-up: Perltidy new test 2012-07-13 14:42:52 +02:00
rollingloans.t Bug 5549 : Fixing the test to only run if the test data exists 2012-03-27 09:18:37 +02:00
sysprefs.t Bug 10325: (follow-up) add test for overriding system preferences 2013-09-08 02:28:45 +00:00
zebra_config.pl Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00