Nick Clemens cae75b64dd Bug 17798: Confirm hold when printing slip from another patron's account ... This patch adds a few pieces of information to the print slip button and makes the code confirm the hold As we are printing before the confirm, we also add the ability to pass in the itemnumber to 'ReserveSlip' This is slightly hacky, however, I don't see another way to allow printing without an additional page reload. To test: 1 - Place a title level hold for patron A, for delivery to library B 2 - Attempt to checkout an item from the record above to Patron B from library A 3 - You receive an alert about the hold 4 - Click "Don't check out, confirm hold, and print slip" 5 - Confirm the slip looks correct and has item info 6 - Confirm that item is in transit to fill hold 7 - Revert transit status 8 - Attempt to checkout the item to Patron B from Library B 9 - Click "Don't check out, confirm hold, and print slip" 10 - Confirm slip is correct 11 - Confirm item is marked waiting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> (cherry picked from commit 3ec73d80e2) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit 96442d7ac7) Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>		2023-11-14 13:42:15 -01:00
..
Acquisition	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Biblio	Bug 18984: Remove NORMARC support	2021-10-07 15:36:40 +02:00
Budgets	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Circulation	Bug 28931: Use EXPORT_OK from Koha::DateUtils	2021-10-07 11:01:05 +02:00
External	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Koha	Bug 31393: Tidy	2023-11-13 15:28:46 +00:00
Members	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Number	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
SIP	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Search	Bug 34969: Remove unneeded module from buildQuery.t	2023-10-17 17:11:32 +00:00
Serials	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Test	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
cypress	Bug 33606: Add a erm/config route to retrieve the ERM config needed for the Vue app	2023-11-13 15:10:55 +00:00
data	Bug 31393: Koha::Config: handle the special case for 'content' attribute	2023-11-13 15:28:46 +00:00
db_dependent	Bug 17798: Confirm hold when printing slip from another patron's account	2023-11-14 13:42:15 -01:00
edi_testfiles	…
etc	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
lib	Bug 33718: Fix the mock of Koha::Config->get in mock_config	2023-06-07 10:16:07 +00:00
00-check-atomic-updates.t	Bug 31108: rename ./t/00-check-atomic-updates.pl extension to *.t	2022-07-06 16:40:51 -03:00
00-deprecated.t	…
00-load.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-merge-conflict-markers.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
00-testcritic.t	Bug 34911: Test files from HEAD instead of 'master'	2023-10-17 16:56:23 +00:00
00-valid-xml.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Auth.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Auth_with_shibboleth.t	Bug 31651: Adjust tests	2023-07-18 10:45:32 +00:00
AuthoritiesMarc_MARC21.t	Bug 31023: Unit tests	2022-09-07 13:52:35 -07:00
AuthoritiesMarc_UNIMARC.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Barcodes_EAN13.t	…
Barcodes_annual.t	…
Barcodes_hbyymmincr.t	…
Barcodes_incremental.t	…
Biblio.t	Bug 29697: Use flag embed_items	2022-07-22 15:24:11 -03:00
Biblio2.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Budgets.t	…
Charset.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Circulation_barcodedecode.t	Bug 30409: (QA follow-up) Avoid uninitialized variable warnings	2022-06-14 08:26:58 -03:00
ClassSortRoutine.t	…
ClassSortRoutine_Dewey.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
ClassSortRoutine_Generic.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
ClassSortRoutine_LCC.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
ClassSource.t	…
Context.t	Bug 32478: (QA follow-up) Keep current hashref behavior	2023-07-18 08:58:45 +00:00
Contract.t	…
CookieManager.t	Bug 31250: (QA follow-up) The future will be easier	2022-09-12 15:34:11 -03:00
Creators.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
DateUtils.t	Bug 30717: (QA follow-up) Move to module	2022-05-13 15:41:55 -10:00
EdiInvoice.t	Bug 18267: Refactored Edifact Price Calculations	2020-11-16 13:46:48 +01:00
EdiTransport.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Edifact.t	Bug 30135: (follow-up) Rename accessor in failing test	2022-04-14 11:43:43 +01:00
Ediorder.t	Bug 31134: Mock EdifactLSQ for t/Edifact.t	2022-07-18 10:20:44 -03:00
Ediordrsp.t	…
Form_MessagingPreferences.t	…
HtmlTags.t	…
ImportBatch.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Installer_PerlModules.t	Bug 30731: Unit tests	2022-06-01 16:15:25 -03:00
ItemCirculationAlertPreference.t	…
Koha.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Koha_MetadataRecord.t	Bug 30813: (follow-up) Fix tests import	2022-06-08 13:41:14 -03:00
Koha_SearchEngine_Elasticsearch_Browse.t	…
Koha_Template_Plugin_Cache.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Koha_Template_Plugin_HtmlId.t	Bug 27336: Sanitize correctly HTML id	2021-01-11 10:27:37 +01:00
Koha_Template_Plugin_Koha.t	Bug 31401: (QA follow-up) Remove Koha.ArePluginsEnabled, it is no longer needed	2022-09-07 13:55:37 -07:00
Koha_Util_FrameworkPlugin.t	…
Koha_Util_MARC.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Koha_XSLT_HTTPS.t	Bug 12758: Introduce Koha::XSLT::HTTPS	2022-11-09 09:52:17 -03:00
Labels.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Labels_split_Regex.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Labels_split_ccn.t	Bug 30110: Fix concatenation during assignements	2022-03-24 14:22:10 -10:00
Labels_split_ddcn.t	Bug 30110: Fix concatenation during assignements	2022-03-24 14:22:10 -10:00
Labels_split_lccn.t	Bug 30110: Fix concatenation during assignements	2022-03-24 14:22:10 -10:00
Languages.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Logger.t	Bug 32979: Skip test if running as root	2023-02-24 08:16:01 +00:00
Makefile.t	Bug 31528: (QA follow-up) Exclude .stylelintrc.json in Makefile.t	2022-10-03 09:54:34 -03:00
Matcher.t	Bug 28290: (follow-up) Unit test	2022-09-07 13:50:37 -07:00
Members_Messaging.t	…
OpenLibrarySearch.t	Bug 26384: Fix executable flags	2020-09-11 09:56:56 +02:00
Output.t	Bug 30524: Unit tests	2023-07-28 11:14:15 +00:00
Output_JSONStream.t	Bug 25898: Prohibit indirect object notation	2020-10-15 12:56:30 +02:00
Patroncards.t	…
Patroncards_Batch.t	…
Patroncards_Lib.t	…
Patroncards_Patroncard.t	…
Patroncards_Profile.t	…
Patroncards_Template.t	…
RecordProcessor.t	…
Ris.t	…
SMS.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Scheduler.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Scrubber.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Search.t	Bug 34968: Remove unneeded module from Search.t	2023-10-17 17:11:32 +00:00
Search_PazPar2.t	…
SimpleMARC.t	Bug 31644: (QA follow-up) Add two missing shebang lines	2022-10-24 11:53:19 -03:00
SocialData.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Stats.t	…
SuggestionEngine.t	…
SuggestionEngine_AuthorityFile.t	Bug 34970: Remove most modules from SuggestionEngine_AuthorityFile.t	2023-10-17 17:11:31 +00:00
TmplToken.t	Bug 17600: Standardize our EXPORT_OK	2021-07-16 08:58:47 +02:00
Token.t	Bug 34163: Handle both anonymous userenv when generating CSRF tokens	2023-09-15 10:19:53 +00:00
XSLT.t	…
dummy.t	…
template_filters.t	Bug 29350: Don't need to escape the 'delete' TT methods	2021-11-02 15:58:08 +01:00
timezones.t	Bug 28306: Allow to query database with minimal memory footprint	2021-08-31 10:27:52 +02:00