Koha-clms/opac
Fridolin Somers 19d0de6597 Bug 17367 - Showing all items must keep show holdings tab in OPAC details
In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab.
You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1.
Also you can choose which tab is shown by default using syspref opacSerialDefaultTab.

The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items.

This patch corrects by forcing holdings tab when arg viewallitems is defined.

Test plan :
- Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref)
- Select "Subscriptions tab" for syspref opacSerialDefaultTab
- Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx
=> You see Subscriptions tab selected
- Click on Holdings tab
=> You see no items but a link "Click here to view them all"
- Click on this link
=> Without patch you see Subscriptions tab selected
=> Wih patch you see Holdings tab selected and the items

Signed-off-by: Juliette <juliette.levast@iepg.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit f1298dc782)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 2a62a9a18c)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
2016-10-24 12:34:34 +02:00
..
errors Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
rss adding file just for creating the rss directory 2007-08-02 08:50:43 +00:00
sco Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page 2016-05-09 10:39:17 +02:00
svc Bug 17392 - opac/svc/overdrive_proxy is not plack safe 2016-10-24 12:00:30 +02:00
ilsdi.pl Bug 16476: Do not call CGI->param in list context, some more 2016-05-16 19:16:03 +02:00
maintenance.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
oai.pl Bug 15946 Valid namespace for OAI marcxml schema (3.22/3.20) 2016-03-23 09:56:12 +01:00
opac-ISBDdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-MARCdetail.pl Bug 15382: 245$a visibility constraints not respected in opac-MARCdetail.pl 2015-12-31 14:03:23 +01:00
opac-account.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-addbybiblionumber.pl Bug 16518: Fix Plack variable scoping problem in opac-addbybiblionumber.pl 2016-06-16 10:27:30 +02:00
opac-alert-subscribe.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-authorities-home.pl Bug 2735: Fix authority search pagination at the OPAC 2016-08-17 11:29:06 +02:00
opac-authoritiesdetail.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-basket.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-blocked.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-browser.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-23 17:39:21 +02:00
opac-course-details.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-course-reserves.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
opac-detail.pl Bug 17367 - Showing all items must keep show holdings tab in OPAC details 2016-10-24 12:34:34 +02:00
opac-discharge.pl Bug 16464: Add FIXME 2016-09-16 09:28:32 +02:00
opac-downloadcart.pl Bug 14544: Get rid of C4::VirtualShelves and C4::VirtualShelves::Page 2015-11-05 09:58:02 -03:00
opac-downloadshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-04 22:22:29 +01:00
opac-export.pl Bug 16578: Fix wide character errors in opac-export.pl 2016-06-16 10:44:32 +02:00
opac-ics.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-idref.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
opac-image.pl Bug 16154: CGI->multi_param - Manual changes 2016-05-16 14:38:57 +02:00
opac-imageviewer.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-main.pl Bug 15613: Fix 2 other occurrences of paramter vs parameter 2016-01-29 15:59:43 +01:00
opac-memberentry.pl Fix use of non-existent variable $borrower 2016-08-25 10:30:29 +02:00
opac-messaging.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-modrequest-suspend.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-modrequest.pl Bug 7976: Remove the borrow permission 2015-06-05 13:43:34 -03:00
opac-mymessages.pl Bug 5371: Force no caching for private pages at the OPAC 2015-10-02 11:06:17 -03:00
opac-news-rss.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
opac-overdrive-search.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-passwd.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-patron-image.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-privacy.pl Bug 15344: Remove some other calls of GetMemberDetails from pl scripts 2015-12-31 10:29:16 +01:00
opac-ratings-ajax.pl Bug 14553: Silencing warn triggered when clearing item rating on OPAC 2015-11-11 11:08:50 -03:00
opac-ratings.pl Bug 16179: Do not crash if "rate me" is clicked and not rate selected 2016-04-21 10:14:07 +02:00
opac-readingrecord.pl Bug 14100: Fix 3 occurrences more 2015-10-27 12:34:07 -03:00
opac-registration-verify.pl Bug 11693: Default emailing preferences not loaded for self registering patron 2015-07-24 13:44:39 -03:00
opac-renew.pl Bug 16154: CGI->multi_param - Declare a list 2016-05-16 14:38:51 +02:00
opac-reserve.pl Bug 15375 [QA Followup] - Fix non-functional restriction message and date 2016-01-29 16:06:33 +01:00
opac-restrictedpage.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-16 11:37:09 +02:00
opac-retrieve-file.pl Bug 14321: Integrate Upload.pm into Koha 2015-09-25 12:02:52 -03:00
opac-review.pl Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
opac-search-history.pl Bug 16593: Do not allow patrons to delete search history of others patrons 2016-08-16 14:22:08 +02:00
opac-search.pl Bug 16154: CGI->multi_param - Assign a list 2016-05-16 14:42:51 +02:00
opac-sendbasket.pl Bug 14330: Remove unused email_sender from sendbasket/sendshelf 2015-06-08 10:38:08 -03:00
opac-sendshelf.pl Bug 6322 - It's possible to view lists/virtualshelves even when virtualshelves is off 2016-02-04 22:22:29 +01:00
opac-serial-issues.pl Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
opac-shareshelf.pl Bug 16317 - Attempt to share private list results in error 2016-04-25 14:15:51 +02:00
opac-shelves.pl Bug 17316: Do not display the list's name if the user does not have permission - OPAC 2016-10-14 12:27:33 +02:00
opac-showmarc.pl Bug 11944: use CGI( -utf8 ) everywhere 2015-01-13 13:07:21 -03:00
opac-showreviews.pl Bug 14956: C4::Dates from files opac/*.pl 2015-11-06 15:01:28 -03:00
opac-suggestions.pl Bug 16154: CGI->multi_param - Declare a list 2016-05-16 14:38:51 +02:00
opac-tags.pl Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax 2015-11-02 12:49:13 -03:00
opac-tags_subject.pl Bug 14412: SQL injection possible 2015-06-22 11:00:10 -03:00
opac-topissues.pl Bug 16154: CGI->multi_param - Force scalar context 2016-05-16 14:42:43 +02:00
opac-user.pl Bug 16464: Add FIXME 2016-09-16 09:28:32 +02:00
tracklinks.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
unapi Bug 15190: Bad utf8 decode to unapi and fixing status code 200 2016-01-29 16:05:11 +01:00