Koha-clms/acqui
Christophe Croullebois 315847f5c0 Bug 7228: can't add items in an order with Modify
We have a message if we want to add items and we can't add, substract only.
It's ok if we choose to create items on ordering, in this case koha can't add items, just substract
and in this case we have to delete manually the items(s) in the catalog.
But if via the syspref AcqCreateItem we choose to create items when receiving this limitation is not usefull
The patch just checks if the syspref AcqCreateItem is on 'ordering'
if not the message is not shown and we can add items

Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
Here is the test I made for signing off :
after applying the patch
- syspref AcqCreateItem  : create items on RECEIVING
- in a basket, create an order (quantity = 1)
- save the order
- reopen the order
- change the quantity (2 instead of 1)
- save the order
=> changing quantity was not possible before the patch

- syspref AcqCreateItem  : create items on CATALOGING
- in a basket, create an order (quantity = 1)
- save the order
- reopen the order
- change the quantity (2 instead of 1)
- save the order
=> changing quantity was not possible before the patch

- syspref AcqCreateItem  : create items on ORDERING
- in a basket, create an order (click on "add" to add an item => quantity = 1)
- save the order
- reopen the order
- try to change the quantity (2 instead of 1), without clicking on "add" to create a new item => you cannot (alert message)
=> the behavior is the same as before the patch

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Copied test plan from bug report.
Template only change deactivating the Javascript that blocks
you from changing the quantity when AcqCreateItem is set to
something else than 'ordering'.
Passes all tests and QA script.
**Rebased for 3.10.x**

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
2013-05-14 20:38:52 +12:00
..
pdfformat Bug 5356: Followup Change font in the layout3pages pdf 2012-10-17 17:43:11 +02:00
acqui-home.pl Bug 7304: More permissions for budgets 2012-06-27 16:25:44 +02:00
addorder.pl Bug 9236 : Redirect to the parcel page after deleting an item/order 2013-02-01 21:19:14 +13:00
addorderiso2709.pl Bug 9432: Plack changes for acqui/addorderiso2409.pl 2013-02-09 12:21:42 +13:00
basket.pl Bug 7358: reaffect a closed basket to a closed basketgroup 2013-04-24 19:25:57 +12:00
basketgroup.pl Bug 7449: billingplace and freedeliveryplace not saved when creating a new basketgroup 2013-04-14 19:31:28 +12:00
basketheader.pl Bug 9364: fixes billing/delivery addresses for new baskets 2013-02-01 21:15:41 +13:00
booksellers.pl Bug 7737: applies date filters on vendor pages 2012-03-22 17:18:03 +01:00
check_budget_total.pl Bug 5385: POD Cleanups (part 1) 2010-11-12 10:06:55 +13:00
check_duplicate_barcode_ajax.pl Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. 2011-11-04 10:22:28 +01:00
check_uniqueness.pl Bug 7178: Follow-up Improve order item creation 2012-05-14 16:16:13 +02:00
currency.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
fetch_sort_dropbox.pl Bug 8629: update of statistics fields on fund selection in order creation/edition 2012-09-14 16:57:02 +02:00
finishreceive.pl Bug 8903: Pass invoiceid to ModReceiveOrder 2012-10-24 15:17:30 +02:00
histsearch.pl Bug 7018 : need all acq permissions to search 2013-03-29 19:41:51 +13:00
invoice.pl Bug 5339: ergonomic changes 2012-09-20 09:46:50 +02:00
invoices.pl Bug 5339: perltidy on added files 2012-09-18 22:42:23 +02:00
lateorders.pl Bug 8652: Followup: add a default value for date_from 2012-10-09 11:27:42 +02:00
modordernotes.pl Bug 7166: Adds edit order notes when the basket is closed 2012-03-20 16:45:37 +01:00
neworderbiblio.pl Bug 6994: Wrong 'no budget defined' alert 2011-11-06 11:43:30 +01:00
neworderempty.pl Bug 7228: can't add items in an order with Modify 2013-05-14 20:38:52 +12:00
newordersuggestion.pl Bug 4330 : Fixing FSF address and copyright headers for acqui/ 2012-05-28 17:54:18 +02:00
ordered.pl Bug 7735: removal of C4::Dates when unused 2012-03-20 18:11:04 +01:00
orderreceive.pl Bug 9923 - correction of a bug due to bz 7129 2013-05-11 10:39:04 +12:00
parcel.pl Bug 10044: Remove duplicate pagination on the pending orders page. 2013-05-09 21:25:50 +12:00
parcels.pl Bug 10152: Default sorting wrong in parcels.pl 2013-05-08 19:48:12 +12:00
spent.pl Bug 5339: Invoices management improvement 2012-09-18 22:42:15 +02:00
supplier.pl Bug 5335 - More granular VAT 2012-09-20 18:09:53 +02:00
uncertainprice.pl Fix FSF address in directory acqui/ 2010-03-16 20:17:51 -04:00
updatesupplier.pl Bug 5335 - More granular VAT 2012-09-20 18:09:53 +02:00
z3950_search.pl Bug 8570 follow-up removing tabs & improving indentation 2012-10-09 17:34:58 +02:00