gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/t/db_dependent
History
Nick Clemens 6d675b61ad Bug 24379: Make login_attempts not nullable 
While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE

When trying to reset a patrons password we check that the account is not administratively locked:
login_attempts != -1

This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0

Let's default to 0 like we intend

To test:
1 - Create a new patron
2 - Note their login_attempts is NULL
    SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1
3 - Enable  OpacResetPassword
4 - Attempt to reset password before logging in, you cannot
5 - Apply patch, updatedatabase, restart_all, update schema
6 - Create another patron
7 - Their login attempts should be 0
8 - Attempt to reset password, it works!

Bug 24379: Fix the test

First we create a patron using TestBuilder to get a hashref of valid
info. Then we delete it and create a new patron using Koha::Patron->new
Once stored, we should call discard_changes to make the calculated
values available in the currenct object.

Bug 24379: Don't drop default of 0 for login attempts

When moving the column we drop the default, this means that DBs upgraded form earlier versions
get the wrong values set

To test:
1 - Checkout 16.11.x
2 - Reset all
3 - Checkout master
4 - updatedatabase
5 - SHOW CREATE TABLE borrowers;
6 - Note the column login_attempts defaults to NULL
7 - Apply patch(es)
8 - Repeat
9 - Now it defaults ot 0 (and has NOT NULL if applied all)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 7bb31cffae)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
 		2020-07-24 21:48:29 +00:00
..
Acquisition Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Auth
…
Authority Bug 22437: Add test case to Merge.t 2020-05-12 11:01:49 +01:00
Biblio Bug 24715: Cache repeatable subfield in TransformKohaToMarc 2020-04-17 09:25:06 +01:00
Circulation Bug 24413: (follow-up) Add tests 2020-05-25 15:58:14 +02:00
CourseReserves Bug 25444: Add unit tests 2020-05-28 17:01:55 +02:00
Creators
…
Exporter
…
Holds Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Illrequest Bug 23173: Add unit tests 2020-04-06 11:04:36 +01:00
Items Bug 23463: Move DelItem.t and Items_DelItemCheck.t tests to a Koha/Item.t subtest 2020-03-23 09:26:33 +00:00
Koha Bug 24379: Make login_attempts not nullable 2020-07-24 21:48:29 +00:00
LDAP Bug 21395: (QA follow-up) Remove some introduced issues 2020-07-13 16:45:15 +00:00
Labels Bug 23463: Replace ModItem with Koha::Item->store 2020-03-23 09:26:30 +00:00
Letters Bug 24612: Add tests 2020-05-22 09:33:16 +01:00
Members Bug 20443: Remove extended_attributes_code_value_arrayref AND C4::Members::Attributes 2020-03-23 13:49:22 +00:00
OAI Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Patron Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Record Bug 21395: Fix QA errors 2020-07-13 16:45:01 +00:00
Reports Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
Reserves Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-24 20:54:48 +00:00
SIP Bug 25805: Regression tests 2020-07-13 15:10:44 +00:00
Search
…
Serials Bug 7046: Implemented subscription renewal dropdown sub length element 2020-04-08 11:48:03 +01:00
Template/Plugin Bug 24368: Comprehensive tests for Koha::Template::Plugin::Branches::pickup_locations 2020-05-13 10:30:41 +01:00
Utils Bug 25875: Unit test 2020-07-13 16:22:51 +00:00
api/v1 Bug 25570: (follow-up) Fix tests 2020-07-10 15:43:34 +00:00
cronjobs Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
data
…
selenium Bug 24801: (follow-up) Display all the libraries - Selenium fix 2020-04-08 08:16:13 +01:00
www Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
00-strict.t
…
01-test_dbic.t
…
Accounts.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Acquisition.t Bug 24161: Keep tracks of late orders claims 2020-05-04 09:44:44 +01:00
Amazon.t
…
ArticleRequests.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
AudioAlerts.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth.t
…
Auth_with_cas.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Auth_with_ldap.t Bug 25172: Fix Auth_with_ldap.t 2020-04-22 15:43:16 +01:00
AuthorisedValues.t Bug 17355: Fix failing tests 2020-05-05 14:59:30 +01:00
AuthoritiesMarc.t
…
BackgroundJob.t Bug 24760: (follow-up) Add a neighboring test messsage 2020-03-06 14:58:47 +00:00
Barcodes.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Barcodes_ValueBuilder.t
…
Biblio.t Bug 25189: Unit tests 2020-07-10 15:53:00 +00:00
Breeding.t Bug 24052: Fix Koha/XSLT/Base.t 2020-03-24 10:42:23 +00:00
Budgets.t
…
Cache.t
…
Calendar.t Bug 25850: Add tests for weekday holidays 2020-07-24 20:51:21 +00:00
Charset.t
…
Circulation.t Bug 25531: Add tests 2020-05-19 16:49:24 +01:00
Clubs.t
…
ColumnsSettings.t
…
Context.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Contract.t
…
CourseReserves.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
DecreaseLoanHighHolds.t Bug 25566: Add option to ignore found holds and use it when checking high holds 2020-07-24 20:54:48 +00:00
Filter_MARC_ViewPolicy.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Fines.t
…
FrameworkPlugin.t
…
Heading.t
…
Heading_MARC21.t
…
Hold.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Holds.t Bug 25232: Add ability to specify multiple notforloan values to skip 2020-07-13 15:36:50 +00:00
HoldsQueue.t Bug 25786: AddReserve now takes a hashref 2020-06-18 18:53:49 +02:00
Holidays.t Bug 19475: Clear the caches at the end of the tests 2020-04-03 14:26:33 +01:00
ILSDI_Services.t Bug 24769: Regression tests 2020-05-05 11:03:45 +01:00
Illcomments.t
…
Illrequestattributes.t
…
Illrequests.t Bug 22001: Make the DBD error regex less strict 2020-03-31 17:46:21 +01:00
ImportBatch.t Bug 20415: Remove UseKohaPlugins system preference 2020-03-26 11:42:02 +00:00
ImportExportFramework.t
…
Installer.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Items.t Bug 25964: Prevent data loss when editing items from a MARC record 2020-07-24 20:31:28 +00:00
Koha.t
…
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t
…
Koha_ExternalContent_OverDrive.t Bug 25527: Add logger to Koha::ExternalContent 2020-05-18 15:25:03 +01:00
Koha_ExternalContent_RecordedBooks.t
…
Koha_Misc_Files.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Languages.t
…
Letters.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
LibraryGroups.t
…
Linker_Default.t
…
Linker_FirstMatch.t
…
Log.t Bug 21190: Add tests for authentication success and failure 2020-04-14 16:13:39 +01:00
MarcModificationTemplates.t Bug 24900: Checks in MARC mod templates for when from field does not equal conditional field 2020-04-03 14:26:31 +01:00
Members.t
…
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t Bug 25127: Correction to tests 2020-05-01 15:44:51 +01:00
Passwordrecovery.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
PatronLists.t
…
Patroncards.t
…
Patrons.t
…
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t
…
Reports.t
…
Reserves.t Bug 24612: Fix existing ReserveSlip tests 2020-05-22 12:36:35 +01:00
RotatingCollections.t Bug 23463: Replace AddItem calls with Koha::Item->store 2020-03-23 09:26:26 +00:00
Search.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Serials.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Serials_2.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
Service.t
…
ShelfBrowser.t Bug 22001: Remove the RaiseError occurrences from tests 2020-03-27 08:52:56 +00:00
Sitemapper.t Bug 24840: Replace DateTime->now with dt_from_string 2020-04-08 11:54:23 +01:00
Stats.t
…
StockRotationItems.t
…
StockRotationRotas.t
…
StockRotationStages.t
…
SuggestionEngine_ExplodedTerms.t
…
Suggestions.t Bug 22778: Add unit test 2020-04-14 08:19:34 +01:00
Tags.t
…
Templates.t
…
TestBuilder.t
…
Upload.t
…
UsageStats.t Bug 25147: (RM follow-up) Update pref references. 2020-04-17 09:03:47 +01:00
Virtualshelves.t
…
XISBN.t Bug 21395: Make perlcritic happy 2020-07-13 16:44:43 +00:00
XSLT.t Bug 23463: Fix XSLT.t 2020-03-23 09:26:34 +00:00
check_kohastructure.t
…
check_sysprefs.t
…
db_structure.t
…
rollingloans.t
…
sysprefs.t
…
zebra_config.pl
…