gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
37,385 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Kyle M Hall 6ccd2a55e1 Bug 26076: Sum the amount due in the database query instead of a loop in Perl 
This appears to be a bug due to inaccuracies in floating point math. I've been unable to reproduce it on demand. Sometimes when using the "Write off selected" button, Koha will give the error that the payment is more than the amount owed, even though they are the same. The solution I've implemented is to move the summation from Perl code to the database query. This video demonstrates the issue and afterward, shows the error goes away after the patch is applied: https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Verify that "Write off selected" functions as usual

Signed-off-by: Amit Gupta <amit.gupta@informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 6441296903)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 2e3b3a23fc)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
 		2020-09-09 21:21:45 +12:00
C4 Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-09-09 16:41:25 +12:00
Koha Bug 23634: (QA follow-up) Our PUT is really a PATCH 2020-08-25 15:36:33 +12:00
OpenILS
…
acqui Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-09-09 16:41:25 +12:00
admin Bug 24663: [19.11.x] Force auth in adveditorshortcuts.pl 2020-08-25 15:45:49 +12:00
api/v1 Bug 25944: Schema fix for illrequests route 2020-07-31 01:19:02 +12:00
authorities Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
basket Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
catalogue Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
cataloguing Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
clubs Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
course_reserves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
debian Bug 25778: Fix var scope in koha-plack for PERL5LIB and KOHA_HOME 2020-09-09 21:02:41 +12:00
docs Corrections to teams for 20.05 cycle 2019-11-29 12:10:34 +00:00
errors Bug 23329: Move error page to its own subroutine 2019-11-27 11:30:19 +00:00
etc Bug 25277: Don't specify a field in query if none passed 2020-05-19 22:57:25 +00:00
ill Bug 21460: (follow-up) Fix bugs found in QA 2019-04-25 10:46:56 +00:00
installer Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
koha-tmpl Bug 26233: (bug 25553 follow-up) Make date columns sortable on the edit items table 2020-09-09 21:04:59 +12:00
labels Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
members Bug 26076: Sum the amount due in the database query instead of a loop in Perl 2020-09-09 21:21:45 +12:00
misc Update release notes for 19.11.09 release 2020-08-19 09:16:44 +12:00
offline_circ Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
opac Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
patron_lists Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
patroncards Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
plugins Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reports Bug 26090: Fix "item types" report 2020-09-09 15:57:49 +12:00
reserve Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
reviews Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
rotating_collections Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
serials Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
services
…
skel
…
suggestion Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-10 23:08:59 +00:00
svc Bug 24663: [19.11.x] Force authentication in svc/records/preview (?) 2020-08-25 15:45:52 +12:00
t Bug 25750: fix fallback to ecost_tax_included/ecost_tax_excluded 2020-09-09 16:41:25 +12:00
tags Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
tmp/modified_authorities
…
tools Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
virtualshelves Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
xt Bug 21576: Keep compatibility with QA script 2018-10-26 17:09:52 +00:00
.editorconfig
…
.eslintrc.json Bug 23834: Add default ESLint configuration 2019-11-03 08:02:39 +00:00
.gitignore Bug 20427: Convert OPAC LESS to SCSS 2018-08-09 15:17:07 +00:00
.htaccess
…
.mailmap
…
.scss-lint.yml Bug 21237: Clean up staff client SCSS 2018-08-24 16:23:25 +00:00
INSTALL
…
Koha.pm Increment version for 19.11.09 release 2020-08-25 09:52:50 +12:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 24445: Add z3950 to makefile (bug 13937 follow-up) 2020-01-18 15:05:48 +00:00
README
…
README.md
…
README.robots
…
about.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
changelanguage.pl Bug 21299: (QA follow-up) Rename module and subroutine 2018-11-07 21:52:17 +00:00
fix-perl-path.PL
…
gulpfile.js Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
help.pl Bug 19817: Use the language from the interface if valid 2018-09-06 17:32:28 +00:00
koha_perl_deps.pl
…
kohaversion.pl
…
mainpage.pl Bug 24663: [19.11.x] Remove authnotrequired if set to 0 2020-08-25 15:45:46 +12:00
package.json Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00
rewrite-config.PL Bug 17851: Add elasticsearch config to koha-conf.xml 2019-10-07 14:09:10 +01:00
yarn.lock Bug 26228: Update gulpfile to work with Node.js v12 2020-09-09 16:04:42 +12:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo