Koha-clms/members
Alex Buckley f0b2aea1ea Bug 23808: [19.11.x] Pre-fill guarantor fields when adding guarantee to guarantor
Bug 14570 removed the guarantor pre-fill functionality when selecting
'Add guarantee' to an Adult patron. This is because guarantor
information would now only display if (1) the patron record exists
(which it won't when first adding guarantee to guarantor record) and (2)
if there is already a guarantor added to a guarantee

This patchfix will pre-fill guarantor fields and address fields (so the guarantee
has the same address as the guarantor) if no relationship (existing
guarantor data exists) and a guarantor_id is handed to memberenty.pl in
URL when clicking 'Add guarantee' button on Adults patron record.

Test plan:
1. Add adult patron make sure to fill in their 'Main address' details
2. Select 'Add guarantee'
3. Observe no details of the adult patron
are displaying in the 'Guarantor information' section or 'Main address'
sections of memberentry.pl

4. Select 'Search to add', search for your adult patron and choose
'Select' to add them as guarantor

5. Fill out rest of memberentry.pl and 'Save'

6. Observe adult is showing as the guarantor

7. Apply patch

8. Run tests:
sudo koha-shell <instancename>
prove xt
prove t

9. Confirm tests pass

10. Return to your adult patron

11. Select 'Add guarantee'

12. Observe in 'Guarantor information' and 'Main address' sections of memberentry.pl
are pre-filled with the 'patron #' (borrowernumber), surname, firstname
and street number, address, address2 (if you filled that in on adults
account), city

13. Fill out the rest of memberenty.pl and save and confirm your adult
patron is showing as the guarantor and the pre-filled address details
have been saved and are showing

14. Repeat steps 10,11 and 12 and in the 'Guarantor information' select
'Search to add' and add another adult as guarantor

15. Fill out the rest of memberentry.pl and 'Save' and notice with this
patch applied you can still add multiple guarantors successfully

Sponsored-By: South Taranaki District Council, NZ

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: George Veranis <gveranis@dataly.gr>
Followed the test plan, works as expected. The only failure was
t/DateUtils.t test which will be fixed by Bug 24850.
Also corrected a small typo in the sponsored-by trailer.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Bug 23808: (follow-up) Display card number in 'Guarantor information' in memberentry.pl

Instead of displaying 'Patron #' and displaying the guarantor's borrowernumber
in 'Guarantor information' we should display 'Patron card number:' with
the cardnumber displayed as that value is more meaningful to librarians.
The hyperlink containing the borrowernumber should stay the same so that
librarians can easily visit the patron record of existing guarantor
patrons.

Test plan:

1. Apply first patch and follow it's test plan

2. On an Adult patrons record select 'Add guarantee'

3. In 'Guarantor information' section of memberentry.pl observe in the
pre-filled guarantor information there is
a line 'Patron #:' with a link displaying a borrowernumber (not card number) and when you click on the link it takes you to the adult/guarantors patron account

4. Select 'Search to add' and search and add another guarantor

5. Observe in the added guarantor 'Patron #:' is displayed along with
the borrowernumber (not card number). The borrowernumber displayed in
not a link.

6. Apply this patch

7. On a adults patron select 'Add guarantee'

8. Observe in 'Guarantor information' section the pre-filled guarantor
now has 'Patron card number:' displayed (instead of 'Patron #:', and it's link now displays the guarantors cardnumber.
Clicking on the link still takes you to the guarantors patron account

9. Repeat step 4

10. Observe in the added guarantor they also have 'Patron card number:'
(instead of 'Patron #:'). A cardnumber rather than borrowernumber is
displayed. The cardnumber is not a link.

11. Confirm tests still pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Bug 23808: (follow-up) Pre-fill guarantee's contact details from guarantor patron in memberentry.pl

Pre-fill guarantee contact details (email, phone) from guarantor record
when adding a gurantee to a guarantor's record

Test plan:

1. Apply first two patches and follow test plans

2. On an adult's patron record (which has an primary phone
number, secondary phone, other phone, primary email, secondary email and
fax set) select 'Add a guarantee' and observe the guarantee's 'Contact'
section is not pre-filled with that information from the guarantor

3. Apply this patch

4. On the same adult's record select 'Add a guarantee' and observe that
the 'Primary phone', 'Secondary phone', 'Other phone', 'Primary email',
'Secondary email', 'Fax' have been pre-filled from the guarantor's
record

5. Fill out the rest of the memberentry.pl and 'Save' and observe that those contact
details are successfully saved

6. Repeat step 4 and alter the 'Primary phone' and 'Primary email'
fields and save and observe that those altered values are saved

7. Run tests and confirm they pass:
sudo koha-shell <instancename>
prove xt
prove t

Sponsored-by: South Taranaki District Council, NZ
Signed-off-by: Andreas Roussos <a.roussos@dataly.gr>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Bug 23808: (follow-up) Object methods can be used directly, no need for unblessed

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

fix tabs

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
2020-06-16 10:31:52 +12:00
..
accountline-details.pl Bug 20666: Correct executable permissions 2018-05-03 13:26:48 -03:00
apikeys.pl Bug 21993: Display a user-friendly message when the CSRF token is wrong 2019-01-25 20:38:32 +00:00
boraccount.pl Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup 2019-10-08 14:47:39 +01:00
default_messageprefs.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
deletemem.pl Bug 23822: Fix deletion of patrons with credit 2019-11-13 16:23:04 +00:00
discharge.pl Bug 23723: using exit inside eval to stop sending output to browser doesn't work under plack 2019-10-07 12:21:30 +01:00
discharges.pl Bug 18403: Patron discharges 2018-02-12 15:41:41 -03:00
files.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
guarantor_search.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
holdshistory.pl Bug 21939: Fix permissions for holds history tab 2019-11-07 13:22:03 +00:00
housebound.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
ill-requests.pl Bug 18589: (follow-up) Remove redundant-ness 2019-03-22 20:21:47 +00:00
mancredit.pl Bug 23805: Update mancredit to use the new credit types 2019-10-24 17:35:21 +01:00
maninvoice.pl Bug 23049: (QA follow-up) Correction for missed archived filter 2019-10-24 17:25:15 +01:00
member-flags.pl Bug 23321: Add cash register permission 2019-09-23 11:39:21 +01:00
member-password.pl Bug 22706: Add plugin hooks for Norwegian national patron database 2019-10-29 12:19:49 +00:00
member.pl Bug 20998: Simplify the conditional statement 2018-06-29 19:05:57 +00:00
memberentry.pl Bug 23808: [19.11.x] Pre-fill guarantor fields when adding guarantee to guarantor 2020-06-16 10:31:52 +12:00
members-home.pl Bug 23697: (QA follow-up) Rename PatronAutocompletion to PatronAutoComplete 2019-10-08 14:51:12 +01:00
members-update-do.pl Bug 20287: Move ModMember to Koha::Patron 2018-07-18 15:49:50 +00:00
members-update.pl Bug 18403: Update permissions - borrowers => 1|* becomes borrowers => 'edit_borrowers' 2018-02-12 15:41:37 -03:00
merge-patrons.pl Bug 9302: Add error message if keeper patron is invalid 2018-04-20 13:34:41 -03:00
mod_debarment.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
moremember.pl Bug 14697: Enhance the return claims feature 2019-10-31 12:04:21 +00:00
notices.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
patronimage.pl Bug 17423 - patronimage.pl permission is too restrictive 2016-10-17 23:44:25 +00:00
pay.pl Bug 19809: Re-allow to call Koha::Objects::find in list context 2020-02-11 19:27:34 +00:00
paycollect.pl Bug 22359: Prevent undercollection at the server 2020-03-13 01:19:56 +00:00
print_overdues.pl Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues 2018-04-03 11:43:06 -03:00
printfeercpt.pl Bug 23507: Add ability to show change given on auto-popup fee receipt from FinePaymentAutoPopup 2019-10-08 14:47:39 +01:00
printinvoice.pl Bug 21879: Code cleaning in printinvoice.pl 2020-04-01 20:09:41 +00:00
printslip.pl Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos 2018-02-12 15:41:38 -03:00
purchase-suggestions.pl Bug 22868: Move suggestions_manage subperm out of acquisition perm 2020-02-10 23:08:59 +00:00
readingrec.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
routing-lists.pl Bug 12159: Fix getting extended patron attributes for circ-menu 2019-03-28 13:05:22 +00:00
setstatus.pl Bug 18403: Fix few errors found with hit_pages.t 2018-02-12 15:41:43 -03:00
statistics.pl Bug 21027: Fix checkout statistics if 1+ of the fields is not defined 2019-07-15 12:25:15 +01:00
summary-print.pl Bug 24840: [19.11.x] Replace DateTime->now with dt_from_string 2020-05-07 17:17:12 +00:00
update-child.pl Bug 14570: Make it possible to add multiple guarantors to a record 2019-08-20 16:04:48 +01:00