Koha-clms/Koha
Colin Campbell a86dff7924 Bug 22611: Correction for call to get create_item in EDI.pm
There was a typo in the addition of a call to
effective_create_items causing processing to abort after adding
a single copy.

This patch reverts to using the C4::Context call as used for the
first copy created, the intended call to effective_create_items
is a wrapper around that as the field in the basket is guaranteed
to be null (its not set when we call AddBasket). Being consistent
and explicit in what we call should guard against future changes
in dependencies exposing the logic flaw

Added some comments to make logical flow of code clearer

Signed-off-by: Liz Rea <wizzyrea@gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f6bc67e851)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 4a2e885495)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
2019-04-15 16:40:56 +00:00
..
Account Bug 22006: Handle undefined itemnumber for Koha::Account::Line->item 2019-01-23 23:11:49 +00:00
Acquisition
…
ArticleRequest
…
Authority
…
Biblio
…
BiblioUtils
…
Cache
…
Club
…
Config
…
Edifact Bug 21425: Display basketno correctly in Order error msg 2018-10-05 16:38:33 +01:00
Exceptions Bug 21478: Add Koha::Exceptions::Hold 2019-02-05 23:18:18 +00:00
Exporter
…
ExternalContent Bug 21082: Update OverDrive authentication method 2018-10-26 12:16:27 +01:00
Filter/MARC
…
Illrequest
…
Indexer
…
Item
…
Library Bug 21910: Does not deal with call context, ->search does already 2018-12-18 19:02:58 +00:00
List
…
MetadataRecord
…
Middleware
…
Misc
…
Notice
…
Number Bug 21262: Do not format numbers for editing if too big 2018-09-17 15:33:18 +01:00
OAI/Server Bug 20665: Reset MySQL connection time zone in the OAI-PMH Provider 2018-05-03 12:46:55 -03:00
Object/Limit
…
Old Bug 21432: (bug 20899 follow-up) Fix patron's name display for deleted patrons 2018-10-08 09:41:45 +01:00
Patron Bug 21134: Correctly throw the exception in Koha::Patron::Modification->approve 2018-08-03 14:42:50 +01:00
Patrons Bug 22386: Define patron variable when matchign on extended attributes 2019-03-06 07:44:59 +00:00
Plugins Bug 22084: Plugin upgrade method and database plugin version storage will never be triggered for existing installs 2019-03-08 19:31:10 +00:00
QueryParser/Driver
…
REST Bug 22132: Add Basic authentication to the API - Revert 2019-02-12 00:38:41 +00:00
RecordProcessor
…
SMS
…
Schema/Result Bug 13515: Schema Updates 2019-02-26 05:07:17 +00:00
SearchEngine Bug 20273: Use compat routines for autocomplete in auth_finder.pl 2018-08-06 14:00:54 +01:00
Serial
…
Sitemapper
…
Subscription
…
SuggestionEngine
…
Template/Plugin Bug 21593: Remove GROUP BY from GetAuthValueDropbox 2018-10-26 14:21:44 +01:00
Util Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation 2019-03-19 23:12:48 +00:00
pdfformat Bug 22282: Fix PDF issue when exporting PDF in French format. 2019-02-12 22:16:44 +00:00
Account.pm Bug 21396: Add 2 missing use statements in Koha::Account 2018-10-03 10:32:27 +01:00
AdditionalField.pm
…
ApiKey.pm Bug 20568: (QA follow-up) Remove unused vars 2018-05-09 12:56:00 -03:00
ApiKeys.pm Bug 20568: Add mandatory description field for api keys 2018-05-09 12:55:58 -03:00
ArticleRequest.pm
…
ArticleRequests.pm
…
AudioAlert.pm
…
AudioAlerts.pm
…
AuthUtils.pm Bug 21719: Fix typos 2018-11-16 12:59:57 +00:00
AuthorisedValue.pm
…
AuthorisedValueCategories.pm
…
AuthorisedValueCategory.pm
…
AuthorisedValues.pm
…
Authorities.pm
…
Authority.pm
…
Biblio.pm
…
BiblioFramework.pm
…
BiblioFrameworks.pm
…
BiblioUtils.pm
…
Biblioitem.pm
…
Biblioitems.pm
…
Biblios.pm
…
Cache.pm Bug 21955: Remove Cache::Memory as fallback for L2 cache 2018-12-18 18:51:10 +00:00
Caches.pm
…
Calendar.pm Bug 19204: Make the debarment date calculation depends on finesCalendar 2018-04-25 10:52:20 -03:00
Checkout.pm
…
Checkouts.pm
…
Cities.pm
…
City.pm
…
ClassSortRule.pm
…
ClassSortRules.pm
…
ClassSource.pm
…
ClassSources.pm
…
Club.pm
…
Clubs.pm
…
Config.pm
…
CsvProfile.pm
…
CsvProfiles.pm
…
Database.pm Bug 20521: Use a specific config for strict sql modes 2018-11-05 12:32:08 +00:00
DateUtils.pm Bug 19816: Implement dateonly for rfc3339 format 2019-02-12 02:41:14 +00:00
EDI.pm Bug 22611: Correction for call to get create_item in EDI.pm 2019-04-15 16:40:56 +00:00
Edifact.pm
…
Email.pm
…
Exceptions.pm
…
ExternalContent.pm
…
FieldMapping.pm
…
FieldMappings.pm
…
FrameworkPlugin.pm Bug 22124: Update cataloguing plugin system to not generate type parameter in script tag 2019-02-06 17:57:24 +00:00
Hold.pm Bug 21478: Make Koha::Hold->suspend reject found holds 2019-02-05 23:19:12 +00:00
Holds.pm
…
I18N.pm
…
Illrequest.pm Bug 20548: Remove copyright clearance for staff 2018-10-15 13:39:36 +01:00
Illrequestattribute.pm
…
Illrequestattributes.pm
…
Illrequests.pm
…
IssuingRule.pm
…
IssuingRules.pm
…
Item.pm
…
ItemType.pm Bug 21599: Fix item type creation by defining default values 2018-11-05 12:23:26 +00:00
ItemTypes.pm
…
Items.pm
…
Libraries.pm
…
Library.pm
…
Linktracker.pm
…
Localization.pm
…
Localizations.pm
…
Logger.pm
…
MarcSubfieldStructure.pm
…
MarcSubfieldStructures.pm
…
MetaSearcher.pm
…
MetadataIterator.pm
…
MetadataRecord.pm
…
MoreUtils.pm
…
News.pm
…
NewsItem.pm
…
NorwegianPatronDB.pm
…
OAuth.pm Bug 20612: (QA follow-up) Fix typo in method POD 2018-05-09 12:56:01 -03:00
OAuthAccessToken.pm Bug 20402: Add missing POD 2018-05-08 15:55:43 -03:00
OAuthAccessTokens.pm Bug 20402: Add missing POD 2018-05-08 15:55:43 -03:00
Object.pm Bug 20287: Koha::Object->get_from_storage 2018-10-08 11:29:32 +01:00
Objects.pm Bug 20767: Display a stack trace when a method is not covered by tests 2018-06-05 11:24:41 +01:00
Patron.pm Bug 22067: Return if no patron passed to can_see_patron_infos 2019-03-04 22:17:13 +00:00
Patrons.pm
…
Plugins.pm
…
Rating.pm
…
Ratings.pm
…
RecordProcessor.pm
…
RefundLostItemFeeRule.pm
…
RefundLostItemFeeRules.pm
…
Report.pm
…
Reports.pm
…
Review.pm
…
Reviews.pm
…
Schema.pm
…
SearchEngine.pm
…
SearchField.pm
…
SearchFields.pm
…
SearchMarcMap.pm
…
SearchMarcMaps.pm
…
Serial.pm
…
Serials.pm
…
SimpleMARC.pm
…
Sitemapper.pm
…
Subscription.pm
…
Subscriptions.pm
…
Suggestion.pm
…
SuggestionEngine.pm
…
Suggestions.pm
…
Token.pm
…
UploadedFile.pm Bug 20428: (QA follow-up) Remove redundant directory level 2018-05-14 10:36:39 -03:00
UploadedFiles.pm
…
Uploader.pm
…
Virtualshelf.pm
…
Virtualshelfcontent.pm
…
Virtualshelfcontents.pm
…
Virtualshelfshare.pm Bug 11943: Prevent double accepts in Koha::Virtualshelfshare 2018-05-11 10:52:43 -03:00
Virtualshelfshares.pm
…
Virtualshelves.pm Bug 21612: Remove incorrect GROUP BY's from Koha::VirtualShelves 2018-11-06 11:55:18 +00:00
XSLT_Handler.pm
…
Z3950Server.pm
…
Z3950Servers.pm
…