gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
27,698 Commits 39 Branches 720 Tags 6 GiB
Perl 44.2%
JavaScript 41.1%
HTML 6%
XSLT 3.1%
Vue 1.9%
Other 3.2%
Go to file
Marcel de Rooy 6ab7280ba2 Bug 18607: Fix date calculations for monthly frequencies in Serials 
Similarly to the solution of bug 18356, this patch fixes the date
calculation for monthly frequencies.

The calculation in GetFictiveIssueNumber now makes use of the new
_delta_units sub introduced on bug 18356.

The calculation in _get_next_date_month is also very similar to the one
in _get_next_date_year. I do not merge them here, but this could still
be considered later on. At least consistency is achieved now between
both routines. The connection with firstacquidate has been cut thru
just like for year units.

Test plan:
[1] Without this patch, look at the prediction pattern for a
    subscription with first issue on Feb 21 and 5 per month. The first
    issues will be 21, 22, 23, 24, 25. Then jumping to 21, 23, 25, etc.
[2] Apply the patch. Look at the same prediction pattern. You will now
    see 6 day intervals and a new cycle starting on the 21st.
    So Feb 21, 27, Mar 5, 11, 17 and Mar 21, 27, etc.
[3] Edit an subscription. Try a few other monthly frequencies.
[4] The next patch adjusts related unit tests.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
 		2017-07-31 01:02:06 +12:00
C4 Bug 18607: Fix date calculations for monthly frequencies in Serials 2017-07-31 01:02:06 +12:00
Koha Bug 17974 (QA Followup) 2017-07-30 07:04:14 +12:00
OpenILS Bug 9239 QA follow-up: remove stray debug code 2013-03-16 21:32:34 -04:00
acqui Revert "Bug 11122 - publisher code and publication year not fetched in acq orders" 2017-07-31 00:41:23 +12:00
admin Bug 18376: Do not need to prepare a single statement, use do 2017-05-24 15:44:13 +12:00
api/v1 Bug 17042: Fix missing column in hold.json 2016-08-07 09:33:33 +02:00
authorities Bug 18019: [QA Follow-up] Also catch the delete from authorities detail 2017-04-24 11:09:53 +12:00
basket Bug 17109: [QA Follow-up] Die when wrong token 2017-05-03 14:25:24 +12:00
catalogue Bug 16951: Replace some more 2017-01-03 14:44:42 +13:00
cataloguing Bug 17922: Use correct number of digits when replacing date placeholders 2017-02-23 03:08:41 +13:00
circ Bug 18966: Do not deal with duplicate issue_id on checkin 2017-07-25 11:51:43 +12:00
course_reserves Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
debian Bug 18548: Print usage when missing instance name in koha-create script 2017-07-30 06:26:07 +12:00
docs Bug 7143 : More new devs 2016-08-01 13:31:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 18669 - RewriteCond affecting wrong rule in koha-httpd.conf 2017-07-30 06:43:33 +12:00
installer Bug 18690 - Typos in Koha database description (Table "borrowers") 2017-07-30 07:18:27 +12:00
koha-tmpl Bug 17181: Check for duplicate image names when uploading image to patron card creator 2017-07-31 01:02:06 +12:00
labels Bug 18535 - Clicking 'edit printer profile' in label creator causes software error 2017-05-24 14:26:23 +12:00
members Bug 17146: Fix CSRF in picture-upload.pl 2017-05-03 14:35:48 +12:00
misc Add release notes to 16.05.14 release 2017-06-13 18:25:39 +12:00
offline_circ Bug 15764: Fix timestamp sent by KOCT 2016-02-23 20:53:18 +00:00
opac Bug 18204 - Authority searches are not saved in Search history 2017-07-30 06:38:51 +12:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 17181: Simplify code 2017-07-31 01:02:06 +12:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 13452: Fix for plack 2017-07-31 01:02:05 +12:00
reserve Bug 17028: Fix XSS in reserve/request.pl 2016-08-05 08:11:00 +02:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
serials Bug 18536: [QA Follow-up] Tiny regex simplification 2017-05-24 15:44:13 +12:00
services Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
skel Bug 11078: Add locking to rebuild_zebra 2014-02-28 22:21:41 +00:00
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-11-02 17:58:26 +00:00
t Bug 18356: Extend GetNextDate.t, add GetFictiveIssueNumber.t (unit=year) 2017-07-31 01:02:06 +12:00
tags Bug 16154: CGI->multi_param - Assign a list 2016-04-26 23:16:43 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities changing DO_NOT_REMOVE to README.txt 2007-10-21 19:14:41 -05:00
tools Bug 18806: Fix batch revert 2017-07-31 01:02:06 +12:00
virtualshelves Bug 15451: (followup) fix filename extension for csv file 2017-04-30 23:20:01 +12:00
xt Bug 18746: Text_CSV_Various parse failures 2017-07-30 07:18:44 +12:00
.editorconfig Bug 12545: Add EditorConfig.org file to the source tree 2014-08-22 11:07:45 -03:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap (RM followup) .mailmap updates 2015-05-22 17:02:21 -03:00
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-12-12 14:54:13 +13:00
Koha.pm Increment version for 16.05.14 release 2017-06-13 17:23:21 +12:00
LICENSE Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-06 23:54:46 -05:00
Makefile.PL Bug 18373: Re-add UpgradeBackup.pm 2017-04-30 23:19:56 +12:00
README Bug 9440 - update Koha's LICENSE file from GPL2 to GPL3 2013-02-12 08:52:10 -05:00
README.md Bug 15465 - Created README.md file for github 2017-07-30 06:31:29 +12:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 18931 - Follow up - Typo fix in SQL statement 2017-07-26 15:14:53 +12:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-23 11:51:49 +02:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL Bug 9978: (followup) Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:43 -03:00
help.pl Bug 16724: Fix link to the online documentation links 2016-08-01 09:22:30 +02:00
install-CPAN.pl Bug 9978: Replace license header with the correct license (GPLv3+) 2015-04-20 09:59:38 -03:00
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-01-30 00:56:20 +13:00
kohaversion.pl Bug 13758: Move the Koha version from kohaversion.pl 2015-05-07 11:39:04 -03:00
mainpage.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
rewrite-config.PL Bug 16222: (QA followup) Add /api dir for the API 2016-04-20 21:18:36 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo