Koha-clms/C4/SIP/ILS/Transaction
Martin Renvoize 11c73ed5b8 Bug 34767: Pass fee_ack into ::Transaction::Renew(All)
This patch copies the $fee_ack field into the generated
::Transaction::Renew|All objects such that the fee acknowldegement flag
is respected for renewals.

Test plan
To test:
1) Add a rental charge to an itemtype
2) Checkout an item of that itemtype to a user
3) Attempt a renewal of that item via SIP2 and note that it fails
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m renew
4) Pass the fee_acknowledgement bit in renewal and note the renewal
   still fails.
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew
5) Apply patch and note the above now succeeds
   sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m renew

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 3a2dcf0733)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2023-09-17 22:00:51 -10:00
..
Checkin.pm Bug 31735: Avoid re-fetcing objects from database by passing them directly instead of ids to various subroutines 2023-05-12 12:40:21 -03:00
Checkout.pm Bug 12225: Use ProcessOfflineIssue 2022-08-25 08:22:35 -03:00
FeePayment.pm Bug 33216: Catch and handle RegisterRequired exceptions for SIP fee paid messages 2023-04-19 09:20:48 -03:00
Hold.pm Bug 29094: Adding hold via SIP should check if patron can hold item first 2022-07-18 10:24:58 -03:00
Renew.pm Bug 34767: Pass fee_ack into ::Transaction::Renew(All) 2023-09-17 22:00:51 -10:00
RenewAll.pm Bug 34767: Pass fee_ack into ::Transaction::Renew(All) 2023-09-17 22:00:51 -10:00