Go to file
Christophe Croullebois 6068daab0e Bug 20318: Merge invoices can lead to an merged invoice without Invoice number
When you want to merge invoices you have a page with a non editable
field 'Invoice number:' it shows the content of the first invoice to be
merged.
But if you validate by clicking the 'merge' button you arrive on the
next page which says that 'Invoice has been modified' and if you quit
this page without saving you have now a merged invoice without Invoice
number.
This tiny patch just prevents this issue to occur.

Test plan :

1° go to the acqui/invoices.pl page and search invoices to merge.
You must have at least 2 invoices on the same vendor
2° check boxes to select invoices to merge and click on 'merge selected
invoices' button
3° next page you see the non editable field 'Invoice number:'
4° click on the 'merge' button
5° next page you see 'Invoice has been modified'
6° leave this page i.e click on the left link 'Invoices'
7° search invoices you'll see the merged invoice without invoice number.

Apply the patch, replay the steps 1 to 3
4° on this page you can enter your invoice number and click on the
'merge' button.
If you leave this field empty and click merge, a message informs you
that it is required and you can not merge.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Conflicts:
	koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt

(cherry picked from commit 3838dd8375)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
2018-05-22 11:53:01 +02:00
C4 Bug 20455: Fix sort patrons by date expired 2018-05-22 11:22:42 +02:00
Koha Bug 20229: Explicitly list the SQL modes we support 2018-04-10 08:53:40 +02:00
OpenILS
…
acqui Bug 19596: Don't try to get hold or items count for non-existent biblios 2018-02-05 11:34:25 +01:00
admin Bug 20227: Check for categorycode in default_borrower_circ_rules 2018-05-09 16:46:06 +02:00
api/v1 Bug 18763: Fix swagger/definitions.t 2017-06-20 10:19:55 +02:00
authorities Bug 20430: (See also bug 19436) Button display depends on wrong server count 2018-04-24 07:12:19 +02:00
basket Bug 18124: Change the calls to generate and check CSRF tokens 2017-03-30 09:07:09 +00:00
catalogue Bug 20341: Show authorized value description for withdrawn like damaged and lost 2018-04-24 07:10:53 +02:00
cataloguing Bug 18593: Move suggestions when bibliographic records are merged 2018-04-24 15:22:21 +02:00
circ Bug 19921: Fix update child when only one adult patron category exist 2018-01-30 09:09:39 +01:00
clubs Bug 18632: Remove 'CGI::param called in list context' warnings 2017-05-28 22:25:22 -04:00
course_reserves Bug 20276: Fix GetCourseItem call to get itemnumber 2018-02-26 13:41:21 +01:00
debian Revert "Bug 20234: Make maintenance scripts use koha-zebra instead of koha-*-zebra" 2018-05-16 08:22:53 +02:00
docs Bug 7143: Add Patricio Marrone to history.txt 2017-03-31 13:45:33 +00:00
errors
…
etc Bug 19739: Add default ES configuration to koha-conf.xml 2018-04-24 17:16:06 +02:00
installer Increment version for 17.05.11 release 2018-04-25 08:25:17 +02:00
koha-tmpl Bug 20318: Merge invoices can lead to an merged invoice without Invoice number 2018-05-22 11:53:01 +02:00
labels Bug 19681: Correct result count formatting 2017-12-20 09:30:46 +01:00
members Bug 20367: Avoid resetting userid when BorrowerUnwantedField contains userid 2018-03-27 13:46:10 +02:00
misc Update release notes for 17.05.11 release 2018-04-25 08:31:26 +02:00
offline_circ Bug 17501: Remove Koha::Upload::get from Koha::Upload 2017-01-20 14:20:05 +00:00
opac Bug 20083: Follow up - use same logic in opac-showmarc 2018-03-27 13:59:19 +02:00
patron_lists
…
patroncards Bug 18246: Patron card creator: Unit not always displays properly in layouts 2017-03-22 20:58:10 +00:00
plugins Bug 19088: plugins-upload causes error log noise 2017-09-29 15:34:42 +02:00
reports Bug 19671: Map itemtypes to hash for correct display in issues_stats.pl 2018-05-02 07:31:46 +02:00
reserve Bug 18474: Restore multiple holds when patron is searched for 2018-05-22 11:46:54 +02:00
reviews
…
rotating_collections
…
serials Bug 20461: Serials: fix ignored params in subscription creation form 2018-04-24 17:10:43 +02:00
services
…
skel
…
sms
…
suggestion Bug 18839: Suggestion.pl spelling mistake 2017-07-27 16:30:17 +02:00
svc Bug 17898: Automagically convert SQL reports 2017-05-19 18:48:26 +00:00
t Bug 20503: Prevent Borrower_PrevCheckout.t to fail randomly 2018-05-22 11:42:29 +02:00
tags Bug 5471: Use uri_escape_utf8 to handle utf8 chars correctly 2017-09-29 11:17:17 +02:00
test
…
tmp/modified_authorities
…
tools Bug 19673: Allow to set patron attributes to 0 with batch patron modification 2018-05-22 11:28:42 +02:00
virtualshelves Bug 7663: Fix bad merge conflict with bug 15584 2017-03-03 18:18:14 +00:00
xt Bug 19262: Remove xt/author/pod_spell.t 2017-10-23 15:29:50 +02:00
.editorconfig
…
.htaccess
…
.mailmap Update mailmap - Jonathan Druart 2017-06-29 09:33:25 +02:00
INSTALL
…
Koha.pm Increment version for 17.05.11 release 2018-04-25 08:25:17 +02:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 19067: Map clubs/ into INTRANET_CGI_DIR in Makefile.PL 2017-09-12 16:04:02 +02:00
README
…
README.md Bug 15465: Fix typo in bugs.k-c.org 2017-05-26 11:45:31 -03:00
README.robots
…
about.pl Bug 18931 - Follow up - Typo fix in SQL statement 2017-07-27 10:25:20 +02:00
changelanguage.pl
…
edithelp.pl
…
fix-perl-path.PL
…
help.pl
…
install-CPAN.pl
…
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-02-17 12:13:44 +00:00
kohaversion.pl
…
mainpage.pl Bug 18432 : Follow up - Updating to use they/them 2017-04-21 10:56:43 -04:00
rewrite-config.PL Bug 15427 : Enable TLS support for MySQL 2017-03-03 18:33:07 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-community.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo