Go to file
Fridolyn SOMERS 5f4fce34b4 Bug 9504: URL escape in OPAC more searches
OPACSearchForTitleIn is a syspref used to add links as "more searches" in OPAC record detail page.
The links can contain vars depending on record values like title, ISBN, ...
Thoses values must be URL-escaped because they can contain special characters that will brake URL and/or HTML.

This patch add a method C4::Output::parametrized_url() that replaces vars in URL usign escape and UTF-8 encoding.

Test plan :
- Define in OPACSearchForTitleIn a link with all possible vars : TITLE, AUTHOR, ISBN, ISSN, CONTROLNUMBER, BIBLIONUMBER
- Edit a record to add special characters in title : ", &, ? ...
- Go to OPAC detail pages of this record
=> Check that URL is well encoded
=> Click on link to check the term is well encoded (diacritical characters, ...)

Signed-off-by: Liz Rea <liz@catalyst.net.nz>
Nice test plan, thanks!

Verified bug and fix - both look good.
Signed-off-by: Mason James <mtj@kohaaloha.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
2013-03-29 19:44:19 +13:00
C4 Bug 9504: URL escape in OPAC more searches 2013-03-29 19:44:19 +13:00
Koha Bug 9727: Fix typo in variable name 2013-03-29 19:16:19 +13:00
acqui Bug 7018 : need all acq permissions to search 2013-03-29 19:41:51 +13:00
admin Bug 9201 OAI-PMH mapping value cannot be 0 2013-02-07 08:29:08 +13:00
authorities BUG 9145: Authorities: standard language for UNIMARC 2013-02-21 18:44:16 +13:00
basket Bug 9073 - Download option from the cart should match the menu button in lists 2012-11-26 19:48:54 +13:00
catalogue Bug 9663 - Individual bibliographic record "Save" option requires export permission 2013-03-11 21:54:28 +13:00
cataloguing Bug 5333 - z3950 normalization should apply only on UNIMARC 2013-03-11 22:05:20 +13:00
circ Bug 9423: Add notforloan value to issue confirmation or blocking message 2013-03-29 19:36:21 +13:00
debian Bug 9256 - Fix search for the packages 2013-03-21 13:25:54 +13:00
docs Add Fred Pierre to history 2013-01-24 15:05:57 +13:00
errors Housekeeping in errors scripts 2010-05-12 07:29:03 -04:00
etc Bug 9256 - Fix search for the packages 2013-03-21 13:25:54 +13:00
install_misc Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-11 22:42:45 +13:00
installer Bug 9341: Problem with UNIMARC authors facets 2013-03-29 19:08:15 +13:00
koha-tmpl Bug 9423: Add notforloan value to issue confirmation or blocking message 2013-03-29 19:36:21 +13:00
labels Bug 8490: fix Plack error when creating label layout 2012-11-05 08:35:06 -05:00
members Bug 9586 - Remove $ENV{DEBUG} info from Member Template 2013-03-11 22:45:20 +13:00
misc 3.10.4 release notes 2013-03-22 21:52:07 +13:00
offline_circ Bug 8006 - Loading offline circulation does not anonymize 2012-06-20 19:40:41 +02:00
opac Bug 9504: URL escape in OPAC more searches 2013-03-29 19:44:19 +13:00
patroncards Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches 2013-03-17 12:31:40 +13:00
reports Bug 9451: Quiet warnings and Plackify borrower_stats.pl 2013-02-09 13:10:07 +13:00
reserve Bug 8675 Add hours and mins to renewal due date 2012-09-04 18:22:32 +02:00
reviews Bug 1623 - Provide view of approved comments 2011-12-27 18:26:50 +01:00
rotating_collections Bug 6553 : Follow up adding license statements 2011-08-13 19:54:38 +12:00
selenium Adding selenium tests for filterMembers 2009-09-30 11:30:37 +02:00
serials Bug 9574: Plack fixes for serials/subscription-add.pl 2013-03-11 22:18:04 +13:00
services Bug 7178: Acquisition item creation improvement 2012-03-26 11:07:23 +02:00
skel 8268 Followup for creating var spool subdir. 2012-07-23 10:40:43 +02:00
sms Bug 2505 - Add commented use warnings where missing in the sms/ directory 2010-04-21 20:25:08 +12:00
suggestion Bug 9226: Wrong branch filter after suggestion creation 2013-02-16 18:37:08 +13:00
svc Bug 7475: Teach matching rules to handle authorities 2012-09-19 17:15:56 +02:00
t Bug 9174: Fix itemtype image display in OPAC lists 2013-02-02 19:37:10 +13:00
tags Bug 8315 - remove use C4::* version 2012-07-13 14:17:20 +02:00
test Bug 5449: JSON malformed in Koha - Blocker with jQuery 1.4.x 2011-03-12 08:53:41 +13:00
tmp/modified_authorities
…
tools Bug 9415: XML catalog export is missing root node 2013-03-29 19:33:11 +13:00
virtualshelves Bug 7788: [SIGNED-OFF] Followup: GetShelf call in addbybiblio script corrected 2012-05-22 12:06:26 +02:00
xt Bug 8942 : Adding a test to make sure we don't use single quotes for js 2013-02-02 19:59:42 +13:00
.htaccess Fix file permissions: if it is not a script, it should not be executable. 2010-04-16 00:40:34 -04:00
.mailmap 7439 Mailmap for master 2012-01-27 12:27:58 +01:00
INSTALL Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.debian Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.fedora7 Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.opensuse Bug 7759, update of install files to use background indexing (and some whitespace tidy) 2012-04-20 16:11:52 +02:00
INSTALL.ubuntu Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
INSTALL.ubuntu.12.04 Bug 9267 - Ubuntu 12.04 install docs broken 2013-03-11 22:42:45 +13:00
INSTALL.ubuntu.lucid Bug 8092 follow-up: Add optional dependency on CHI 2012-06-09 13:08:18 +02:00
LICENSE Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes. 2010-03-16 20:17:48 -04:00
MANIFEST.SKIP Bug 9546 : Updating make manifest tardist 2013-02-09 12:31:39 +13:00
Makefile.PL Bug 9256 - Fix search for the packages 2013-03-21 13:25:54 +13:00
README updated links in README 2010-05-24 08:14:16 -04:00
README.robots Bug 6411 add another example to README.robots 2011-07-05 14:48:05 +12:00
about.pl Bug 8910 - silent warnings triggered in about.pl 2012-10-25 14:40:36 +02:00
changelanguage.pl Bug 6755 Problems with switching languages 2011-09-23 09:47:09 +12:00
edithelp.pl Bug 8622: Fix theme fallback 2012-09-05 11:39:14 +02:00
fix-perl-path.PL
…
help.pl Bug 8949: Trying to view help on a page without any help results in a nasty error 2012-11-05 08:39:23 -05:00
install-CPAN.pl Bug 5370: Fix all the references to koha.org 2010-11-08 09:41:49 +13:00
koha_perl_deps.pl Bug 8485 - Make koha_perl_deps.pl batch friendly Added a -b flag for brief which outputs only the perl library name (Foo::BaR), and added a -r flag for required which filters the list to required=Yes perl libraries. 2012-08-31 17:35:49 +02:00
kohaversion.pl Bumping the version number 2013-03-29 19:08:43 +13:00
mainpage.pl Bug 9008: warn if user is logged-in with admin account 2012-11-26 13:35:18 +13:00
rewrite-config.PL Bug 8268 follow-up: rewrite config correctly 2012-08-28 18:02:42 +02:00

README

Koha is a free software integrated library system.

Koha is distributed under the GNU GPL version 2 or later.
Please read the file LICENSE for more details.

To install or upgrade Koha, please see the INSTALL file appropriate
to your platform.

Report bugs at http://bugs.koha-community.org/

Visit the Koha Project website at http://www.koha-community.org/