b168f4a2e9
This patch adds a .perlcriticrc (copied from qa-test-tools) and fixes almost all perlcrictic violations according to this .perlcriticrc The remaining violations are silenced out by appending a '## no critic' to the offending lines. They can still be seen by using the --force option of perlcritic This patch also modify t/00-testcritic.t to check all Perl files using the new .perlcriticrc. I'm not sure if this test script is still useful as it is now equivalent to `perlcritic --quiet .` and it looks like it is much slower (approximatively 5 times slower on my machine) Test plan: 1. Run `perlcritic --quiet .` from the root directory. It should output nothing 2. Run `perlcritic --quiet --force .`. It should output 7 errors (6 StringyEval, 1 BarewordFileHandles) 3. Run `TEST_QA=1 prove t/00-testcritic.t` 4. Read the patch. Check that all changes make sense and do not introduce undesired behaviour Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> |
||
|---|---|---|
| .. | ||
| cataloguing | ||
| club | ||
| config | ||
| hold | ||
| letters | ||
| mana | ||
| members | ||
| records | ||
| virtualshelves | ||
| article_request | ||
| authentication | ||
| barcode | ||
| bib | ||
| bib_framework | ||
| bib_profile | ||
| checkin | ||
| checkout_notes | ||
| checkouts | ||
| convert_report | ||
| cover_images | ||
| creator_batches | ||
| holds | ||
| import_bib | ||
| localization | ||
| new_bib | ||
| problem_reports | ||
| renew | ||
| report | ||
| return_claims | ||
| split_callnumbers | ||