gitea
/
Koha-clms
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Koha-clms/opac
History
Tomas Cohen Arazi e360959752
Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 
This patch makes the following scripts use the new method for checking
suppression:

* opac/opac-ISBDdetail.pl
* opac/opac-MARCdetail.pl
* opac/opac-detail.pl

In the `opac-detail.pl` case, it is a simple change by removing MARC
data traversal in favor of the new method. The code checking
suppression gets moved up so we don't process or make any other
calculations if the record is suppressed.

The other two scripts where completely missing the check and thus
leaking suppressed records.

To test:
1. Pick two records, one marked as suppressed, and the other not
   suppressed.
2. Try acessing them in the OPAC detail page.
=> SUCCESS: Suppressed records are suppressed, and not suppressed ones
are not.
3. Try the same records on the ISBD and MARC view
=> FAIL: They are not suppressed!
4. Apply this patch
5. Repeat 2
=> SUCCESS: Suppression is still respected
6. Repeat 3
=> SUCCESS: Suppression is respected on the ISBD and MARC views
7. Sign off :-D

Signed-off-by: Magnus Enger <magnus@libriotech.no>
Works as advertised. Remember to activate OPAC suppression with
OpacSuppression.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
 		2025-03-06 13:54:28 +01:00
..
clubs Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
errors Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
external/overdrive Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
sci Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
sco Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
svc Bug 36112: Port default CHECKOUT_NOTE notice to TT 2025-02-19 17:05:35 +01:00
ilsdi.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
maintenance.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
oai.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-ISBDdetail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-03-06 13:54:28 +01:00
opac-MARCdetail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-03-06 13:54:28 +01:00
opac-account-pay-return.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-account-pay.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-account.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-addbybiblionumber.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-alert-subscribe.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-alert-subscriptions.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-article-request-cancel.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-authorities-home.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-authoritiesdetail.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-basket.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-blocked.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-browse.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-browser.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-changelanguage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-course-details.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-course-reserves.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-curbside-pickups.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-detail.pl Bug 28478: Make opac-*detail.pl scripts use Koha::Biblio->opac_suppressed() 2025-03-06 13:54:28 +01:00
opac-discharge.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-dismiss-message.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-downloadcart.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-downloadshelf.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-export.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-holdshistory.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-ics.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-idref.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-illrequests.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-image.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-imageviewer.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-issue-note.pl Bug 36112: Port default CHECKOUT_NOTE notice to TT 2025-02-19 17:05:35 +01:00
opac-library.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-main.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-memberentry.pl Bug 35635: Fix server-side check 2025-02-20 17:34:57 +01:00
opac-messaging.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-modrequest-suspend.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-modrequest.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-mymessages.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-news-rss.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-overdrive-search.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-page.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-passwd.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-password-recovery.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-patron-consent.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-patron-image.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-privacy.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-ratings.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-readingrecord.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-recall.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-recalls.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-registration-verify.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-renew.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-reportproblem.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-request-article.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-reserve.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-reset-password.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-restrictedpage.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-retrieve-file.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-review.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-routing-lists.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-search-history.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-search.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-sendbasket.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-sendshelf.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-serial-issues.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-shareshelf.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-shelves.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-showmarc.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-showreviews.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-suggestions.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-tags.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-tags_subject.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-topissues.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-user.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
opac-virtual-card.pl Bug 26777: Allow ability to select diffferent barcode types 2024-08-26 17:39:36 +02:00
tracklinks.pl Bug 38664: Tidy the whole codebase 2025-02-11 14:58:24 +01:00
unapi Bug 17600: Fix opac/unapi 2021-11-22 11:04:51 +01:00