Koha-clms/t/db_dependent
Marcel de Rooy 590cae04fd Bug 19096: Make Default authoritative in core modules
After feedback from the dev mailing list, it seems appropriate here to
propose making the Default framework authoritative for Koha to MARC
mappings. This implies checking only the Default framework in the
routines:

[1] GetMarcFromKohaField: The parameter frameworkcode is removed. A
    follow-up report (19097) will update the calls not adjusted here.
    This is safe since the parameter is silently ignored.
[2] GetMarcSubfieldStructureFromKohaField: Framework parameter is removed
    and calls are adjusted. Includes acquisitions_stats.pl.
[3] TransformKohaToMarc: The parameter is removed; all calls are verified
    or adjusted.
[4] TransformMarcToKoha: The parameter is no longer used and will be
    removed in a follow-up report (19097). It always goes to Default now.
[5] TransformMarcToKohaOneField: The parameter is removed and all calls
    are adjusted. Including: Breeding, XISBN and MetadataRecord modules.
[6] C4::Koha::IsKohaFieldLinked: This routine was called only once (in
    C4::Items::_build_default_values_for_mod_marc. It can be replaced by
    calling GetMarcFromKohaField. If there is no kohafield linked, undef
    is returned. (Corresponding unit test is removed here.)
[7] C4::Items::ModItemFromMarc: The helper routine
    _build_default_values_for_mod_marc does no longer have a framework
    parameter. The cache key default_value_for_mod_marc- is no longer
    combined with a frameworkcode. Three admin scripts are adjusted
    accordingly; some tests will be corrected in the next patch.

Test plan:
See next patch. That patch adjusts all tests involved.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2017-12-07 14:44:15 -03:00
..
Acquisition Bug 15685: (QA follow-up) Address QA issues 2017-10-11 13:08:47 -03:00
Auth
…
Authority Bug 17380: (QA followup) Fix parameter in tests 2017-09-12 12:07:47 -03:00
Biblio Bug 10306: (QA follow-up) Correct a TestBuilder call 2017-12-07 14:44:15 -03:00
Circulation Bug 19776: Fix random failures (category_type vs categorycode='X') 2017-12-07 14:43:32 -03:00
Creators
…
Exporter Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Holds Bug 18547: (QA follow-up) Add comments to make tests clearer 2017-11-26 11:30:22 -03:00
Illrequest Bug 7317: Remove traces of UnmediatedILL 2017-11-09 11:42:16 -03:00
Items Bug 19057: Move C4::Reserve::GetReserve to Koha::Holds 2017-09-01 17:05:17 -03:00
Koha Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
LDAP
…
Labels Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Letters Bug 19277: Make sure the tests will pass even if they are slow 2017-09-12 11:29:11 -03:00
Members Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
OAI Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Patron Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record
…
Reports Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml' 2017-10-25 12:14:32 -03:00
Reserves Bug 19437: (followup) Rearrange CancelExpiredReserves tests - fix typos 2017-10-09 13:47:02 -03:00
SIP Bug 19386: [QA Follow-up] Remove some default values 2017-10-06 12:00:19 -03:00
Search Bug 19775: Try & prevent Search/History.t to fail randomly 2017-12-07 13:42:45 -03:00
Serials Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Template/Plugin Bug 19655: Add tests 2017-11-26 12:59:31 -03:00
Utils Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
XSLT_Handler
…
api/v1 Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
data
…
selenium Bug 18298: Fix selenium tests 2017-10-17 12:40:45 -03:00
www Bug 19392: Clean-up behind auth_values_input_www.t 2017-09-29 17:12:19 -03:00
00-strict.t Bug 19178: Remove outdated sms/* scripts and related files 2017-10-27 14:10:29 -03:00
01-test_dbic.t Bug 18226: Perltidy + license 2017-06-05 17:52:48 -03:00
Accounts.t Bug 12768: Replacement cost and processing fee management 2017-10-20 17:14:33 -03:00
Acquisition.t Bug 19256: (QA followup) Remove warn from unit test 2017-09-07 15:03:04 -03:00
AdditionalField.t
…
Amazon.t
…
ArticleRequests.t Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
AudioAlerts.t
…
Auth.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
Auth_with_cas.t Bug 19373: Update tests 2017-10-16 09:38:41 -03:00
Auth_with_ldap.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
AuthorisedValues.t Bug 18748: Noisy t/db_dependent/AuthorisedValues.t 2017-07-14 12:29:22 -03:00
AuthoritiesMarc.t Bug 18448: Fix a few db_dependent tests 2017-04-21 00:09:43 +00:00
BackgroundJob.t
…
Barcodes.t
…
Barcodes_ValueBuilder.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Biblio.t Bug 10306: Add tests for module changes 2017-12-07 14:44:15 -03:00
Bookseller.t Bug 19256: Make Koha::Acq::Order using Koha::Object 2017-09-07 15:03:04 -03:00
Breeding.t
…
Budgets.t Bug 18999: (QA followup) ModReceiveOrder expects a hashref 2017-09-29 13:03:38 -03:00
Calendar.t Bug 9031: (QA follow-up) Final changes to Calendar::days_between 2017-10-27 14:09:04 -03:00
Charset.t
…
Circulation.t Bug 19776: Fix random failures (category_type vs categorycode='X') 2017-12-07 14:43:32 -03:00
ClassSource.t
…
Clubs.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ColumnsSettings.t
…
Context.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Contract.t
…
CourseReserves.t
…
DecreaseLoanHighHolds.t Bug 19776: Fix random failures (category_type vs categorycode='X') 2017-12-07 14:43:32 -03:00
Filter_MARC_ViewPolicy.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Fines.t
…
FrameworkPlugin.t
…
Heading_MARC21.t
…
Hold.t Bug 16187: Do not use DateTime directly 2017-10-20 16:51:25 -03:00
Holds.t Bug 19766: (bug 19058 follow-up) Fix Preview routing slip 2017-12-07 09:37:01 -03:00
HoldsQueue.t Bug 19059: Move C4::Reserves::CancelReserve to Koha::Hold->cancel 2017-09-12 12:42:58 -03:00
Holidays.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
ILSDI_Services.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Illrequestattributes.t Bug 7317: (followup) Make tests independent of data on the DB 2017-11-09 11:42:15 -03:00
Illrequests.t Bug 7317: (QA followup) Rename 'branch' for 'library' 2017-11-09 11:42:16 -03:00
ImportBatch.t Bug 19049: [QA Follow-up] Mock config, default format 2017-08-15 12:17:42 -03:00
Installer.t
…
Items.t Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Items_DelItemCheck.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
KitchenSinkPlugin.kpz
…
Koha.t Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes 2017-07-05 13:42:21 -03:00
Koha_Authority.t
…
Koha_Database.t
…
Koha_Elasticsearch.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Elasticsearch_Indexer.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_Misc_Files.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Koha_SearchEngine_Elasticsearch_Search.t Bug 19559: Add tests 2017-11-26 12:59:31 -03:00
Languages.t
…
Letters.t Bug 18990: Overdue Notices are not sending through SMS correctly 2017-12-07 09:37:11 -03:00
Linker_FirstMatch.t
…
Log.t Bug 18991: [QA Follow-up] Use schema txn_begin and txn_rollback 2017-07-28 11:23:40 -03:00
MarcModificationTemplates.t Bug 19069: Fix 'does not match' behaviour in MARC modification template 2017-10-27 14:09:01 -03:00
Members.t Bug 19126: Fix Members.t with IndependentBranches set 2017-08-25 12:12:04 -03:00
MungeMarcPrice.t
…
NewsChannels.t
…
Overdues.t
…
Passwordrecovery.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
PatronLists.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Patrons.t Bug 19176: Compare the number of seconds when comparing dates in tests 2017-10-30 14:55:18 -03:00
Plugins.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
QueryParser.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Record.t
…
RecordProcessor_EmbedSeeFromHeadings.t
…
RefundLostItemFeeRule.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Reports.t
…
Reserves.t Bug 19437: Rearranging tests for CancelExpiredReserves 2017-10-09 13:47:02 -03:00
RotatingCollections.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
Search.t Bug 10306: Add tests for module changes 2017-12-07 14:44:15 -03:00
Serials.t Bug 18782: Remove unused C4::Serials::getsupplierbyserialid 2017-07-05 13:41:47 -03:00
Serials_2.t Bug 18420: Do not use 'S' as patron category code in other tests 2017-04-21 10:49:25 -04:00
Service.t
…
ShelfBrowser.t Bug 19047: Fix AddBiblio call in ShelfBrowser.t 2017-08-10 16:25:32 -03:00
Sitemapper.t Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous code duplication 2017-06-05 17:52:48 -03:00
Stats.t Bug 18882: (QA follow-up) Ensure stats with no or undef location are set to NULL in db 2017-11-08 13:34:37 -03:00
SuggestionEngine_ExplodedTerms.t Bug 17989: (QA follow-up) Replace bad dots in SuggestionEngine_ExplodedTerms.t 2017-11-01 13:10:18 -03:00
Suggestions.t Bug 18420: Use TestBuilder to create a patron category in Suggestions.t 2017-04-21 10:49:25 -04:00
Tags.t
…
Templates.t Bug 17989: Include full path logic in _get_template_file 2017-11-01 13:10:17 -03:00
TestBuilder.t Bug 15339: Remove extra 'my' 2017-09-07 13:56:08 -03:00
Upload.t Bug 19420: (QA Follow-up) Fix test, correct POD 2017-11-08 13:31:37 -03:00
UsageStats.t Bug 10748: Add the ability to block return of lost items 2017-11-08 11:07:09 -03:00
Virtualshelves.t Bug 19176: Compare the number of seconds when comparing dates in tests 2017-10-30 14:55:18 -03:00
XISBN.t Bug 19440: Identify overlimit problems in XISBN tests 2017-10-09 16:15:52 -03:00
XSLT_Handler.t Bug 17807: Add format parameter to XSLT_Handler->transform 2017-08-30 15:06:40 -03:00
check_sysprefs.t
…
db_structure.t Bug 18292: Remove return 1 statements in tests 2017-08-15 12:17:42 -03:00
default_search_class.pl
…
rollingloans.t Bug 17829: Execute rollingloans tests in a transaction 2017-07-26 16:39:17 -03:00
sysprefs.t
…
zebra_config.pl
…