Koha-clms/C4
Jonathan Druart bddfed7591 Bug 19933: Remove patronflags - tricky ones
Here we are, patronflags is used in a couple of places where (almost) all flags
were really useful: C4::SIP::ILS::Patron->new and circulation.pl

This patch only deal with the circulation code as I am not convident
enough with SIP code.

The change does not seems trivial because of the complexity of the
existing code, but the logic is the same. We send a variable to the
template depending on the situation of the patron.

I guess only code eyes ball could catch issue in this patch quickly.

Maybe we need to find a good place in a Koha module to move this code
and provide code coverage (especially when C4::SIP::ILS::Patron will
reuse it).

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
2018-03-23 11:45:38 -03:00
..
AuthoritiesMarc
…
Barcodes
…
ClassSortRoutine
…
Creators
…
External
…
Form
…
Heading
…
ILSDI Bug 19933: Remove patronflags - easy ones 2018-03-23 11:45:38 -03:00
Installer Bug 20061: koha-common is not pulling libsearch-elasticsearch-perl 2018-02-23 10:49:42 -03:00
Labels Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Linker
…
Members
…
OAI Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios 2017-06-13 16:18:59 -03:00
Output
…
Patroncards Bug 18550: [Follow-up] Add POD descriptions to subs 2017-10-06 12:09:55 -03:00
Reports Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml' 2017-10-25 12:14:32 -03:00
SIP Bug 19933: Remove patronflags - tricky ones 2018-03-23 11:45:38 -03:00
Search
…
Serials Bug 20144: [sql_modes] Add default value for subscription_numberpatterns.description in tests 2018-02-13 13:58:53 -03:00
Utils Bug 20145: Do not insert 0000-00-00 in patron tests (and more) 2018-02-18 14:48:05 -03:00
Accounts.pm Bug 10021: Drop columns notify_id and notify_level from accountlines 2017-12-11 11:34:18 -03:00
Acquisition.pm Bug 17457: Adv. Acquisition search with ISBN variations 2018-03-23 11:45:38 -03:00
Auth.pm Bug 19160: (follow-up) Fix problems introduced by renaming logout_required to logout_if_required 2018-03-23 11:45:37 -03:00
Auth_cas_servers.yaml.sample
…
Auth_with_cas.pm Bug 19160: Add POD 2018-03-23 11:45:38 -03:00
Auth_with_ldap.pm
…
Auth_with_shibboleth.pm
…
AuthoritiesMarc.pm Bug 18458: Fix subfields ordering when Merging authority records 2017-12-22 13:15:36 -03:00
BackgroundJob.pm
…
Barcodes.pm
…
Biblio.pm Bug 20126: (follow-up bug 10455) Restore MARC field length calculation in ModBiblioMarc 2018-02-02 12:08:42 -03:00
Bookseller.pm
…
Boolean.pm
…
Breeding.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Budgets.pm Bug 18999: Modified SQL query in GetBudgetSpent() in C4/Budgets.pm 2017-09-29 13:03:38 -03:00
Calendar.pm Bug 14572 - insert_single_holiday() forces a value on an AUTO_INCREMENT column, during an INSERT 2017-07-06 14:29:04 -03:00
Charset.pm Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag" 2017-07-26 14:01:51 -03:00
Circulation.pm Bug 19933: Remove patronflags - In CanBookBeIssued 2018-03-23 11:45:38 -03:00
ClassSortRoutine.pm
…
ClassSource.pm
…
Context.pm Bug 19788: Preserve case sensitivity when creating Local preferences 2017-12-22 13:15:37 -03:00
Contract.pm
…
CourseReserves.pm Bug 18276: Remove GetBiblioFromItemNumber - Course reserves 2017-07-10 12:09:24 -03:00
Creators.pm
…
Debug.pm
…
HTML5Media.pm
…
Heading.pm
…
HoldsQueue.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
Images.pm
…
ImportBatch.pm Bug 20144: [sql_modes] Set import_records.marcxml_old to '' on INSERT 2018-02-13 13:58:54 -03:00
ImportExportFramework.pm
…
InstallAuth.pm Bug 19514: Add client-side check 2017-12-14 16:58:13 -03:00
Installer.pm Bug 14826: account_offset_types.sql is not in the mandatory subdir 2017-10-20 18:14:06 -03:00
ItemCirculationAlertPreference.pm
…
Items.pm Bug 17672: Add damaged_on to items and deleteditems tables 2018-02-18 16:48:43 -03:00
Koha.pm Bug 19096: Make Default authoritative in core modules 2017-12-07 14:44:15 -03:00
Labels.pm
…
Languages.pm
…
Letters.pm Bug 18570: (QA follow-up) Improved POD 2018-03-19 13:55:37 -03:00
Linker.pm
…
Log.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
MarcModificationTemplates.pm Bug 20144: [sql_modes] Set default value for marc_modification_template_actions 2018-02-13 13:58:55 -03:00
Matcher.pm Bug 18131: Followup - Use data if biblionumber_tag < 10 2017-11-26 12:59:51 -03:00
Members.pm Bug 19933: Remove patronflags - tricky ones 2018-03-23 11:45:38 -03:00
Message.pm
…
NewsChannels.pm Bug 19528: Fix a few typos like corrosponding 2017-10-27 14:09:04 -03:00
Output.pm Bug 18403: Fix POD for C4::Output::output_and_exit_if_error 2018-02-12 18:02:01 -03:00
Overdues.pm Bug 10021: Drop columns notify_id and notify_level from accountlines 2017-12-11 11:34:18 -03:00
Patroncards.pm
…
Print.pm
…
Record.pm Bug 20097: Use same regex in marc2dcxml and opac-export 2018-03-19 12:23:19 -03:00
Reports.pm
…
Reserves.pm Bug 19301: Remove C4::Reserves::OnShelfHoldsAllowed 2018-02-13 13:36:00 -03:00
Ris.pm Bug 10306: Core module changes for multiple mappings 2017-12-07 14:44:15 -03:00
RotatingCollections.pm
…
SMS.pm Bug 19134: C4::SMS falils on long driver name 2017-08-25 10:51:24 -03:00
Scheduler.pm
…
Scrubber.pm
…
Search.pm Bug 19971: Typo in the comments of parseQuery routine 2018-01-19 15:50:31 -03:00
Serials.pm Bug 20144: [sql_modes] Set subscription.numberlength and weeklength to NULL if not passed 2018-02-13 13:59:01 -03:00
Service.pm
…
ShelfBrowser.pm Bug 19040: Refactor GetMarcBiblio parameters 2017-08-25 10:23:42 -03:00
SocialData.pm
…
Stats.pm Bug 20144: [sql_modes] Fix default value for statistics.itemnumber 2018-02-13 13:58:52 -03:00
Suggestions.pm Bug 13287: (QA follow-up) Extend Suggestions.t for DelSuggestionsOlderThan 2018-02-26 13:24:45 -03:00
TTParser.pm
…
Tags.pm
…
Templates.pm Bug 17989: Resolve "verbatim paragraph in NAME section" warning in C4::Templates 2017-11-01 13:10:17 -03:00
TmplToken.pm
…
TmplTokenType.pm
…
UsageStats.pm Bug 20264: Remove syspref checkdigit 2018-03-23 11:45:38 -03:00
XISBN.pm Bug 20321: Remove get_biblionumber_from_isbn 2018-03-19 13:55:47 -03:00
XSLT.pm Bug 18921: Resolve a few warnings in C4/XSLT.pm 2017-09-07 14:34:42 -03:00