Go to file
Oleg Vasylenko 53eef191eb Bug 17988 - Select2 prevents correct tag expand/minimize functionality
Overview:
Select2 (Bug 13501) introduced divs and inputs that broke some assumptions about the expected HTML structure.
Because of that, expanding fields to show all hidden subfields does not work properly.

Steps to Reproduce:
1. Open some book in the editor or create new (cataloguing/addbiblio.pl)
2. Try to minimize or expand fields, that have among subfields the following:
	— Thesaurus driven subfield → subfield with Select2
	— Hidden subfield.

Actual Results:
 — some fields become hidden, some not, and vice versa
 — in the console, you'll see «Uncaught TypeError: Cannot read property 'match' of null»

Expected Results:
 — all subfields should minimize/maximize completely

Additional Information:
This happens because Select2 adds some divs, that do not have ID property.
The following patch adds check for the needed attribute existance.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
2017-02-23 09:36:21 +13:00
C4 Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan 2017-02-23 03:08:23 +13:00
Koha Bug 16929: [QA Follow-up] Shortcut methods and use statements 2017-01-31 13:39:16 +13:00
OpenILS
…
acqui Bug 17681: Exiisting typos might thow some feees when recieved 2017-01-03 14:44:41 +13:00
admin Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks 2016-10-22 14:36:49 +02:00
api/v1 Bug 17042: Fix missing column in hold.json 2016-08-07 09:33:33 +02:00
authorities Bug 17118: (follow-up 15381) Fix regression when clearing a linked authority 2016-09-08 21:42:15 +02:00
basket Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
catalogue Bug 16951: Replace some more 2017-01-03 14:44:42 +13:00
cataloguing Bug 17922: Use correct number of digits when replacing date placeholders 2017-02-23 03:08:41 +13:00
circ Bug 9569: Remove unused occurrence of AutoLocation 2017-01-31 11:54:50 +13:00
course_reserves Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
debian Bug 17871: (followup) Remove zebra::* from the packages templates 2017-02-23 03:08:02 +13:00
docs Bug 7143 : More new devs 2016-08-01 13:31:23 +02:00
errors Bug 15288: Error pages: Code duplication removal and better translatability 2016-01-27 05:57:34 +00:00
etc Bug 17871: Remove zebra::snippet to allow access to facets in YAZ 5.8.1+ 2017-02-23 03:07:58 +13:00
install_misc Bug 16770: Remove 2 other occurrences of libmemoize-memcached-perl 2016-08-01 10:20:51 +02:00
installer Increment version for 16.05.9 security release 2017-01-31 16:12:38 +13:00
koha-tmpl Bug 17988 - Select2 prevents correct tag expand/minimize functionality 2017-02-23 09:36:21 +13:00
labels Bug 17900: Fix possible SQL injection in patron cards template editing 2017-01-31 11:21:13 +13:00
members Bug 17905: FIX CSRF in member-flags 2017-01-31 11:46:33 +13:00
misc Fix notes typo 2017-01-31 16:47:12 +13:00
offline_circ Bug 15764: Fix timestamp sent by KOCT 2016-02-23 20:53:18 +00:00
opac Bug 16929: [QA Follow-up] Shortcut methods and use statements 2017-01-31 13:39:16 +13:00
patron_lists Bug 16154: CGI->multi_param - Force scalar context 2016-04-26 23:16:43 +00:00
patroncards Bug 17900: Fix possible SQL injection in patron cards template editing 2017-01-31 11:21:13 +13:00
plugins Bug 14951: Remove C4::Dates from plugins/*.pl files 2015-10-06 10:29:42 -03:00
reports Bug 17931: Remove unused vars from reserves_stats 2017-01-25 14:40:02 +13:00
reserve Bug 17028: Fix XSS in reserve/request.pl 2016-08-05 08:11:00 +02:00
reviews Bug 14779: Cannot paginate reviews 2015-09-07 11:38:26 -03:00
rotating_collections Bug 15066: Make transfer rotating collection works under Plack 2015-11-05 09:50:09 -03:00
serials Bug 12178: Update serial status to "claimed" when exporting to CSV 2016-08-01 11:49:39 +02:00
services
…
skel
…
sms Bug 15258: Fix Perl scripts declaring unused variables 2015-12-30 17:24:45 -07:00
suggestion Bug 16154: CGI->multi_param - Declare a list 2016-04-26 23:16:42 +00:00
svc Bug 17375: Search by dateofbirth - handle invalid dates 2016-11-02 17:58:26 +00:00
t Bug 15030: Add tests 2017-02-22 22:11:50 +13:00
tags Bug 16154: CGI->multi_param - Assign a list 2016-04-26 23:16:43 +00:00
test Bug 9819 - 'stopwords'-related code removed 2015-12-30 15:49:35 +00:00
tmp/modified_authorities
…
tools Bug 17420 - record export fails when itemtype on biblio 2016-12-12 14:54:08 +13:00
virtualshelves Bug 17901: Fix possible SQL injection in shelf editing 2017-01-31 11:21:33 +13:00
xt Bug 17469: Add missing sample notices fr-CA test 2017-01-25 14:43:08 +13:00
.editorconfig
…
.htaccess
…
.mailmap
…
INSTALL Bug 17626: Remove existing install instructions and link to the wiki pages instead 2016-12-12 14:54:13 +13:00
Koha.pm Increment version for 16.05.9 security release 2017-01-31 16:12:38 +13:00
LICENSE
…
MANIFEST.SKIP
…
Makefile.PL Bug 16952: Czech language definitions for sorting in Zebra 2016-11-02 18:35:55 +00:00
README
…
README.md Bug 15465 [QA Followup] - Update wording, switch logo, add links 2016-02-24 04:02:26 +00:00
README.robots
…
about.pl Bug 7533: Add a warning to the about page if template_cache_dir is not set 2017-02-22 22:09:18 +13:00
changelanguage.pl Bug 16776: Do not forget external language choice in language switcher 2016-08-23 11:51:49 +02:00
edithelp.pl Bug 16447: Remove occurrence of the borrow permission which does no longer exist 2016-05-05 21:28:14 +00:00
fix-perl-path.PL
…
help.pl Bug 16724: Fix link to the online documentation links 2016-08-01 09:22:30 +02:00
install-CPAN.pl
…
koha_perl_deps.pl Bug 17990: Refactor Perl module versions check 2017-01-30 00:56:20 +13:00
kohaversion.pl
…
mainpage.pl Bug 15548: Move new patron related code to Patron* 2016-03-03 14:38:26 -07:00
rewrite-config.PL Bug 16222: (QA followup) Add /api dir for the API 2016-04-20 21:18:36 +00:00

README.md

Koha is a free software integrated library system (ILS).

Koha is distributed under the GNU GPL version 3 or later.

Note: This is a synced mirror of the official Koha repo.

Note: Koha does not accept pull requests from git hosting sites.

Note: This project has its own bug tracker, to report a bug or submit a patch visit http://bugs.koha-comminity.org.

For guidelines on submitting patches for Koha please visit https://wiki.koha-community.org/wiki/SubmitingAPatch

The developers handbook can be found at https://wiki.koha-community.org/wiki/Developer_handbook

http://koha-community.org/

Koha Logo